Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 10199014: Merge 114800 - [chromium] Plumb a compositor surface ready notification through to the threaded com… (Closed)

Created:
8 years, 8 months ago by jamesr
Modified:
8 years, 8 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Merge 114800 - [chromium] Plumb a compositor surface ready notification through to the threaded compositor https://bugs.webkit.org/show_bug.cgi?id=84305 Patch by James Robinson <jamesr@chromium.org>; on 2012-04-20 Reviewed by Adrienne Walker. Source/Platform: Add a notification for when the compositor surface associated with a given view is ready to use. * chromium/public/WebLayerTreeView.h: (WebLayerTreeView): Source/WebCore: Plumb setSurfaceReady through to the scheduler. * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::setSurfaceReady): (WebCore): * platform/graphics/chromium/cc/CCLayerTreeHost.h: (CCLayerTreeHost): * platform/graphics/chromium/cc/CCProxy.h: (CCProxy): * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: (WebCore::CCSingleThreadProxy::setSurfaceReady): (WebCore): * platform/graphics/chromium/cc/CCSingleThreadProxy.h: (CCSingleThreadProxy): * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::setSurfaceReady): (WebCore): (WebCore::CCThreadProxy::setSurfaceReadyOnImplThread): (WebCore::CCThreadProxy::initializeImplOnImplThread): * platform/graphics/chromium/cc/CCThreadProxy.h: (CCThreadProxy): Source/WebKit/chromium: Adds a notification to WebWidget for when the compositor surface is ready to use. This exists to fix a race condition when WebKit requires that we enter compositing mode but we haven't completed initialization of the native window/etc backing the WebWidget, and we can't block for this initialization to complete without inducing deadlocks. In this situation, we proceed as usual except that we can't attempt to use the compositor context or it will fail. * public/WebWidget.h: (WebWidget): * src/WebLayerTreeView.cpp: (WebKit::WebLayerTreeView::setSurfaceReady): (WebKit): * src/WebPagePopupImpl.cpp: (WebKit::WebPagePopupImpl::setCompositorSurfaceReady): (WebKit): * src/WebPagePopupImpl.h: (WebPagePopupImpl): * src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::setCompositorSurfaceReady): (WebKit): * src/WebPopupMenuImpl.h: * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setCompositorSurfaceReady): (WebKit): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): * src/WebViewImpl.h: (WebViewImpl): TBR=jamesr@chromium.org BUG=123356 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=114979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3372 lines, -1 line) Patch
M Source/Platform/ChangeLog View 2 chunks +508 lines, -0 lines 0 comments Download
M Source/Platform/chromium/public/WebLayerTreeView.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +2336 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCProxy.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp View 2 chunks +12 lines, -1 line 0 comments Download
M Source/WebKit/chromium/ChangeLog View 1 chunk +464 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/public/WebWidget.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebLayerTreeView.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebPopupMenuImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebPopupMenuImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 3 chunks +10 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
8 years, 8 months ago (2012-04-24 01:29:38 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698