Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: Source/WebCore/ChangeLog

Side-by-side diff isn't available for this file because of its large size.
Issue 10199014: Merge 114800 - [chromium] Plumb a compositor surface ready notification through to the threaded com… (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: Source/WebCore/ChangeLog
===================================================================
--- Source/WebCore/ChangeLog (revision 114977)
+++ Source/WebCore/ChangeLog (working copy)
@@ -1,3 +1,2339 @@
+2012-04-20 James Robinson <jamesr@chromium.org>
+
+ [chromium] Plumb a compositor surface ready notification through to the threaded compositor
+ https://bugs.webkit.org/show_bug.cgi?id=84305
+
+ Reviewed by Adrienne Walker.
+
+ Plumb setSurfaceReady through to the scheduler.
+
+ * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+ (WebCore::CCLayerTreeHost::setSurfaceReady):
+ (WebCore):
+ * platform/graphics/chromium/cc/CCLayerTreeHost.h:
+ (CCLayerTreeHost):
+ * platform/graphics/chromium/cc/CCProxy.h:
+ (CCProxy):
+ * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
+ (WebCore::CCSingleThreadProxy::setSurfaceReady):
+ (WebCore):
+ * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
+ (CCSingleThreadProxy):
+ * platform/graphics/chromium/cc/CCThreadProxy.cpp:
+ (WebCore::CCThreadProxy::setSurfaceReady):
+ (WebCore):
+ (WebCore::CCThreadProxy::setSurfaceReadyOnImplThread):
+ (WebCore::CCThreadProxy::initializeImplOnImplThread):
+ * platform/graphics/chromium/cc/CCThreadProxy.h:
+ (CCThreadProxy):
+
+2012-04-20 Mark Pilgrim <pilgrim@chromium.org>
+
+ [Chromium] Call memoryUsageMB directly
+ https://bugs.webkit.org/show_bug.cgi?id=84376
+
+ Reviewed by Kentaro Hara.
+
+ Now that memoryUsageMB has been moved from PlatformSupport.h to
+ Platform.h, we need to be able to call it directly
+ from WebCore/bindings/v8/V8GCController.cpp.
+ That means we need a new MemoryUsageSupport class in
+ WebCore/platform/ and an implementation in
+ WebCore/platform/chromium/MemoryUsageSupportChromium.cpp.
+ Other ports are welcome to implement their memory usage
+ functions if they wish. This pattern was based on the
+ HistogramSupport/HistogramSupportChromium classes.
+
+ Part of a refactoring series. See tracking bug 82948.
+
+ * CMakeLists.txt:
+ * GNUmakefile.list.am:
+ * Target.pri:
+ * WebCore.gypi:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/v8/V8GCController.cpp:
+ (WebCore):
+ * platform/MemoryUsageSupport.cpp: Added.
+ (WebCore):
+ (WebCore::MemoryUsageSupport::memoryUsageMB):
+ * platform/MemoryUsageSupport.h: Added.
+ (WebCore):
+ (MemoryUsageSupport):
+ * platform/chromium/MemoryUsageSupportChromium.cpp: Added.
+ (WebCore):
+ (WebCore::MemoryUsageSupport::memoryUsageMB):
+ * platform/chromium/PlatformSupport.h:
+ (PlatformSupport):
+
+2012-04-20 Anders Carlsson <andersca@apple.com>
+
+ Re-land. The non-fast scrollable region is now always updated after layout, and frameViewScrollableAreasDidChange has been removed.
+
+ computeNonFastScrollableRegion needs to traverse the entire frame tree
+ https://bugs.webkit.org/show_bug.cgi?id=84409
+ <rdar://problem/11285741>
+
+ Reviewed by Dan Bernstein.
+
+ Now that scrollable areas won't be in the set of scrollable areas unless they are actually scrollable, we need to look for scrollable
+ areas in the entire frame tree since there can be a scrollable frame that's a subframe of a non-scrollable frame for example.
+
+ * page/scrolling/ScrollingCoordinator.cpp:
+ (WebCore::computeNonFastScrollableRegion):
+ (WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
+
+2012-04-20 Adrienne Walker <enne@google.com>
+
+ [chromium] Clip TransparencyWin to prevent OOM from large Skia canvas
+ https://bugs.webkit.org/show_bug.cgi?id=84289
+
+ Reviewed by James Robinson.
+
+ TransparencyWin will create a Skia canvas of whatever size is passed
+ in, even if the result will ultimately be clipped. Handle the clip
+ implicitly and try (in some cases) to create a smaller canvas. This
+ can happen due to RenderBox::paintBoxDecorations passing a paint rect
+ down of the entire element's size.
+
+ Modes with more complicated transforms (ScaleTransform, UnTransform)
+ are not handled yet.
+
+ Tests: TransparencyWin.ClippedKeepTransformNoLayer
+ TransparencyWin.ClippedKeepTransformOpaqueCompositeLayer
+ TransparencyWin.ClippedKeepTransformOpaqueWhiteLayer
+
+ * platform/graphics/chromium/TransparencyWin.cpp:
+ (WebCore::TransparencyWin::computeLayerSize):
+
+2012-04-04 Jer Noble <jer.noble@apple.com>
+
+ apple.com top navigation bar appears inside video during full screen exit animation
+ https://bugs.webkit.org/show_bug.cgi?id=83095
+
+ Reviewed by Eric Carlson.
+
+ Test: fullscreen/full-screen-exit-animation-stacking-context.html
+
+ Only tell ancestors of the full screen element that they are no longer ancestors once
+ the full screen animation is complete:
+ * dom/Document.cpp:
+ (WebCore::Document::webkitWillExitFullScreenForElement):
+ (WebCore::Document::webkitDidExitFullScreenForElement):
+
+ To facilitate writing reproducible LayoutTests, expose webkitWill/Did/Enter/ExitFullScreen
+ from the Internals object, so scripts can call them explicitly:
+ * testing/Internals.cpp:
+ (WebCore::Internals::webkitWillEnterFullScreenForElement): Call the Document equivalent.
+ (WebCore::Internals::webkitDidEnterFullScreenForElement): Ditto.
+ (WebCore::Internals::webkitWillExitFullScreenForElement): Ditto.
+ (WebCore::Internals::webkitDidExitFullScreenForElement): Ditto.
+ * testing/Internals.h:
+ * testing/Internals.idl:
+
+2012-04-17 Jer Noble <jer.noble@apple.com>
+
+ media-exit-fullscreen-button (and related enums) is unnecessary and should be removed.
+ https://bugs.webkit.org/show_bug.cgi?id=84162
+
+ Reviewed by Eric Carlson.
+
+ No new tests; no change in functionality so covered by existing tests.
+
+ Remove the media-exit-fullscreen-button keyword, and rename media-enter-fullscreen-button to
+ media-fullscreen-button.
+
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ * css/CSSValueKeywords.in:
+ * css/mediaControls.css:
+ (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
+ * platform/ThemeTypes.h:
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::paint):
+
+2012-04-20 Alexandre Elias <aelias@google.com>
+
+ [chromium] Fix compile errors when DEBUG_GL_CALLS is enabled
+ https://bugs.webkit.org/show_bug.cgi?id=84491
+
+ Reviewed by Ojan Vafai.
+
+ DEBUG_GL_CALLS had not been used in a while and the mode no longer
+ compiled when I tried it. I improved the GLC macro to support either
+ raw pointers or RefPtrs, and to be a single expression in order to
+ interact properly with if/else blocks. I fixed the cases where we
+ were passing in the "context" method pointer by mistake, and removed the
+ now-unnecessary "get()" calls for the RefPtrs.
+
+ No new tests. (No-op change in release builds.)
+
+ * platform/graphics/chromium/LayerRendererChromium.cpp:
+ (WebCore::LayerRendererChromium::initialize):
+ (WebCore::LayerRendererChromium::clearRenderSurface):
+ (WebCore::LayerRendererChromium::beginDrawingFrame):
+ (WebCore::LayerRendererChromium::doNoOp):
+ (WebCore::LayerRendererChromium::drawQuad):
+ (WebCore::LayerRendererChromium::drawTextureQuad):
+ (WebCore::LayerRendererChromium::drawHeadsUpDisplay):
+ (WebCore::LayerRendererChromium::finishDrawingFrame):
+ (WebCore::LayerRendererChromium::useRenderSurface):
+ (WebCore::LayerRendererChromium::bindFramebufferToTexture):
+ (WebCore::LayerRendererChromium::setScissorToRect):
+ (WebCore::LayerRendererChromium::setDrawViewportRect):
+ (WebCore::LayerRendererChromium::initializeSharedObjects):
+ (WebCore::LayerRendererChromium::cleanupSharedObjects):
+ * platform/graphics/chromium/LayerRendererChromium.h:
+ (WebCore):
+
+2012-04-20 Anders Carlsson <andersca@apple.com>
+
+ Fix build.
+
+ * page/scrolling/ScrollingCoordinator.cpp:
+ (WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
+
+2012-04-19 Simon Fraser <simon.fraser@apple.com>
+
+ Set m_compositingDependsOnGeometry to false if possible
+ https://bugs.webkit.org/show_bug.cgi?id=84391
+
+ Reviewed by James Robinson.
+
+ For some kinds of elements, RenderLayerCompositor has to delay decisions about
+ compositing until the element's size and/or position are known. This was previsouly
+ based on the confusingly named m_compositingDependsOnGeometry flag, but another
+ variant of the same technique, with an additional flag m_compositingNeedsUpdate,
+ was added in r98627.
+
+ Also, once the m_compositingDependsOnGeometry flag was set to true, nothing
+ set it to false, so every compositing layer update resulted in a computeCompositingRequirements()
+ pass over the layers.
+
+ Rename the m_compositingDependsOnGeometry flag to m_reevaluateCompositingAfterLayout,
+ and clear the flag when we do a layout-related compositing layer update.
+ Use the same flag for position:fixed compositing.
+
+ This requires RenderLayerCompositor to distinguish between style- and layout-
+ related updates, requiring some minor refactoring in FrameView.
+
+ Should not change behavior.
+
+ * dom/Document.cpp:
+ (WebCore::Document::recalcStyle):
+ (WebCore::Document::implicitClose):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::updateCompositingLayersAfterStyleChange):
+ (WebCore::FrameView::updateCompositingLayersAfterLayout):
+ (WebCore::FrameView::restoreBackingStores):
+ (WebCore::FrameView::layout):
+ * page/FrameView.h:
+ (FrameView):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::RenderLayerCompositor):
+ (WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
+ (WebCore::RenderLayerCompositor::updateCompositingLayers):
+ (WebCore::RenderLayerCompositor::layerTreeAsText):
+ (WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
+ (WebCore::RenderLayerCompositor::requiresCompositingForFrame):
+ (WebCore::RenderLayerCompositor::requiresCompositingForPosition):
+ * rendering/RenderLayerCompositor.h:
+ (RenderLayerCompositor):
+
+2012-04-20 Dan Bernstein <mitz@apple.com>
+
+ <rdar://problem/10786000> Selection highlights of lines in adjoining blocks can overlap
+ https://bugs.webkit.org/show_bug.cgi?id=84489
+
+ Reviewed by Anders Carlsson.
+
+ Test: fast/block/line-layout/selection-highlight-overlap.html
+
+ * rendering/EllipsisBox.cpp:
+ (WebCore::EllipsisBox::selectionRect): Changed to use
+ selection{Top,Height}AdjustedForPrecedingBlock().
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::paintSelection): Ditto.
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::inlineSelectionGaps): Ditto.
+ (WebCore::RenderBlock::blockBeforeWithinSelectionRoot): Added. Returns the block which is
+ likely to contain the selected line just before the first line in this block, if it is
+ within the same selection root.
+ * rendering/RenderBlock.h:
+ * rendering/RootInlineBox.cpp:
+ (WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock): Added. If the selection
+ starts before our block, finds the last line in the preceding block and adjusts the selection
+ top to avoid overlap with that line’s selection bottom.
+ * rendering/RootInlineBox.h:
+ (WebCore::RootInlineBox::selectionHeightAdjustedForPrecedingBlock): Added. Like
+ selectionHeight(), but uses selectionTopAdjustedForPrecedingBlock().
+
+2012-04-20 Xianzhu Wang <wangxianzhu@chromium.org>
+
+ Crash in getOrDrawNodeHighlight after r114659
+ https://bugs.webkit.org/show_bug.cgi?id=84486
+
+ Reviewed by Daniel Bates.
+
+ No new tests. Fixes a crash in test: inspector/elements/elements-panel-selection-on-refresh.html.
+
+ * inspector/DOMNodeHighlighter.cpp:
+
+2012-04-20 Brady Eidson <beidson@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=84490
+ PageGroupLoadDeferrer needs to take a ReasonForSuspension argument
+
+ Reviewed by Anders Carlsson.
+
+ No new tests. (Refactor, no change in behavior)
+
+ - Make PageGroupLoadDeferrer take a ReasonForSuspension argument so it can pass it along.
+ * page/PageGroupLoadDeferrer.cpp:
+ (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
+ * page/PageGroupLoadDeferrer.h:
+
+ - Change suspendScheduledTasks to take a ReasonForSuspension.
+ - As long as we're changing Document.h, add a m_suspendedScheduledTasks flag and some
+ ASSERTs to catch what would be epically wrong behavior in the future.
+ * dom/Document.cpp:
+ (WebCore::Document::Document):
+ (WebCore::Document::suspendScheduledTasks):
+ (WebCore::Document::resumeScheduledTasks):
+ * dom/Document.h:
+
+ - Pass ActiveDOMObject::WillShowDialog along to all PageGroupLoadDeferrers, as it used
+ to be the default behavior
+ * page/Chrome.cpp:
+ (WebCore::Chrome::runModal):
+ (WebCore::Chrome::runBeforeUnloadConfirmPanel):
+ (WebCore::Chrome::runJavaScriptAlert):
+ (WebCore::Chrome::runJavaScriptConfirm):
+ (WebCore::Chrome::runJavaScriptPrompt):
+ (WebCore::Chrome::shouldInterruptJavaScript):
+
+2012-04-20 Anders Carlsson <andersca@apple.com>
+
+ Scrolling after going to a find-in-page result jumps to the top of the page
+ https://bugs.webkit.org/show_bug.cgi?id=84485
+ <rdar://problem/11273734>
+
+ Reviewed by Beth Dakin.
+
+ If we're both updating the requested scroll position and entering slow mode in the same commit, the
+ probable main thread scroll position should be the requested scroll position.
+
+ * page/scrolling/mac/ScrollingTreeNodeMac.mm:
+ (WebCore::ScrollingTreeNodeMac::update):
+
+2012-04-20 James Robinson <jamesr@chromium.org>
+
+ Avoid synchronously recalculating the nonFastScrollableRegion when the ScrollableArea set changes
+ https://bugs.webkit.org/show_bug.cgi?id=84470
+
+ Reviewed by Anders Carlsson.
+
+ When a scrollable area is added or removed, we shouldn't recalculate the nonFastScrollableRegion synchronously
+ since this is slow, the RenderObject tree might not be in an up-to-date state, and we'll typically do layout
+ soon anyway.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::addScrollableArea):
+ (WebCore::FrameView::removeScrollableArea):
+ * page/scrolling/ScrollingCoordinator.cpp:
+ * page/scrolling/ScrollingCoordinator.h:
+ (ScrollingCoordinator):
+
+2012-04-20 Emil A Eklund <eae@chromium.org>
+
+ Fix use of LayoutUnits in DOMNodeHighlighter
+ https://bugs.webkit.org/show_bug.cgi?id=84472
+
+ Reviewed by Eric Seidel.
+
+ Fix use of subpixel units and rounding in new code introduced in r114659.
+
+ No new tests, no change in functionality.
+
+ * inspector/DOMNodeHighlighter.cpp:
+
+2012-04-17 Antonio Gomes <agomes@rim.com>
+
+ Relax ScrollView::adjustScrollPositionWithinRange in case constrainsScrollingToContentEdge is false
+ https://bugs.webkit.org/show_bug.cgi?id=84178
+
+ Reviewed by Adam Treat.
+
+ No new tests since it is not easily testable.
+
+ When a port has both delegatesScrolling and constrainsScrollingToContentEdge set to FALSE
+ (i.e. it accepts overscrolled position), calling ScrollView::setScrollPosition with an overscrolled
+ position still gets the position clamped to the content size edges.
+
+ Patch relaxes ::adjustScrollPositionWithinRange in that sense in order to track the actual scroll
+ position.
+
+ Note: ScrollView::setScrollOffset already does something similar.
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::adjustScrollPositionWithinRange):
+
+2012-04-20 Sheriff Bot <webkit.review.bot@gmail.com>
+
+ Unreviewed, rolling out r114535.
+ http://trac.webkit.org/changeset/114535
+ https://bugs.webkit.org/show_bug.cgi?id=84475
+
+ It might have caused V8 crashes. (Requested by pfeldman_ on
+ #webkit).
+
+ * bindings/v8/V8IsolatedContext.cpp:
+ (WebCore::V8IsolatedContext::V8IsolatedContext):
+ * bindings/v8/V8Proxy.cpp:
+ (WebCore::V8Proxy::evaluateInIsolatedWorld):
+ (WebCore::V8Proxy::setInjectedScriptContextDebugId):
+ (WebCore):
+ * bindings/v8/V8Proxy.h:
+ (V8Proxy):
+
+2012-04-20 Dean Jackson <dino@apple.com>
+
+ -webkit-filter missing from computed style enumeration
+ https://bugs.webkit.org/show_bug.cgi?id=84468
+
+ Reviewed by Timothy Hatcher.
+
+ CSSComputedStyleDeclaration has a list of properties that it exposes.
+ While the computed style for filter was available, the property wasn't
+ listed and hence missing in clients like the Web Inspector.
+
+ Covered by existing tests.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore): add CSSPropertyWebkitFilter
+
+2012-04-20 Emil A Eklund <eae@chromium.org>
+
+ [win] Update windows platform code to use pixel snapped values
+ https://bugs.webkit.org/show_bug.cgi?id=84283
+
+ Reviewed by Eric Seidel.
+
+ No new tests, no change in functionality.
+
+ * accessibility/AccessibilityObject.h:
+ (WebCore::AccessibilityObject::pixelSnappedElementRect):
+ Use pixel snapped values when computing screenRect.
+
+ * platform/win/PopupMenuWin.cpp:
+ (WebCore::PopupMenuWin::calculatePositionAndSize):
+ (WebCore::PopupMenuWin::paint):
+ Cast client padding to ints as they are guaranteed to align with device pixels.
+
+2012-04-20 Dana Jansens <danakj@chromium.org>
+
+ [chromium] Some filters require inflating damage rect in CCDamageTracker
+ https://bugs.webkit.org/show_bug.cgi?id=84373
+
+ Reviewed by James Robinson.
+
+ When a layer is blurred, damaged pixels are blurred out into a radius
+ and their damage should be expanded to include total blurred region.
+
+ Unit test: CCDamageTrackerTest.verifyDamageForBlurredSurface
+
+ * platform/graphics/chromium/cc/CCDamageTracker.cpp:
+ (WebCore::CCDamageTracker::updateDamageTrackingState):
+ (WebCore::CCDamageTracker::expandDamageRectWithForegroundFilters):
+ (WebCore):
+ * platform/graphics/chromium/cc/CCDamageTracker.h:
+ (WebCore):
+ (CCDamageTracker):
+ * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+ (WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):
+
+2012-04-20 Sami Kyostila <skyostil@chromium.org>
+
+ [chromium] Don't crash when scrolling empty layer tree
+ https://bugs.webkit.org/show_bug.cgi?id=84455
+
+ Reviewed by James Robinson.
+
+ Do not try to calculate render passes when there are no layers in the
+ layer tree.
+
+ Added new unit test.
+
+ * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+ (WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
+
+2012-04-20 Victor Carbune <vcarbune@adobe.com>
+
+ Ensure text is centered for default captions
+ https://bugs.webkit.org/show_bug.cgi?id=84450
+
+ Reviewed by Eric Carlson.
+
+ Updated existing test.
+
+ * html/track/TextTrackCue.cpp:
+ (WebCore::TextTrackCue::getDisplayTree): Added default width.
+
+2012-04-20 Pavel Feldman <pfeldman@chromium.org>
+
+ Web Inspector: open file dialog is not centered.
+ https://bugs.webkit.org/show_bug.cgi?id=84464
+
+ Reviewed by Yury Semikhatsky.
+
+ There was an error in the positioning logic.
+
+ * inspector/front-end/FilteredItemSelectionDialog.js:
+ (WebInspector.FilteredItemSelectionDialog.prototype.position):
+
+2012-04-20 Allan Sandfeld Jensen <allan.jensen@nokia.com>
+
+ [Qt] PlatformMouseEventQt.cpp should be deleted.
+ https://bugs.webkit.org/show_bug.cgi?id=84437
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ * platform/qt/PlatformMouseEventQt.cpp: Removed.
+
+2012-04-20 Pavel Feldman <pfeldman@chromium.org>
+
+ Web Inspector: follow up to r114729: more @return annotations added.
+ https://bugs.webkit.org/show_bug.cgi?id=84447
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/front-end/Resource.js:
+ (WebInspector.Resource):
+ (WebInspector.ResourceRevision.prototype.get content):
+ * inspector/front-end/ResourceTreeModel.js:
+ (WebInspector.ResourceTreeFrame.prototype._addRequest):
+ * inspector/front-end/ResourceUtils.js:
+ (String.prototype.asParsedURL):
+
+2012-04-20 Pavel Feldman <pfeldman@chromium.org>
+
+ Web Inspector: migrate from ScriptsNavigator to NavigatorView in the Styles panel
+ https://bugs.webkit.org/show_bug.cgi?id=84459
+
+ Reviewed by Yury Semikhatsky.
+
+ Now that NavigatorView has all the functionality we need, we can use it.
+
+ * inspector/front-end/NavigatorView.js:
+ (WebInspector.NavigatorScriptTreeElement.prototype.ondblclick):
+ * inspector/front-end/ScriptsNavigator.js:
+ (WebInspector.ScriptsNavigator):
+ * inspector/front-end/StylesPanel.js:
+ (WebInspector.StylesPanel):
+ (WebInspector.StylesPanel.prototype._resourceAdded):
+ (WebInspector.StylesPanel.prototype._reset):
+ (WebInspector.StylesPanel.prototype._itemSelected):
+ (WebInspector.StylesPanel.prototype._showFile):
+ * inspector/front-end/navigatorView.css:
+ (.navigator-tabbed-pane .tabbed-pane-content):
+ (.navigator-tabbed-pane .navigator-container):
+ (.navigator-tabbed-pane .navigator):
+ (.navigator-tabbed-pane .tabbed-pane-header):
+ (.navigator-tabbed-pane .tabbed-pane-header-contents):
+ * inspector/front-end/scriptsPanel.css:
+
+2012-04-20 Sam D <dsam2912@gmail.com>
+
+ Web Inspector: Does not have search navigation button for going through matches in either direction (prev, next)
+ https://bugs.webkit.org/show_bug.cgi?id=84235
+
+ Added buttons for navigating on seiarch matches in inspector panel
+ through button clicks as well.
+
+ Reviewed by Pavel Feldman.
+
+ No new tests / ux enhanced for search functionality
+
+ * English.lproj/localizedStrings.js:
+ * WebCore.gypi:
+ * inspector/front-end/Images/searchNext.png: Added.
+ * inspector/front-end/Images/searchPrev.png: Added.
+ * inspector/front-end/SearchController.js:
+ (WebInspector.SearchController):
+ (WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
+ (WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):
+ (WebInspector.SearchController.prototype._onNextButtonSearch):
+ (WebInspector.SearchController.prototype._onPrevButtonSearch):
+ (WebInspector.SearchController.prototype._performSearch):
+ (WebInspector.SearchController.prototype._createSearchNavigationButton):
+ (WebInspector.SearchController.prototype._populateSearchNavigationButtons):
+ * inspector/front-end/WebKit.qrc:
+ * inspector/front-end/inspector.css:
+ (.toolbar-search-item):
+ (#search):
+ (#toolbar-search-navigation-control):
+ (.toolbar-search-navigation-label):
+ (.toolbar-search-navigation-label:hover):
+ (.toolbar-search-navigation-icon-prev , .toolbar-search-navigation-icon-next):
+ (.toolbar-search-navigation-icon-prev):
+ (.toolbar-search-navigation-icon-next):
+ * inspector/front-end/inspector.html:
+
+2012-04-20 Pavel Feldman <pfeldman@chromium.org>
+
+ Web Inspector: extract NavigatorView and NavigatorOverlayController from ScriptsNavigator.
+ https://bugs.webkit.org/show_bug.cgi?id=84441
+
+ Reviewed by Yury Semikhatsky.
+
+ - Moves NavigatorOverlayController out of ScriptsNavigator
+ - Extracts NavigatorView from ScriptsNavigator and makes ScriptsNavigator contain 3 NavigatorView instances (one per tab)
+ - Subclasses SnippetsNavigatorView and leaves it within ScriptsNavigator.
+
+ * WebCore.gypi:
+ * WebCore.vcproj/WebCore.vcproj:
+ * inspector/compile-front-end.py:
+ * inspector/front-end/NavigatorOverlayController.js: Added.
+ (WebInspector.NavigatorOverlayController.prototype.wasShown):
+ (WebInspector.NavigatorOverlayController.prototype._createNavigatorControlButton):
+ (WebInspector.NavigatorOverlayController.prototype._escDownWhileNavigatorOverlayOpen):
+ (WebInspector.NavigatorOverlayController.prototype._toggleNavigator):
+ (WebInspector.NavigatorOverlayController.prototype._hidePinnedNavigator):
+ (WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
+ (WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
+ (WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
+ (WebInspector.NavigatorOverlayController.prototype._navigatorOverlayWasShown):
+ * inspector/front-end/NavigatorView.js: Added.
+ (WebInspector.NavigatorView):
+ (WebInspector.NavigatorView.prototype._updateScriptTitle.get if):
+ (WebInspector.NavigatorView.prototype._updateScriptTitle):
+ (WebInspector.NavigatorView.prototype._scriptSelected):
+ (WebInspector.NavigatorView.prototype._removeUISourceCode.get while):
+ (WebInspector.NavigatorView.prototype._removeUISourceCode):
+ (WebInspector.NavigatorView.prototype._showScriptFoldersSettingChanged):
+ (WebInspector.NavigatorView.prototype._fileRenamed):
+ (WebInspector.NavigatorView.prototype.rename.commitHandler):
+ (WebInspector.NavigatorView.prototype.rename.cancelHandler):
+ (WebInspector.NavigatorView.prototype.rename.afterEditing):
+ (WebInspector.NavigatorView.prototype.reset):
+ (WebInspector.NavigatorView.prototype.createFolderTreeElement):
+ (WebInspector.NavigatorView.prototype.getOrCreateFolderTreeElement):
+ (WebInspector.NavigatorView.prototype.handleContextMenu):
+ (WebInspector.NavigatorTreeOutline):
+ (WebInspector.NavigatorTreeOutline._treeElementsCompare.compare.typeWeight):
+ (WebInspector.NavigatorTreeOutline._treeElementsCompare):
+ (WebInspector.NavigatorTreeOutline.prototype.scriptTreeElements):
+ (WebInspector.NavigatorTreeOutline.prototype.searchStarted):
+ (WebInspector.NavigatorTreeOutline.prototype.searchFinished):
+ (WebInspector.BaseNavigatorTreeElement):
+ (WebInspector.BaseNavigatorTreeElement.prototype.onattach):
+ (WebInspector.BaseNavigatorTreeElement.prototype.onreveal):
+ (WebInspector.BaseNavigatorTreeElement.prototype.get titleText):
+ (WebInspector.BaseNavigatorTreeElement.prototype.set titleText):
+ (WebInspector.BaseNavigatorTreeElement.prototype.matchesSearchText):
+ (WebInspector.NavigatorFolderTreeElement):
+ (WebInspector.NavigatorFolderTreeElement.prototype.get folderIdentifier):
+ (WebInspector.NavigatorFolderTreeElement.prototype.get isDomain):
+ (WebInspector.NavigatorFolderTreeElement.prototype.onattach):
+ (WebInspector.NavigatorScriptTreeElement):
+ (WebInspector.NavigatorScriptTreeElement.prototype.get uiSourceCode):
+ (WebInspector.NavigatorScriptTreeElement.prototype.onattach):
+ (WebInspector.NavigatorScriptTreeElement.prototype.onspace):
+ (WebInspector.NavigatorScriptTreeElement.prototype._onclick):
+ (WebInspector.NavigatorScriptTreeElement.prototype.onenter):
+ (WebInspector.NavigatorScriptTreeElement.prototype._handleContextMenuEvent):
+ * inspector/front-end/ScriptsNavigator.js:
+ (WebInspector.ScriptsNavigator):
+ (WebInspector.ScriptsNavigator.prototype.addUISourceCode):
+ (WebInspector.ScriptsNavigator.prototype.isScriptSourceAdded):
+ (WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
+ (WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes):
+ (WebInspector.ScriptsNavigator.prototype._scriptSelected):
+ (WebInspector.ScriptsNavigator.prototype.reset):
+ (WebInspector.SnippetsNavigatorView):
+ (WebInspector.SnippetsNavigatorView.prototype.getOrCreateFolderTreeElement):
+ (WebInspector.SnippetsNavigatorView.prototype._getOrCreateSnippetEvaluationsFolderTreeElement):
+ (WebInspector.SnippetsNavigatorView.prototype.handleContextMenu):
+ (WebInspector.SnippetsNavigatorView.prototype._fileRenamed):
+ * inspector/front-end/WebKit.qrc:
+ * inspector/front-end/inspector.html:
+ * inspector/front-end/navigatorView.css: Added.
+ (.navigator-domain-tree-item .icon):
+ (.navigator-folder-tree-item .icon):
+ (.navigator-script-tree-item .icon):
+ (.navigator li):
+ (.navigator :focus li.selected):
+ (.navigator li.selected .selection):
+ (.navigator :focus li.selected .selection):
+ (.navigator .search-match-found li.selected .selection):
+ (.navigator .search-match-not-found li.selected .selection):
+ (.navigator .searching li.selected .selection):
+ (.navigator .icon):
+ (.navigator .base-navigator-tree-element-title):
+ (.navigator .base-navigator-tree-element-title.editing):
+ (.navigator-tree-search-box):
+ (.navigator-tree-search-box.visible):
+ (.navigator-tree-search-box > input):
+ * inspector/front-end/scriptsPanel.css:
+
+2012-04-19 Pavel Feldman <pfeldman@chromium.org>
+
+ Web Inspector: make ScriptNavigatorController use views only, rename to NavigatorOverlayController.
+ https://bugs.webkit.org/show_bug.cgi?id=84352
+
+ Reviewed by Vsevolod Vlasov.
+
+ This change makes navigator controller use view interfaces only. Focus machinery has been refactored in order
+ to make it possible: now all view ancestors can either override "focus" or "defaultFocusedElement" method
+ with latter method being preferred.
+
+ * inspector/front-end/ElementsPanel.js:
+ (WebInspector.ElementsPanel.prototype.defaultFocusedElement):
+ * inspector/front-end/ExtensionPanel.js:
+ (WebInspector.ExtensionPanel.prototype.defaultFocusedElement):
+ * inspector/front-end/Panel.js:
+ (WebInspector.Panel.prototype.wasShown):
+ (WebInspector.Panel.prototype.defaultFocusedElement):
+ * inspector/front-end/ScriptsNavigator.js:
+ (WebInspector.ScriptsNavigator):
+ (WebInspector.NavigatorOverlayController.prototype._hidePinnedNavigator):
+ (WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
+ (WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
+ (WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
+ (WebInspector.NavigatorOverlayController.prototype._navigatorOverlayWasShown):
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype.defaultFocusedElement):
+ * inspector/front-end/SidebarOverlay.js:
+ (WebInspector.SidebarOverlay.prototype.show):
+ (WebInspector.SidebarOverlay.prototype.hide):
+ * inspector/front-end/SourceFrame.js:
+ (WebInspector.SourceFrame.prototype.defaultFocusedElement):
+ * inspector/front-end/StylesPanel.js:
+ (WebInspector.StylesPanel):
+ * inspector/front-end/TabbedEditorContainer.js:
+ (WebInspector.TabbedEditorContainer.prototype.get view):
+ (WebInspector.TabbedEditorContainer.prototype.get visibleView):
+ * inspector/front-end/TabbedPane.js:
+ (WebInspector.TabbedPane):
+ (WebInspector.TabbedPane.prototype.defaultFocusedElement):
+ * inspector/front-end/TextViewer.js:
+ (WebInspector.TextViewer.prototype.defaultFocusedElement):
+ (WebInspector.TextEditorMainPanel.prototype.defaultFocusedElement):
+ * inspector/front-end/TimelinePanel.js:
+ (WebInspector.TimelinePanel.prototype.defaultFocusedElement):
+ * inspector/front-end/View.js:
+ (WebInspector.View.prototype._collectViewHierarchy):
+ (WebInspector.View.prototype.defaultFocusedElement):
+ (WebInspector.View.prototype.setDefaultFocusedElement):
+ (WebInspector.View.prototype.focus):
+
+2012-04-20 Sergio Villar Senin <svillar@igalia.com>
+
+ [GTK] Enable Web Timing
+ https://bugs.webkit.org/show_bug.cgi?id=42432
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Added WebTiming support to the GTK+ port. WebTiming allows
+ developers to collect detailed network timing information per
+ resource. It requires the new SoupMessage's "network-event"
+ signal.
+
+ * GNUmakefile.am:
+ * bindings/gobject/GNUmakefile.am:
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore):
+ (WebCore::restartedCallback):
+ (WebCore::sendRequestCallback):
+ (WebCore::milisecondsSinceRequest):
+ (WebCore::wroteBodyCallback):
+ (WebCore::requestStartedCallback):
+ (WebCore::networkEventCallback):
+ (WebCore::startHTTPRequest):
+ (WebCore::ResourceHandle::platformSetDefersLoading):
+ (WebCore::ResourceHandle::defaultSession):
+
+2012-04-20 'Pavel Feldman' <pfeldman@chromium.org>
+
+ Not reviewed: fixed chromium sanity tests for inspector via assigning last path component
+ to entire url for parsed urls with invalid specs.
+
+ * inspector/front-end/ResourceUtils.js:
+ (WebInspector.ParsedURL):
+
+2012-04-20 Kentaro Hara <haraken@chromium.org>
+
+ Unreviewed, rolling out r114401.
+ http://trac.webkit.org/changeset/114401
+ https://bugs.webkit.org/show_bug.cgi?id=84161
+
+ Chromium crash
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateHeader):
+ (NativeToJSValue):
+ * bindings/scripts/test/V8/V8Float64Array.h:
+ (WebCore):
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestActiveDOMObject.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestEventConstructor.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestEventTarget.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestInterface.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestNamedConstructor.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestNode.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestObj.h:
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8BlobCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8CSSRuleCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8CSSValueCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8DOMStringMapCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8DOMTokenListCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8DataViewCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8DocumentCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8EntryCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8EntrySyncCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8EventCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Float32ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Float64ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8HTMLElementCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8IDBAnyCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8IDBKeyCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8ImageDataCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Int16ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Int32ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Int8ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8LocationCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8NodeCustom.cpp:
+ (WebCore::toV8Slow):
+ * bindings/v8/custom/V8SVGDocumentCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8SVGElementCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8SVGPathSegCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8ScriptProfileCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8StyleSheetCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Uint16ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Uint32ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Uint8ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8WorkerContextCustom.cpp:
+ (WebCore::toV8):
+
+2012-04-20 Kentaro Hara <haraken@chromium.org>
+
+ Unreviewed, rolling out r114440.
+ http://trac.webkit.org/changeset/114440
+ https://bugs.webkit.org/show_bug.cgi?id=84173
+
+ Chromium crash
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateHeader):
+ * bindings/v8/custom/V8NodeCustom.cpp:
+ (WebCore::toV8Slow):
+
+2012-04-20 Kentaro Hara <haraken@chromium.org>
+
+ Unreviewed, rolling out r114519.
+ http://trac.webkit.org/changeset/114519
+ https://bugs.webkit.org/show_bug.cgi?id=84202
+
+ Chromium crash
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateHeader):
+ * bindings/scripts/test/V8/V8Float64Array.h:
+ (V8Float64Array):
+ (WebCore::V8Float64Array::wrap):
+ (WebCore):
+ * bindings/scripts/test/V8/V8TestActiveDOMObject.h:
+ (V8TestActiveDOMObject):
+ (WebCore::V8TestActiveDOMObject::wrap):
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
+ (V8TestCustomNamedGetter):
+ (WebCore::V8TestCustomNamedGetter::wrap):
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestEventConstructor.h:
+ (V8TestEventConstructor):
+ (WebCore::V8TestEventConstructor::wrap):
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestEventTarget.h:
+ (V8TestEventTarget):
+ (WebCore::V8TestEventTarget::wrap):
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestInterface.h:
+ (V8TestInterface):
+ (WebCore::V8TestInterface::wrap):
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
+ (V8TestMediaQueryListListener):
+ (WebCore::V8TestMediaQueryListListener::wrap):
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestNamedConstructor.h:
+ (V8TestNamedConstructor):
+ (WebCore::V8TestNamedConstructor::wrap):
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestNode.h:
+ (V8TestNode):
+ (WebCore::V8TestNode::wrap):
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestObj.h:
+ (V8TestObj):
+ (WebCore::V8TestObj::wrap):
+ (WebCore::toV8):
+ * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
+ (V8TestSerializedScriptValueInterface):
+ (WebCore::V8TestSerializedScriptValueInterface::wrap):
+ (WebCore::toV8):
+ * bindings/v8/custom/V8DocumentCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8NodeCustom.cpp:
+ (WebCore::toV8Slow):
+ * bindings/v8/custom/V8SVGDocumentCustom.cpp:
+ (WebCore::toV8):
+ * dom/make_names.pl:
+ (printWrapperFactoryCppFile):
+
+2012-04-19 Pavel Feldman <pfeldman@chromium.org>
+
+ Web Inspector: replace @type annotation with @return annotation for getters
+ https://bugs.webkit.org/show_bug.cgi?id=84362
+
+ Reviewed by Yury Semikhatsky.
+
+ Otherwise, compiler does not check for errors.
+
+ * inspector/front-end/AdvancedSearchController.js:
+ (WebInspector.SearchView.prototype.get searchConfig):
+ * inspector/front-end/BreakpointManager.js:
+ * inspector/front-end/NetworkRequest.js:
+ (WebInspector.NetworkRequest.prototype.requestContent):
+ * inspector/front-end/ResourceTreeModel.js:
+ (WebInspector.ResourceTreeFrame):
+ (WebInspector.ResourceTreeFrame.prototype._navigate):
+ * inspector/front-end/ScriptsNavigator.js:
+ * inspector/front-end/Settings.js:
+ * inspector/front-end/SnippetsModel.js:
+ * inspector/front-end/SplitView.js:
+ * inspector/front-end/TabbedEditorContainer.js:
+ * inspector/front-end/TabbedPane.js:
+ (WebInspector.TabbedPaneTab):
+ * inspector/front-end/TextEditorModel.js:
+ * inspector/front-end/TimelinePresentationModel.js:
+
+2012-04-20 Mark Pilgrim <pilgrim@chromium.org>
+
+ [Chromium] Call cacheMetadata directly
+ https://bugs.webkit.org/show_bug.cgi?id=84415
+
+ Reviewed by Kentaro Hara.
+
+ Part of a refactoring series. See tracking bug 82948.
+
+ * platform/chromium/PlatformSupport.h:
+ (PlatformSupport):
+ * platform/network/chromium/ResourceHandle.cpp:
+ (WebCore::ResourceHandle::cacheMetadata):
+
+2012-04-20 Mark Pilgrim <pilgrim@chromium.org>
+
+ [Chromium] Call stopSharedTimer directly
+ https://bugs.webkit.org/show_bug.cgi?id=84418
+
+ Reviewed by Kentaro Hara.
+
+ Part of a refactoring series. See tracking bug 82948.
+
+ * platform/chromium/PlatformSupport.h:
+ (PlatformSupport):
+ * platform/chromium/SharedTimerChromium.cpp:
+ (WebCore::stopSharedTimer):
+
+2012-04-20 Taiju Tsuiki <tzik@chromium.org>
+
+ DOMFileSystem::scheduleCallback() crashes on file() call after reload.
+ https://bugs.webkit.org/show_bug.cgi?id=76461
+
+ DOMFileSystem::scheduleCallback() is unavailable when the page in unloading, so we should
+ avoid using it in callback.
+
+ Reviewed by David Levin.
+
+ Test: fast/filesystem/file-after-reload-crash.html
+
+ * Modules/filesystem/DOMFileSystem.cpp:
+ (WebCore):
+
+2012-04-19 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
+
+ [EFL] Missing keycode translation for space key
+ https://bugs.webkit.org/show_bug.cgi?id=84153
+
+ Reviewed by Antonio Gomes.
+
+ Map space key to Unicode value in createKeyMap(), and also set
+ correct keyname 'space' for space key in createWindowsKeyMap().
+
+ Tests: fast/html/details-keyboard-show-hide.html
+ fast/forms/button-spacebar-click.html
+
+ * platform/efl/EflKeyboardUtilities.cpp:
+ (WebCore::createKeyMap):
+
+2012-04-19 Antaryami Pandia <antaryami.pandia@motorola.com>
+
+ Inserting empty html moves caret.
+ https://bugs.webkit.org/show_bug.cgi?id=71771
+
+ Reviewed by Ryosuke Niwa.
+
+ When we place the cursor in the middle of a text node and try to insert some text
+ between, then we split text node. But in this case we have nothing to insert since
+ the string to be inserted is empty. So the check for fragments should precedes the
+ call to code block containing splitTextNode.
+
+ Test: editing/inserting/insert-empty-html.html
+
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::doApply):
+
+2012-04-19 Tay Grigg <tgrigg@rim.com>
+
+ [BlackBerry] Update HTTP connection per host limit in ResourceRequestBlackBerry
+ https://bugs.webkit.org/show_bug.cgi?id=84380
+
+ Reviewed by George Staikos.
+
+ Reviewed Internally by: George Rizkalla, Lyon Chen
+
+ Set the limit on the http connection count per host to the default
+ of 10000, queue the requests in the networking layer instead,
+ this should increase parallelism at the WebKit layer to remove
+ any potential bottlenecks.
+
+ * platform/network/blackberry/ResourceRequestBlackBerry.cpp:
+ (WebCore::initializeMaximumHTTPConnectionCountPerHost):
+
+2012-04-19 Sheriff Bot <webkit.review.bot@gmail.com>
+
+ Unreviewed, rolling out r114711.
+ http://trac.webkit.org/changeset/114711
+ https://bugs.webkit.org/show_bug.cgi?id=84412
+
+ Many tests crash in RenderObject::container() (Requested by
+ dimich on #webkit).
+
+ * page/scrolling/ScrollingCoordinator.cpp:
+ (WebCore::computeNonFastScrollableRegion):
+ (WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
+ (WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
+
+2012-04-19 Anders Carlsson <andersca@apple.com>
+
+ computeNonFastScrollableRegion needs to traverse the entire frame tree
+ https://bugs.webkit.org/show_bug.cgi?id=84409
+ <rdar://problem/11285741>
+
+ Reviewed by Dan Bernstein.
+
+ Now that scrollable areas won't be in the set of scrollable areas unless they are actually scrollable, we need to look for scrollable
+ areas in the entire frame tree since there can be a scrollable frame that's a subframe of a non-scrollable frame for example.
+
+ * page/scrolling/ScrollingCoordinator.cpp:
+ (WebCore::computeNonFastScrollableRegion):
+ Traverse the entire frame tree looking for scrollable areas. Also, remove the scrollability checks because scrollable areas will only be
+ in the set if they have scrollbars that are enabled.
+
+ (WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
+ (WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
+ computeNonFastScrollableRegion now takes the main frame.
+
+2012-04-19 Anders Carlsson <andersca@apple.com>
+
+ Focus ring on wikipedia gets blobs when you type
+ https://bugs.webkit.org/show_bug.cgi?id=84407
+ <rdar://problem/11011847>
+
+ Reviewed by Dan Bernstein.
+
+ Make it possible to override the focus ring visible rect from layer drawing code.
+
+ * platform/graphics/mac/WebLayer.mm:
+ (drawLayerContents):
+ Call ThemeMac::setFocusRingClipRect to set the focus ring clip rect while drawing.
+
+ * platform/mac/ThemeMac.h:
+ * platform/mac/ThemeMac.mm:
+ (-[WebCoreFlippedView _focusRingVisibleRect]):
+ If there's an active focus ring visible rect, use it. Otherwise, fall back to the previous behavior
+ and just return the view's visible rect.
+
+ (WebCore::ThemeMac::setFocusRingClipRect):
+ Update the focus clip rect.
+
+2012-04-19 Sheriff Bot <webkit.review.bot@gmail.com>
+
+ Unreviewed, rolling out r114690.
+ http://trac.webkit.org/changeset/114690
+ https://bugs.webkit.org/show_bug.cgi?id=84408
+
+ Broke GlueSerializeTest.BackwardsCompatibleTest in Chromium
+ test_shell_tests (Requested by dimich on #webkit).
+
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::HistoryItem):
+ * loader/HistoryController.cpp:
+ (WebCore::HistoryController::restoreScrollPositionAndViewState):
+
+2012-04-19 Andreas Kling <kling@webkit.org>
+
+ ElementAttributeData should be fast-malloc'd.
+ <http://webkit.org/b/84405>
+
+ Reviewed by Antti Koivisto.
+
+ Sprinkle missing WTF_MAKE_FAST_ALLOCATED.
+
+ * dom/ElementAttributeData.h:
+ (ElementAttributeData):
+
+2012-04-19 David Barr <davidbarr@chromium.org>
+
+ REGRESSION(r112177): Numbered list item rendered bulleted
+ https://bugs.webkit.org/show_bug.cgi?id=84216
+
+ Reviewed by Ryosuke Niwa.
+
+ Shorthands that imply omitted values cannot be derived from
+ an incomplete set of longhand rules.
+
+ No new tests; updated existing tests that should have caught this.
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseTransformOriginShorthand):
+ Set implicit initial for Z when omitted.
+ * css/StylePropertySet.cpp:
+ (WebCore::StylePropertySet::getShorthandValue):
+
+2012-04-19 Peter Beverloo <peter@chromium.org>
+
+ [Chromium] Don't compile FontCacheSkia for Android
+ https://bugs.webkit.org/show_bug.cgi?id=84392
+
+ Reviewed by Kent Tamura.
+
+ Chromium for the Android platform uses its own FontCacheAndroid
+ implementation. Compile errors show up when trying to build the
+ content shell.
+
+ * WebCore.gyp/WebCore.gyp:
+
+2012-04-19 Martin Robinson <mrobinson@igalia.com>
+
+ [Cairo] Remove rgb24-hacks.txt and scale-removal.txt
+ https://bugs.webkit.org/show_bug.cgi?id=83475
+
+ Reviewed by Daniel Bates.
+
+ No new tests. This does not change functionality.
+
+ Remove some obsolete patch files for Cairo that were used in some
+ very old versions of Safari for Windows.
+
+ * platform/graphics/cairo/rgb24-hacks.txt: Removed.
+ * platform/graphics/cairo/scale-removal.txt: Removed.
+
+2012-04-19 Peter Beverloo <peter@chromium.org>
+
+ Use sqrtf instead of sqrt in CanvasRenderingContext2D.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=84403
+
+ Reviewed by Andreas Kling.
+
+ r114679 broke Chromium Win and Android bots due to call
+ ambiguity between a double and float argument.
+
+ * html/canvas/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::inflateStrokeRect):
+
+2012-04-19 Alexandre Elias <aelias@google.com>
+
+ Default to null value for HistoryItem::m_pageScaleFactor
+ https://bugs.webkit.org/show_bug.cgi?id=84385
+
+ Reviewed by Nate Chapin.
+
+ Previously, HistoryItem::m_pageScaleFactor defaulted to a value
+ of 1, making it impossible to determine whether this value was never
+ set, or intentionally set to 1. This patch introduces a default value
+ of 0 and makes restoreScrollPositionAndViewState not touch the page
+ scale factor if this value is still present at time of reload.
+
+ This is a no-op change for common navigation scenarios. The
+ motivation for this change is the corner case of syncing history items
+ from a desktop browser to a mobile device. In that case, we need a
+ way to specify that the history item does not contain a
+ pageScaleFactor so that the mobile device does not display the page
+ overly zoomed in.
+
+ No new tests.
+
+ * history/HistoryItem.cpp:
+ (WebCore::HistoryItem::HistoryItem):
+ * loader/HistoryController.cpp:
+ (WebCore::HistoryController::restoreScrollPositionAndViewState):
+
+2012-04-19 Alexis Menard <alexis.menard@openbossa.org>
+
+ Unreviewed Qt build warning fix.
+
+ The file editing/StringHelper.h does not exist.
+
+ * Target.pri:
+
+2012-04-19 Daniel Bates <dbates@webkit.org>
+
+ Remove empty directory Source/WebCore/webaudio
+
+ Changeset 111474 <http://trac.webkit.org/changeset/111474> moved all the files in
+ Source/WebCore/webaudio to Source/WebCore/Modules/webaudio. We should remove the
+ empty directory Source/WebCore/webaudio.
+
+ * webaudio: Removed.
+
+2012-04-19 Pratik Solanki <psolanki@apple.com>
+
+ Incorrect inter-caps in “ShouldSkipMetaData” etc.
+ https://bugs.webkit.org/show_bug.cgi?id=72159
+
+ Reviewed by Dan Bernstein.
+
+ No new tests since no change in functionality.
+
+ * platform/graphics/ImageSource.h:
+ * platform/graphics/cg/ImageSourceCG.cpp:
+ (WebCore::imageSourceOptions):
+ (WebCore::ImageSource::isSizeAvailable):
+ (WebCore::ImageSource::frameSizeAtIndex):
+ (WebCore::ImageSource::orientationAtIndex):
+ (WebCore::ImageSource::getHotSpot):
+ (WebCore::ImageSource::repetitionCount):
+ (WebCore::ImageSource::createFrameAtIndex):
+ (WebCore::ImageSource::frameDurationAtIndex):
+
+2012-04-19 Huang Dongsung <luxtella@company100.net>
+
+ Canvas more precisely makes the bounding rect for stroke rendering.
+ https://bugs.webkit.org/show_bug.cgi?id=75792
+
+ Reviewed by Simon Fraser.
+
+ * html/canvas/CanvasRenderingContext2D.cpp:
+ (WebCore::CanvasRenderingContext2D::stroke):
+ (WebCore::CanvasRenderingContext2D::drawTextInternal):
+ (WebCore::CanvasRenderingContext2D::inflateStrokeRect):
+ (WebCore):
+ * html/canvas/CanvasRenderingContext2D.h:
+ (CanvasRenderingContext2D):
+
+2012-04-19 Luke Macpherson <macpherson@chromium.org>
+
+ Eliminate potential null pointer dereference in CSSStyleSelector::containsUncommonAttributeSelector().
+ https://bugs.webkit.org/show_bug.cgi?id=84366
+
+ Reviewed by Kentaro Hara.
+
+ No new tests / code cleanup only.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::collectMatchingRulesForList):
+
+2012-04-19 Luke Macpherson <macpherson@chromium.org>
+
+ Fix null-pointer dereference in ApplyPropertyZoom::applyValue().
+ https://bugs.webkit.org/show_bug.cgi?id=84279
+
+ Reviewed by Simon Fraser.
+
+ Test: fast/css/zoom-on-unattached.html
+
+ * css/CSSStyleApplyProperty.cpp:
+ (WebCore::ApplyPropertyZoom::applyValue):
+
+2012-04-19 Luke Macpherson <macpherson@chromium.org>
+
+ Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to current()).
+ https://bugs.webkit.org/show_bug.cgi?id=84369
+
+ Reviewed by Simon Fraser.
+
+ No new tests / code cleanup only.
+
+ * css/MediaQueryExp.cpp:
+ (WebCore::MediaQueryExp::MediaQueryExp):
+
+2012-04-19 Mark Pilgrim <pilgrim@chromium.org>
+
+ [Chromium] Call signedPublicKeyAndChallengeString directly
+ https://bugs.webkit.org/show_bug.cgi?id=84372
+
+ Reviewed by Kentaro Hara.
+
+ Part of a refactoring series. See tracking bug 82948.
+
+ * platform/chromium/PlatformSupport.h:
+ (PlatformSupport):
+ * platform/chromium/SSLKeyGeneratorChromium.cpp:
+ (WebCore::signedPublicKeyAndChallengeString):
+
+2012-04-19 Luke Macpherson <macpherson@chromium.org>
+
+ Remove unnecessary assignment in CSSParser::parseCubicBezierTimingFunctionValue().
+ https://bugs.webkit.org/show_bug.cgi?id=84368
+
+ Reviewed by Simon Fraser.
+
+ No new tests / code cleanup only.
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseCubicBezierTimingFunctionValue):
+
+2012-04-19 Luke Macpherson <macpherson@chromium.org>
+
+ Initialize all member variables in CSSImageSetValue's copy constructor.
+ https://bugs.webkit.org/show_bug.cgi?id=84379
+
+ Reviewed by Simon Fraser.
+
+ No new tests / code cleanup only.
+
+ * css/CSSImageSetValue.cpp:
+ (WebCore::CSSImageSetValue::CSSImageSetValue):
+
+2012-04-19 Ken Buchanan <kenrb@chromium.org>
+
+ Positioned children of ruby runs not handled correctly during layout
+ https://bugs.webkit.org/show_bug.cgi?id=84157
+
+ Reviewed by Julien Chaffraix.
+
+ A positioned ruby text causes a problem because it is excluded from
+ normal layout by its parent and instead gets layout from
+ RenderRubyRun::layoutSpecialExcludedChild; however this means it gets
+ skipped over during the loop in RenderBlock::layoutBlockChildren,
+ which is where positioned RenderBlocks get added to the appropriate
+ positioned object lists. As a result, a dirty positioned ruby text
+ will not get layout again unless the RenderRubyRun also needs layout
+ which is not guaranteed.
+
+ This patch disqualifies ruby text elements from being positioned.
+ If it is necessary to support this in future, ruby text layout will
+ have to be modified to ensure the renderers are added to the
+ appropriate block lists.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::adjustRenderStyle):
+ * rendering/RenderRubyRun.cpp:
+ (WebCore::RenderRubyRun::rubyText):
+
+2012-04-19 vsevik@chromium.org <vsevik@chromium.org>
+
+ Web Inspector: No response body available for cached resource requests with error status codes.
+ https://bugs.webkit.org/show_bug.cgi?id=84265
+
+ Reviewed by Pavel Feldman.
+
+ InspectorResourceAgent now saves failed subresource request response body in its cache.
+ Saved data is shown on front-end.
+
+ Test: http/tests/inspector/network/network-image-404.html
+
+ * inspector/InspectorResourceAgent.cpp:
+ (WebCore::isErrorStatusCode):
+ (WebCore):
+ (WebCore::InspectorResourceAgent::didReceiveData):
+ * inspector/NetworkResourcesData.cpp:
+ (WebCore::NetworkResourcesData::ResourceData::removeContent):
+ (WebCore::NetworkResourcesData::ResourceData::purgeContent):
+ (WebCore):
+ (WebCore::NetworkResourcesData::responseReceived):
+ (WebCore::NetworkResourcesData::setResourceContent):
+ * inspector/NetworkResourcesData.h:
+ (ResourceData):
+ (WebCore::NetworkResourcesData::ResourceData::httpStatusCode):
+ (WebCore::NetworkResourcesData::ResourceData::setHTTPStatusCode):
+ * inspector/front-end/RequestView.js:
+ (WebInspector.RequestView.hasTextContent):
+
+2012-04-19 Yury Semikhatsky <yurys@chromium.org>
+
+ Web Inspector / Heap snapshots: "Object's retaining tree" view doesn't get cleared when navigating between objects
+ https://bugs.webkit.org/show_bug.cgi?id=84337
+
+ When DataGrid root node is reset, make sure all existing rows are removed.
+
+ Reviewed by Vsevolod Vlasov.
+
+ * inspector/front-end/DataGrid.js:
+ (WebInspector.DataGrid.prototype.setRootNode):
+
+2012-04-19 Beth Dakin <bdakin@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=80536
+ REGRESSION: When Safari is not frontmost, pages should not get mouse moves or
+ hover
+
+ Reviewed by Adele Peterson.
+
+ This patch just adds some code back that was removed by
+ http://trac.webkit.org/changeset/102632 This particular code was unrelated to that
+ bug and should not have been removed.
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMouseMoveEvent):
+
+2012-04-19 Xianzhu Wang <wangxianzhu@chromium.org>
+
+ DevTools highlights elements in frames at un-scaled positions
+ https://bugs.webkit.org/show_bug.cgi?id=84181
+
+ On mobile platforms (e.g. chromium-android), normally pages are scaled,
+ thus the coordinations of highlight rect inside of a frame needs to
+ consider not only the offset, but also the scale. The change uses
+ FrameView::contentsToRootView() to map the coordinates of a node in
+ a frame to the coordinates in the main frame, instead of calculating
+ by only the offset.
+
+ Reviewed by Pavel Feldman.
+
+ Test: inspector/elements/highlight-node-scaled.html
+
+ * inspector/DOMNodeHighlighter.cpp:
+
+2012-04-19 Yury Semikhatsky <yurys@chromium.org>
+
+ Web Inspector / Heap snapshots: "Objects allocated ..." views are empty
+ https://bugs.webkit.org/show_bug.cgi?id=84347
+
+ Pass parsed maxJSObjectId value to the profile header constructor.
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/ProfilesPanel.js:
+ (WebInspector.ProfileHeader):
+ (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
+ (WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
+ (WebInspector.ProfilerDispatcher.prototype.addProfileHeader):
+
+2012-04-19 Brady Eidson <beidson@apple.com>
+
+ <rdar://problem/10664148> and https://bugs.webkit.org/show_bug.cgi?id=84360
+ StorageThread should have an autorelease pool in place for Cocoa clients
+
+ Reviewed by Eric Carlson.
+
+ No new tests. (Not practical to test this with current tools)
+
+ * storage/StorageThread.cpp:
+ (WebCore::StorageThread::threadEntryPoint): Include an AutodrainedPool and cycle it after each message.
+
+2012-04-19 Luke Macpherson <macpherson@chromium.org>
+
+ Fix potential null pointer dereference in RuleSet::addRulesFromSheet().
+ https://bugs.webkit.org/show_bug.cgi?id=84258
+
+ Reviewed by Andreas Kling.
+
+ Fix variable that is dereferenced without null check here, but checked in code above and below.
+
+ No new test / code cleanup from coverity analysis.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::collectMatchingRulesForList):
+
+2012-04-19 Yury Semikhatsky <yurys@chromium.org>
+
+ Web Inspector: exception when hovering object while paused
+ https://bugs.webkit.org/show_bug.cgi?id=84358
+
+ Added missing boolean parameter to the call site of evaluate method
+ on call frame.
+
+ Reviewed by Vsevolod Vlasov.
+
+ * inspector/front-end/AdvancedSearchController.js:
+ * inspector/front-end/DebuggerPresentationModel.js: annotated slectedCallFrame
+ method so that closure compiler catches errors like in the bug report.
+ (WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
+ * inspector/front-end/JavaScriptSourceFrame.js:
+ (WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
+
+2012-04-19 Yury Semikhatsky <yurys@chromium.org>
+
+ Web Inspector: nodes are not removed from the summary view when switching between allocation ranges
+ https://bugs.webkit.org/show_bug.cgi?id=84354
+
+ Clear all top level nodes not only those visible in the viewport when populating
+ the constructors view with new content.
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/HeapSnapshotDataGrids.js:
+ (WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
+ (WebInspector.HeapSnapshotSortableDataGrid.prototype.topLevelNodes):
+ (WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
+ (WebInspector.HeapSnapshotViewportDataGrid.prototype.topLevelNodes):
+ (WebInspector.HeapSnapshotViewportDataGrid.prototype.removeTopLevelNodes):
+ (WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
+ (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
+
+2012-04-19 Sami Kyostila <skyostil@chromium.org>
+
+ [chromium] Allow scrolling non-root layers in the compositor thread
+ https://bugs.webkit.org/show_bug.cgi?id=73350
+
+ Reviewed by James Robinson.
+
+ This patch enables scrolling child layers in the compositor thread.
+ Scroll deltas are accumulated for each scrolled CCLayerImpl and
+ synchronized to the main thread.
+
+ If a layer has no room to scroll in a given direction, one of its
+ ancestor layers is scrolled instead if possible.
+
+ Added new webkit_unit_tests to verify scrolling behavior.
+
+ * platform/graphics/chromium/ContentLayerChromium.cpp:
+ (WebCore::ContentLayerChromium::scrollBy):
+ (WebCore):
+ * platform/graphics/chromium/ContentLayerChromium.h:
+ (ContentLayerDelegate):
+ (ContentLayerChromium):
+ * platform/graphics/chromium/GraphicsLayerChromium.h:
+ (WebCore::GraphicsLayerChromium::didScroll):
+ * platform/graphics/chromium/LayerChromium.cpp:
+ (WebCore::LayerChromium::setMaxScrollPosition):
+ (WebCore):
+ (WebCore::LayerChromium::pushPropertiesTo):
+ * platform/graphics/chromium/LayerChromium.h:
+ (LayerChromium):
+ (WebCore::LayerChromium::maxScrollPosition):
+ (WebCore::LayerChromium::scrollable):
+ (WebCore::LayerChromium::scrollBy):
+ * platform/graphics/chromium/cc/CCLayerImpl.cpp:
+ (WebCore::CCLayerImpl::findLayerInSubtree):
+ (WebCore):
+ (WebCore::CCLayerImpl::tryScroll):
+ * platform/graphics/chromium/cc/CCLayerImpl.h:
+ (CCLayerImpl):
+ * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+ (WebCore::findLayerById):
+ (WebCore):
+ (WebCore::findFirstScrollableLayer):
+ (WebCore::CCLayerTreeHost::applyScrollAndScale):
+ * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+ (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
+ (WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
+ (WebCore::CCLayerTreeHostImpl::contentSize):
+ (WebCore):
+ (WebCore::CCLayerTreeHostImpl::calculateVisibleLayers):
+ (WebCore::CCLayerTreeHostImpl::prepareToDraw):
+ (WebCore::findRootScrollLayer):
+ (WebCore::findScrollLayerForContentLayer):
+ (WebCore::CCLayerTreeHostImpl::setRootLayer):
+ (WebCore::adjustScrollsForPageScaleChange):
+ (WebCore::applyPageScaleDeltaToScrollLayers):
+ (WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
+ (WebCore::CCLayerTreeHostImpl::setPageScaleDelta):
+ (WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
+ (WebCore::CCLayerTreeHostImpl::scrollBegin):
+ (WebCore::CCLayerTreeHostImpl::scrollBy):
+ (WebCore::CCLayerTreeHostImpl::scrollEnd):
+ (WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
+ (WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
+ (WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
+ (WebCore::collectScrollDeltas):
+ (WebCore::CCLayerTreeHostImpl::processScrollDeltas):
+ (WebCore::CCLayerTreeHostImpl::animatePageScale):
+ * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
+ (WebCore::CCLayerTreeHostImpl::rootScrollLayer):
+ (CCLayerTreeHostImpl):
+ (LayerGeometry):
+
+2012-04-19 Yury Semikhatsky <yurys@chromium.org>
+
+ Web Inspector: make constructors and diff heap snapshot data grids use viewport
+ https://bugs.webkit.org/show_bug.cgi?id=84348
+
+ HeapSnapshotViewportDataGrid is introduced which allows to add to the tbody only
+ visible rows. HeapSnapshotConstructorsDataGrid and HeapSnapshotDiffDataGrid are
+ inherited from this class which makes them operate well on large amounts of nodes.
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/DataGrid.js:
+ (WebInspector.DataGridNode.prototype.nodeHeight):
+ (WebInspector.DataGridNode.prototype._attach):
+ * inspector/front-end/HeapSnapshotDataGrids.js:
+ (WebInspector.HeapSnapshotSortableDataGrid):
+ (WebInspector.HeapSnapshotSortableDataGrid.prototype.nodesForNameFilter):
+ (WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
+ (WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
+ (WebInspector.HeapSnapshotSortableDataGrid.prototype.appendChildAfterSorting):
+ (WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
+ (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
+ (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
+ (WebInspector.HeapSnapshotViewportDataGrid):
+ (WebInspector.HeapSnapshotViewportDataGrid.prototype.nodesForNameFilter):
+ (WebInspector.HeapSnapshotViewportDataGrid.prototype.appendChildAfterSorting):
+ (WebInspector.HeapSnapshotViewportDataGrid.prototype.updateVisibleNodes):
+ (WebInspector.HeapSnapshotViewportDataGrid.prototype.appendTopLevelNode):
+ (WebInspector.HeapSnapshotViewportDataGrid.prototype._addPaddingRows):
+ (WebInspector.HeapSnapshotViewportDataGrid.prototype._removePaddingRows):
+ (WebInspector.HeapSnapshotViewportDataGrid.prototype.onResize):
+ (WebInspector.HeapSnapshotViewportDataGrid.prototype._onScroll):
+ (WebInspector.HeapSnapshotPaddingNode):
+ (WebInspector.HeapSnapshotPaddingNode.prototype.setHeight):
+ (WebInspector.HeapSnapshotPaddingNode.prototype.removeFromTable):
+ (WebInspector.HeapSnapshotConstructorsDataGrid):
+ (WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
+ (WebInspector.HeapSnapshotDiffDataGrid):
+ (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
+ (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
+ (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
+ * inspector/front-end/HeapSnapshotGridNodes.js:
+ (WebInspector.HeapSnapshotGridNode):
+ (WebInspector.HeapSnapshotGridNode.prototype.collapse):
+ (WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate):
+ (WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
+ (WebInspector.HeapSnapshotGridNode.prototype.sort):
+ (WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
+ (WebInspector.HeapSnapshotObjectNode.prototype.comparator):
+ (WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
+ (WebInspector.HeapSnapshotInstanceNode.prototype.comparator):
+ (WebInspector.HeapSnapshotConstructorNode):
+ (WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode):
+ (WebInspector.HeapSnapshotConstructorNode.prototype.comparator):
+ (WebInspector.HeapSnapshotDiffNode):
+ (WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
+ (WebInspector.HeapSnapshotDiffNode.prototype.comparator):
+ (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode):
+ (WebInspector.HeapSnapshotDominatorObjectNode.prototype.comparator):
+ * inspector/front-end/ShowMoreDataGridNode.js:
+ (WebInspector.ShowMoreDataGridNode.prototype.createCells):
+ (WebInspector.ShowMoreDataGridNode.prototype.nodeHeight):
+
+2012-04-19 Kentaro Hara <haraken@chromium.org>
+
+ Unreviewed, rolling out r114421.
+ http://trac.webkit.org/changeset/114421
+ https://bugs.webkit.org/show_bug.cgi?id=84103
+
+ Chromium crash
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateNormalAttrGetter):
+ (GenerateFunctionCallString):
+ (NativeToJSValue):
+ * bindings/scripts/test/V8/V8TestEventConstructor.cpp:
+ (WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
+ (WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
+ * bindings/scripts/test/V8/V8TestInterface.cpp:
+ (WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
+ (WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
+ (WebCore::TestObjV8Internal::stringAttrAttrGetter):
+ (WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
+ (WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
+ (WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
+ (WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
+ (WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
+ (WebCore::TestObjV8Internal::hashAttrGetter):
+ (WebCore::TestObjV8Internal::conditionalMethod1Callback):
+ * bindings/v8/V8Binding.cpp:
+ (WebCore::getElementStringAttr):
+ * bindings/v8/V8Binding.h:
+ (WebCore::v8ExternalString):
+ (WebCore::v8String):
+ (WebCore::v8StringOrNull):
+ (WebCore::v8StringOrUndefined):
+ (WebCore::v8StringOrFalse):
+
+2012-04-19 Sheriff Bot <webkit.review.bot@gmail.com>
+
+ Unreviewed, rolling out r114626.
+ http://trac.webkit.org/changeset/114626
+ https://bugs.webkit.org/show_bug.cgi?id=84349
+
+ caused new assertions in debug builds (Requested by smfr_ on
+ #webkit).
+
+ * inspector/InspectorResourceAgent.cpp:
+ (WebCore::InspectorResourceAgent::didReceiveData):
+ * inspector/NetworkResourcesData.cpp:
+ (WebCore::NetworkResourcesData::responseReceived):
+ * inspector/NetworkResourcesData.h:
+ (ResourceData):
+ (NetworkResourcesData):
+ * inspector/front-end/RequestView.js:
+ (WebInspector.RequestView.hasTextContent):
+
+2012-04-19 Mark Pilgrim <pilgrim@chromium.org>
+
+ [Chromium] Call mimeRegistry directly
+ https://bugs.webkit.org/show_bug.cgi?id=84334
+
+ Reviewed by Kentaro Hara.
+
+ Part of a refactoring series. See tracking bug 82948.
+
+ * platform/chromium/MIMETypeRegistryChromium.cpp:
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
+ (WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
+ (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
+ (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
+ (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
+ (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
+ * platform/chromium/PlatformSupport.h:
+ (PlatformSupport):
+
+2012-04-19 Victor Carbune <vcarbune@adobe.com>
+
+ Display a TextTrackCue when snap-to-lines flag is not set
+ https://bugs.webkit.org/show_bug.cgi?id=79750
+
+ Reviewed by Eric Carlson.
+
+ Support for positioning of a cue on top of the video element when snap-to-lines is not set.
+
+ Test: media/track/track-cue-rendering-snap-to-lines-not-set.html
+
+ * css/mediaControls.css:
+ (video::-webkit-media-text-track-container): Marked the container as
+ flexible box in order to use all the available space on top of the controls.
+ (video::-webkit-media-text-track-background): Added background default settings.
+ (video::-webkit-media-text-track-display): Added default position.
+ * html/shadow/MediaControlElements.cpp:
+ (WebCore::MediaControlTextTrackContainerElement::updateDisplay): Updated comments.
+ * html/track/TextTrackCue.cpp:
+ (WebCore):
+ (WebCore::TextTrackCue::TextTrackCue): Updated constructor to calculate
+ the computed line position.
+ (WebCore::TextTrackCue::setLine): Updated call to calculate the computed line
+ position.
+ (WebCore::TextTrackCue::setPosition):
+ (WebCore::TextTrackCue::calculateComputedLinePosition): Partial calculation of the
+ computated line position.
+ (WebCore::TextTrackCue::calculateDisplayParameters): Updated display parameter computations
+ required by the spec.
+ (WebCore::TextTrackCue::getDisplayTree): Updated positioning attributes when snap-to-lines
+ is not set. Added extra anonymous box for background, because setting position:absolute
+ on the display tree determines the background to cover the whole block, not just inline.
+ (WebCore::TextTrackCue::getPositionCoordinates): Determine coordinates as required by the spec.
+ * html/track/TextTrackCue.h:
+ (TextTrackCue):
+
+2012-04-19 Pavel Feldman <pfeldman@chromium.org>
+
+ Web Inspector: introduce styles panel as an experiment
+ https://bugs.webkit.org/show_bug.cgi?id=84331
+
+ Reviewed by Vsevolod Vlasov.
+
+ This change introduces new "Styles" panel that looks like the "Scripts" one,
+ but operates stylesheets. This is happening under the experimental flag.
+
+ * English.lproj/localizedStrings.js:
+ * WebCore.gypi:
+ * WebCore.vcproj/WebCore.vcproj:
+ * inspector/compile-front-end.py:
+ * inspector/front-end/Panel.js:
+ (WebInspector.Panel.prototype.showAnchorLocation):
+ * inspector/front-end/ResourceView.js:
+ (WebInspector.EditableResourceSourceFrame.prototype.didEditContent):
+ * inspector/front-end/ScriptsNavigator.js:
+ (WebInspector.ScriptsNavigatorController.prototype._navigatorOverlayWasShown):
+ * inspector/front-end/ScriptsPanel.js:
+ * inspector/front-end/Settings.js:
+ (WebInspector.ExperimentsSettings):
+ * inspector/front-end/SourceFrame.js:
+ (WebInspector.SourceFrame.prototype._clearLineHighlight):
+ * inspector/front-end/StylesPanel.js: Added.
+ (WebInspector.StylesPanel):
+ (WebInspector.StylesPanel.prototype.wasShown):
+ (WebInspector.StylesPanel.prototype._initialize):
+ (WebInspector.StylesPanel.prototype._populateResourceTree.populateFrame):
+ (WebInspector.StylesPanel.prototype._populateResourceTree):
+ (WebInspector.StylesPanel.prototype._resourceAdded):
+ (WebInspector.StylesPanel.prototype._reset):
+ (WebInspector.StylesPanel.prototype._cachedResourcesLoaded):
+ (WebInspector.StylesPanel.prototype.get toolbarItemLabel):
+ (WebInspector.StylesPanel.prototype.viewForFile.get if):
+ (WebInspector.StylesPanel.prototype.viewForFile):
+ (WebInspector.StylesPanel.prototype._textEdited):
+ (WebInspector.StylesPanel.prototype._scriptSelected):
+ (WebInspector.StylesPanel.prototype._showFile):
+ (WebInspector.StylesPanel.prototype.canShowAnchorLocation):
+ * inspector/front-end/StylesSidebarPane.js:
+ (WebInspector.StylePropertiesSection):
+ (WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):
+ * inspector/front-end/TabbedEditorContainer.js:
+ (WebInspector.TabbedEditorContainer):
+ * inspector/front-end/WebKit.qrc:
+ * inspector/front-end/inspector.html:
+ * inspector/front-end/inspector.js:
+ (WebInspector._createPanels):
+ (WebInspector._showAnchorLocationInPanel):
+ * inspector/front-end/scriptsPanel.css:
+ * inspector/front-end/splitView.css:
+ (.sidebar-overlay):
+
+2012-04-19 Vsevolod Vlasov <vsevik@chromium.org>
+
+ Follow up to r114632: build fix.
+
+ * inspector/InspectorDebuggerAgent.cpp:
+ (WebCore):
+ (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
+
+2012-04-19 Mark Pilgrim <pilgrim@chromium.org>
+
+ [Chromium] Call sampleGamepads directly
+ https://bugs.webkit.org/show_bug.cgi?id=84339
+
+ Reviewed by Kentaro Hara.
+
+ Part of a refactoring series. See tracking bug 82948.
+
+ * platform/chromium/GamepadsChromium.cpp:
+ (WebCore::sampleGamepads):
+ * platform/chromium/PlatformSupport.h:
+ (WebCore):
+ (PlatformSupport):
+
+2012-04-19 Vsevolod Vlasov <vsevik@chromium.org>
+
+ Web Inspector: x-frame security errors logged when typing in the console are annoying.
+ https://bugs.webkit.org/show_bug.cgi?id=81970
+
+ Reviewed by Pavel Feldman.
+
+ Parameter DoNotPauseOnExceptions in Runtime.evaluate() renamed to DoNotPauseOnExceptionsAndMuteConsole.
+ Added this parameter to Runtime.callFunctionOn() and passed true in all call sites.
+ Added this parameter to Debugger.evaluateOnCallFrame().
+ Added a flag to console that mutes all messages unless they have ConsoleAPI message source.
+ This flag is now temporarily set from InspectorRuntimeAgent and InspectorDebuggerAgent for certain injected source calls.
+
+ * inspector/Inspector.json:
+ * inspector/InspectorDebuggerAgent.cpp:
+ (WebCore::asBool):
+ (WebCore):
+ (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
+ * inspector/InspectorDebuggerAgent.h:
+ (InspectorDebuggerAgent):
+ * inspector/InspectorRuntimeAgent.cpp:
+ (WebCore):
+ (WebCore::setPauseOnExceptionsState):
+ (WebCore::InspectorRuntimeAgent::evaluate):
+ (WebCore::InspectorRuntimeAgent::callFunctionOn):
+ (WebCore::InspectorRuntimeAgent::getProperties):
+ * inspector/InspectorRuntimeAgent.h:
+ (InspectorRuntimeAgent):
+ * inspector/PageDebuggerAgent.cpp:
+ (WebCore::PageDebuggerAgent::muteConsole):
+ (WebCore):
+ (WebCore::PageDebuggerAgent::unmuteConsole):
+ * inspector/PageDebuggerAgent.h:
+ (PageDebuggerAgent):
+ * inspector/PageRuntimeAgent.cpp:
+ (WebCore::PageRuntimeAgent::muteConsole):
+ (WebCore):
+ (WebCore::PageRuntimeAgent::unmuteConsole):
+ * inspector/PageRuntimeAgent.h:
+ (PageRuntimeAgent):
+ * inspector/WorkerDebuggerAgent.cpp:
+ (WebCore::WorkerDebuggerAgent::muteConsole):
+ (WebCore):
+ (WebCore::WorkerDebuggerAgent::unmuteConsole):
+ * inspector/WorkerDebuggerAgent.h:
+ (WorkerDebuggerAgent):
+ * inspector/WorkerRuntimeAgent.cpp:
+ (WebCore::WorkerRuntimeAgent::muteConsole):
+ (WebCore):
+ (WebCore::WorkerRuntimeAgent::unmuteConsole):
+ * inspector/WorkerRuntimeAgent.h:
+ (WorkerRuntimeAgent):
+ * inspector/front-end/ConsoleView.js:
+ (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
+ * inspector/front-end/DebuggerPresentationModel.js:
+ (WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
+ (WebInspector.PresentationCallFrame.prototype.evaluate):
+ * inspector/front-end/RemoteObject.js:
+ (WebInspector.RemoteObject.prototype.setPropertyValue):
+ (WebInspector.RemoteObject.prototype.callFunction):
+ (WebInspector.RemoteObject.prototype.callFunctionJSON):
+ * inspector/front-end/WorkerManager.js:
+ * page/Console.cpp:
+ (WebCore::Console::addMessage):
+ (WebCore::Console::warn):
+ (WebCore):
+ (WebCore::Console::mute):
+ (WebCore::Console::unmute):
+ * page/Console.h:
+ (Console):
+
+2012-04-19 Sheriff Bot <webkit.review.bot@gmail.com>
+
+ Unreviewed, rolling out r114628.
+ http://trac.webkit.org/changeset/114628
+ https://bugs.webkit.org/show_bug.cgi?id=84341
+
+ Breaks EFL and GTK builds (Requested by pfeldman on #webkit).
+
+ * inspector/Inspector.json:
+ * inspector/InspectorDebuggerAgent.cpp:
+ (WebCore):
+ (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
+ * inspector/InspectorDebuggerAgent.h:
+ (InspectorDebuggerAgent):
+ * inspector/InspectorRuntimeAgent.cpp:
+ (WebCore::InspectorRuntimeAgent::evaluate):
+ (WebCore::InspectorRuntimeAgent::callFunctionOn):
+ (WebCore::InspectorRuntimeAgent::getProperties):
+ * inspector/InspectorRuntimeAgent.h:
+ (InspectorRuntimeAgent):
+ * inspector/PageDebuggerAgent.cpp:
+ * inspector/PageDebuggerAgent.h:
+ (PageDebuggerAgent):
+ * inspector/PageRuntimeAgent.cpp:
+ * inspector/PageRuntimeAgent.h:
+ (PageRuntimeAgent):
+ * inspector/WorkerDebuggerAgent.cpp:
+ * inspector/WorkerDebuggerAgent.h:
+ (WorkerDebuggerAgent):
+ * inspector/WorkerRuntimeAgent.cpp:
+ * inspector/WorkerRuntimeAgent.h:
+ (WorkerRuntimeAgent):
+ * inspector/front-end/ConsoleView.js:
+ (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
+ * inspector/front-end/DebuggerPresentationModel.js:
+ (WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
+ (WebInspector.PresentationCallFrame.prototype.evaluate):
+ * inspector/front-end/RemoteObject.js:
+ (WebInspector.RemoteObject.prototype.setPropertyValue):
+ (WebInspector.RemoteObject.prototype.callFunction):
+ (WebInspector.RemoteObject.prototype.callFunctionJSON):
+ * inspector/front-end/WorkerManager.js:
+ * page/Console.cpp:
+ (WebCore):
+ (WebCore::Console::addMessage):
+ (WebCore::Console::warn):
+ * page/Console.h:
+ (Console):
+
+2012-04-19 Vsevolod Vlasov <vsevik@chromium.org>
+
+ Web Inspector: x-frame security errors logged when typing in the console are annoying.
+ https://bugs.webkit.org/show_bug.cgi?id=81970
+
+ Reviewed by Pavel Feldman.
+
+ Parameter DoNotPauseOnExceptions in Runtime.evaluate() renamed to DoNotPauseOnExceptionsAndMuteConsole.
+ Added this parameter to Runtime.callFunctionOn() and passed true in all call sites.
+ Added this parameter to Debugger.evaluateOnCallFrame().
+ Added a flag to console that mutes all messages unless they have ConsoleAPI message source.
+ This flag is now temporarily set from InspectorRuntimeAgent and InspectorDebuggerAgent for certain injected source calls.
+
+ * inspector/Inspector.json:
+ * inspector/InspectorDebuggerAgent.cpp:
+ (WebCore::asBool):
+ (WebCore):
+ (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
+ * inspector/InspectorDebuggerAgent.h:
+ (InspectorDebuggerAgent):
+ * inspector/InspectorRuntimeAgent.cpp:
+ (WebCore):
+ (WebCore::setPauseOnExceptionsState):
+ (WebCore::InspectorRuntimeAgent::evaluate):
+ (WebCore::InspectorRuntimeAgent::callFunctionOn):
+ (WebCore::InspectorRuntimeAgent::getProperties):
+ * inspector/InspectorRuntimeAgent.h:
+ (InspectorRuntimeAgent):
+ * inspector/PageDebuggerAgent.cpp:
+ (WebCore::PageDebuggerAgent::muteConsole):
+ (WebCore):
+ (WebCore::PageDebuggerAgent::unmuteConsole):
+ * inspector/PageDebuggerAgent.h:
+ (PageDebuggerAgent):
+ * inspector/PageRuntimeAgent.cpp:
+ (WebCore::PageRuntimeAgent::muteConsole):
+ (WebCore):
+ (WebCore::PageRuntimeAgent::unmuteConsole):
+ * inspector/PageRuntimeAgent.h:
+ (PageRuntimeAgent):
+ * inspector/WorkerDebuggerAgent.cpp:
+ (WebCore::WorkerDebuggerAgent::muteConsole):
+ (WebCore):
+ (WebCore::WorkerDebuggerAgent::unmuteConsole):
+ * inspector/WorkerDebuggerAgent.h:
+ (WorkerDebuggerAgent):
+ * inspector/WorkerRuntimeAgent.cpp:
+ (WebCore::WorkerRuntimeAgent::muteConsole):
+ (WebCore):
+ (WebCore::WorkerRuntimeAgent::unmuteConsole):
+ * inspector/WorkerRuntimeAgent.h:
+ (WorkerRuntimeAgent):
+ * inspector/front-end/ConsoleView.js:
+ (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
+ * inspector/front-end/DebuggerPresentationModel.js:
+ (WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
+ (WebInspector.PresentationCallFrame.prototype.evaluate):
+ * inspector/front-end/RemoteObject.js:
+ (WebInspector.RemoteObject.prototype.setPropertyValue):
+ (WebInspector.RemoteObject.prototype.callFunction):
+ (WebInspector.RemoteObject.prototype.callFunctionJSON):
+ * inspector/front-end/WorkerManager.js:
+ * page/Console.cpp:
+ (WebCore::Console::addMessage):
+ (WebCore::Console::warn):
+ (WebCore):
+ (WebCore::Console::mute):
+ (WebCore::Console::unmute):
+ * page/Console.h:
+ (Console):
+
+2012-04-19 No'am Rosenthal <noam.rosenthal@nokia.com>
+
+ [Qt] Fix Qt-Mac build after libxml patch
+ https://bugs.webkit.org/show_bug.cgi?id=84313
+
+ Use direct include/library paths instead of PKGCONFIG when on Mac.
+
+ Reviewed by Simon Hausmann.
+
+ No new tests, build fix.
+
+ * WebCore.pri:
+
+2012-04-18 Vsevolod Vlasov <vsevik@chromium.org>
+
+ Web Inspector: No response body available for cached resource requests with error status codes.
+ https://bugs.webkit.org/show_bug.cgi?id=84265
+
+ Reviewed by Pavel Feldman.
+
+ InspectorResourceAgent now saves failed subresource request response body in its cache.
+ Saved data is shown on front-end.
+
+ Test: http/tests/inspector/network/network-image-404.html
+
+ * inspector/InspectorResourceAgent.cpp:
+ (WebCore::InspectorResourceAgent::didReceiveData):
+ * inspector/NetworkResourcesData.cpp:
+ (WebCore::NetworkResourcesData::responseReceived):
+ (WebCore::NetworkResourcesData::httpStatusCode):
+ (WebCore):
+ * inspector/NetworkResourcesData.h:
+ (WebCore::NetworkResourcesData::ResourceData::httpStatusCode):
+ (WebCore::NetworkResourcesData::ResourceData::setHTTPStatusCode):
+ (ResourceData):
+ (NetworkResourcesData):
+ * inspector/front-end/RequestView.js:
+ (WebInspector.RequestView.hasTextContent):
+
+2012-04-19 Pavel Feldman <pfeldman@chromium.org>
+
+ Web Inspector: reuse ParsedUrl in the UISourceCode
+ https://bugs.webkit.org/show_bug.cgi?id=84326
+
+ Reviewed by Yury Semikhatsky.
+
+ Migrated UISourceCode to ParsedURL, moved the displayName logic into its only client:
+ TabbedEditorContainer.
+
+ * inspector/front-end/CompilerScriptMapping.js:
+ (WebInspector.SourceMapParser.prototype._canonicalizeURL):
+ * inspector/front-end/FilteredItemSelectionDialog.js:
+ (WebInspector.OpenResourceDialog.filterOutEmptyURLs):
+ (WebInspector.OpenResourceDialog.compareFunction):
+ (WebInspector.OpenResourceDialog):
+ (WebInspector.OpenResourceDialog.prototype.itemTitleAt):
+ (WebInspector.OpenResourceDialog.prototype.itemKeyAt):
+ * inspector/front-end/ResourceUtils.js:
+ (WebInspector.ParsedURL):
+ * inspector/front-end/ScriptsNavigator.js:
+ (WebInspector.ScriptsNavigator.prototype._getOrCreateFolderTreeElement):
+ (WebInspector.NavigatorFolderTreeElement):
+ * inspector/front-end/TabbedEditorContainer.js:
+ (WebInspector.TabbedEditorContainer.prototype._titleForFile):
+ * inspector/front-end/UISourceCode.js:
+ (WebInspector.UISourceCode):
+ (WebInspector.UISourceCode.prototype.get parsedURL):
+
+2012-04-19 Xingnan Wang <xingnan.wang@intel.com>
+
+ Optimize for DARWIN in DirectConvolver::process()
+ https://bugs.webkit.org/show_bug.cgi?id=80256
+
+ Reviewed by Chris Rogers.
+
+ * platform/audio/DirectConvolver.cpp:
+ (WebCore::DirectConvolver::process):
+
+2012-04-18 Noel Gordon <noel.gordon@gmail.com>
+
+ [CG] ImageBuffer::toDataURL: Remove alpha stuffing loop when encoding to JPEG
+ https://bugs.webkit.org/show_bug.cgi?id=84319
+
+ Reviewed by Eric Seidel.
+
+ No change in behavior. Covered by existing canvas 2d and 3d tests:
+
+ canvas/philip/tests/toDataURL.jpeg.alpha.html
+ fast/canvas/webgl/premultiplyalpha-test.html
+
+ * platform/graphics/cg/ImageBufferCG.cpp:
+ (WebCore::ImageBuffer::toDataURL): Remove the alpha stuffing loop and instead,
+ make JPEG encoder ignore the alpha channel (kCGImageAlphaNoneSkipLast).
+
+2012-04-18 Emil A Eklund <eae@chromium.org>
+
+ Remove unnecessary rounding/conversions in RenderBoxModelObject
+ https://bugs.webkit.org/show_bug.cgi?id=84288
+
+ Reviewed by Eric Seidel.
+
+ No new tests, no change in functionality.
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::paintBoxShadow):
+ Remove unnecessary pixelSnapping logic and casts in paintBoxShadow as
+ shadow rects are now int based.
+
+2012-04-18 Jason Liu <jason.liu@torchmobile.com.cn>
+
+ [BlackBerry] Parsed Cookie's m_hasDefaultDomain is not needed.
+ https://bugs.webkit.org/show_bug.cgi?id=82830
+
+ Reviewed by George Staikos.
+
+ RFC 2965
+ 3.2.2
+ Domain = value
+ If an explicitly specified value does not start with a dot, the user agent supplies
+ a leading dot.
+ 3.3.1
+ Domain Defaults to the effective request-host. (Note that because there is no dot
+ at the beginning of effective request-host, the default Domain can only domain-match
+ itself.)
+
+ The first char can show the difference even though it is from the cookie database.
+ But m_hasDefaultDomain is set to false if the cookie is from database although the
+ domain is host as a default value. So m_hasDefaultDomain sometimes is wrong.
+
+ In sum, we shouldn't use m_hasDefaultDomain.
+
+ Test: http/tests/security/cookies/cookies-wrong-domain-rejected.php
+
+ * platform/blackberry/CookieManager.cpp:
+ (WebCore::CookieManager::shouldRejectForSecurityReason):
+ * platform/blackberry/CookieParser.cpp:
+ (WebCore::CookieParser::parseOneCookie):
+ * platform/blackberry/ParsedCookie.cpp:
+ (WebCore::ParsedCookie::ParsedCookie):
+ * platform/blackberry/ParsedCookie.h:
+ (ParsedCookie):
+
+2012-04-18 Adrienne Walker <enne@google.com>
+
+ [chromium] Consolidate adjustTextRenderMode copypasta into Skia context
+ https://bugs.webkit.org/show_bug.cgi?id=83840
+
+ Reviewed by James Robinson.
+
+ The same logic to decide when to make text use LCD rendering is copy
+ and pasted in all the different font classes. It seems like this
+ should live in a single place.
+
+ * platform/graphics/harfbuzz/FontHarfBuzz.cpp:
+ (WebCore::Font::drawGlyphs):
+ (WebCore::Font::drawComplexText):
+ * platform/graphics/skia/FontSkia.cpp:
+ (WebCore::Font::drawGlyphs):
+ * platform/graphics/skia/PlatformContextSkia.cpp:
+ (WebCore::PlatformContextSkia::adjustTextRenderMode):
+ (WebCore):
+ (WebCore::PlatformContextSkia::couldUseLCDRenderedText):
+ * platform/graphics/skia/PlatformContextSkia.h:
+ (PlatformContextSkia):
+ * platform/graphics/skia/SkiaFontWin.cpp:
+ (WebCore::setupPaintForFont):
+
+2012-04-18 Hironori Bono <hbono@chromium.org>
+
+ Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
+ https://bugs.webkit.org/show_bug.cgi?id=83748
+
+ Reviewed by Ryosuke Niwa.
+
+ The current SpellChecker::didCheck() does not delete existing markers. It causes
+ a problem that it leaves misspelled markers when a spellchecker client finishes
+ checking text successfully. This change splits this function to didCheckSucceeded()
+ and didCheckCanceled() so the SpellChecker class can delete existing markers
+ when its client finishes checking text successfully. (We do not have to erase
+ existing markers when the client needs to cancel a text-check request.)
+
+ Test: platform/chromium/editing/spelling/delete-misspelled-word.html
+
+ * WebCore.exp.in: Replaced SpellChecker::didCheck with SpellChecker::didCheckSucceeded.
+ * editing/SpellChecker.cpp:
+ (WebCore::SpellChecker::didCheckSucceeded): Added.
+ (WebCore):
+ (WebCore::SpellChecker::didCheckCanceled): Added.
+ * editing/SpellChecker.h:
+ (SpellChecker): Added didCheckSucceeded and didCheckCanceled. Also changed didCheck to a private function.
+
+2012-04-16 James Robinson <jamesr@chromium.org>
+
+ [chromium] Convert WebPluginContainerImpl over to use WebExternalTextureLayer
+ https://bugs.webkit.org/show_bug.cgi?id=84120
+
+ Reviewed by Adrienne Walker.
+
+ This renames PluginLayerChromium -> TextureLayerChromium since it is now used only as the implementation of
+ WebExternalTextureLayer and cleans it up slightly.
+
+ * WebCore.gypi:
+ * platform/graphics/chromium/TextureLayerChromium.cpp: Renamed from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp.
+ (WebCore):
+ (WebCore::TextureLayerChromium::create):
+ (WebCore::TextureLayerChromium::TextureLayerChromium):
+ (WebCore::TextureLayerChromium::createCCLayerImpl):
+ (WebCore::TextureLayerChromium::drawsContent):
+ (WebCore::TextureLayerChromium::setTextureId):
+ (WebCore::TextureLayerChromium::setFlipped):
+ (WebCore::TextureLayerChromium::setUVRect):
+ (WebCore::TextureLayerChromium::setIOSurfaceProperties):
+ (WebCore::TextureLayerChromium::pushPropertiesTo):
+ * platform/graphics/chromium/TextureLayerChromium.h: Renamed from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h.
+ (WebCore):
+ (TextureLayerChromium):
+ (WebCore::TextureLayerChromium::flipped):
+ (WebCore::TextureLayerChromium::uvRect):
+
+2012-04-18 Raymond Toy <rtoy@google.com>
+
+ Expose attack, release as DynamicsCompressorNode's attributes.
+ https://bugs.webkit.org/show_bug.cgi?id=81221
+
+ Reviewed by Chris Rogers.
+
+ * Modules/webaudio/DynamicsCompressorNode.cpp:
+ (WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
+ (WebCore::DynamicsCompressorNode::process):
+ * Modules/webaudio/DynamicsCompressorNode.h:
+ (WebCore::DynamicsCompressorNode::attack):
+ (WebCore::DynamicsCompressorNode::releaseTime):
+ (DynamicsCompressorNode):
+ * Modules/webaudio/DynamicsCompressorNode.idl: Add attack and
+ release attributes.
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ (SkipAttribute): Skip release()
+ (GenerateHeader): Call SkipAttribute for getters/setters.
+ * platform/audio/DynamicsCompressor.h:
+ (DynamicsCompressor):
+
+2012-04-18 Dana Jansens <danakj@chromium.org>
+
+ [chromium] Simplify occlusion tracker API by passing layer iterator data
+ https://bugs.webkit.org/show_bug.cgi?id=84088
+
+ Reviewed by Adrienne Walker.
+
+ Previously three methods lived in the API and you needed to call the
+ appropriate method (with different amounts of data) depending on what
+ the current layer iterator was representing.
+
+ This makes usage of the occlusion tracker simpler to read and harder
+ to mess up, by just passing in the layer iterator at each step of the
+ iteration process.
+
+ Covered by existing tests.
+
+ * platform/graphics/chromium/cc/CCLayerIterator.h:
+ (WebCore):
+ (CCLayerIteratorPosition):
+ (CCLayerIterator):
+ (WebCore::CCLayerIterator::operator const CCLayerIteratorPosition<LayerType>):
+ * platform/graphics/chromium/cc/CCLayerTilingData.cpp:
+ (WebCore::CCLayerTilingData::opaqueRegionInLayerRect):
+ * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+ (WebCore::CCLayerTreeHost::paintLayerContents):
+ * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+ (WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
+ * platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
+ (WebCore::::enterLayer):
+ (WebCore):
+ (WebCore::::leaveLayer):
+ * platform/graphics/chromium/cc/CCOcclusionTracker.h:
+ (CCOcclusionTrackerBase):
+
2012-04-18 James Robinson <jamesr@chromium.org>
[chromium] Add canBeginFrame state to CCSchedulerStateMachine to suppress initialization before our surface is available
« no previous file with comments | « Source/Platform/chromium/public/WebLayerTreeView.h ('k') | Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698