Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 9447100: Return null from stringValue and call slowToString() instead of toString(). (Closed)

Created:
8 years, 10 months ago by ahe
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org, ngeoffray, kasperl, floitsch, karlklose
Visibility:
Public.

Description

Return null from stringValue and call slowToString() instead of toString(). Committed: https://code.google.com/p/dart/source/detail?r=4699

Patch Set 1 #

Patch Set 2 : changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -96 lines) Patch
M dart/frog/leg/elements/elements.dart View 3 chunks +8 lines, -2 lines 0 comments Download
M dart/frog/leg/emitter.dart View 3 chunks +7 lines, -5 lines 0 comments Download
M dart/frog/leg/frog_leg.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M dart/frog/leg/namer.dart View 3 chunks +10 lines, -8 lines 0 comments Download
M dart/frog/leg/native_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/frog/leg/native_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/frog/leg/resolver.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M dart/frog/leg/scanner/byte_strings.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download
M dart/frog/leg/scanner/keyword.dart View 2 chunks +2 lines, -1 line 0 comments Download
M dart/frog/leg/scanner/listener.dart View 5 chunks +28 lines, -18 lines 0 comments Download
M dart/frog/leg/scanner/scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/frog/leg/scanner/scanner_task.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/frog/leg/scanner/string_scanner.dart View 1 chunk +7 lines, -5 lines 0 comments Download
M dart/frog/leg/scanner/token.dart View 4 chunks +8 lines, -2 lines 0 comments Download
M dart/frog/leg/ssa/builder.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M dart/frog/leg/ssa/closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/frog/leg/ssa/codegen.dart View 6 chunks +7 lines, -6 lines 0 comments Download
M dart/frog/leg/ssa/nodes.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M dart/frog/leg/ssa/tracer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/frog/leg/tree/nodes.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M dart/frog/leg/typechecker.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/frog/leg/universe.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/frog/leg/warnings.dart View 2 chunks +10 lines, -1 line 0 comments Download
M dart/frog/tests/leg/src/ResolverTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/frog/tests/leg/src/ScannerTest.dart View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
8 years, 10 months ago (2012-02-27 11:30:47 UTC) #1
ngeoffray
LGTM
8 years, 9 months ago (2012-02-28 10:36:10 UTC) #2
Lasse Reichstein Nielsen
8 years, 9 months ago (2012-02-28 14:07:30 UTC) #3
LGTM too.

Powered by Google App Engine
This is Rietveld 408576698