Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: dart/frog/leg/scanner/scanner_task.dart

Issue 9447100: Return null from stringValue and call slowToString() instead of toString(). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: changes Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/scanner/scanner.dart ('k') | dart/frog/leg/scanner/string_scanner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/scanner/scanner_task.dart
diff --git a/dart/frog/leg/scanner/scanner_task.dart b/dart/frog/leg/scanner/scanner_task.dart
index 85523757246f56165558bd330c686cde852b4749..c951416f3c13780ba3fb0fd3b568285788c67559 100644
--- a/dart/frog/leg/scanner/scanner_task.dart
+++ b/dart/frog/leg/scanner/scanner_task.dart
@@ -25,7 +25,7 @@ class ScannerTask extends CompilerTask {
Uri base = cwd.resolve(library.script.name.toString());
for (ScriptTag tag in library.tags.reverse()) {
SourceString argument = tag.argument.value.copyWithoutQuotes(1, 1);
- Uri resolved = base.resolve(argument.toString());
+ Uri resolved = base.resolve(argument.slowToString());
if (tag.isImport()) {
// It is not safe to import other libraries at this point as
// another library could then observe the current library
@@ -55,7 +55,7 @@ class ScannerTask extends CompilerTask {
// Now that we have processed all the source tags, it is safe to
// start loading other libraries.
SourceString argument = tag.argument.value.copyWithoutQuotes(1, 1);
- Uri resolved = base.resolve(argument.toString());
+ Uri resolved = base.resolve(argument.slowToString());
if (resolved.toString() == "dart:core") {
implicitlyImportCoreLibrary = false;
}
« no previous file with comments | « dart/frog/leg/scanner/scanner.dart ('k') | dart/frog/leg/scanner/string_scanner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698