Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: dart/frog/leg/ssa/codegen.dart

Issue 9447100: Return null from stringValue and call slowToString() instead of toString(). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: changes Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/ssa/closure.dart ('k') | dart/frog/leg/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/ssa/codegen.dart
diff --git a/dart/frog/leg/ssa/codegen.dart b/dart/frog/leg/ssa/codegen.dart
index 851f500e80022ab9c7ef949960e8f47f4f520206..f1eb34706b5a4eab59465133d4b1dbba2de88166 100644
--- a/dart/frog/leg/ssa/codegen.dart
+++ b/dart/frog/leg/ssa/codegen.dart
@@ -13,7 +13,8 @@ class SsaCodeGeneratorTask extends CompilerTask {
new LinkedHashMap<Element, String>();
function.computeParameters(compiler).forEachParameter((Element element) {
- parameterNames[element] = JsNames.getValid('${element.name}');
+ parameterNames[element] =
+ JsNames.getValid('${element.name.slowToString()}');
});
String code = generateMethod(parameterNames, work, graph);
@@ -175,7 +176,7 @@ class SsaCodeGenerator implements HVisitor {
String prefix;
if (element !== null) {
- prefix = element.name.stringValue;
+ prefix = element.name.slowToString();
} else {
prefix = 'v';
}
@@ -407,7 +408,7 @@ class SsaCodeGenerator implements HVisitor {
// The default implementation uses the unmodified Dart label name.
// Specializations might change this.
void addLabel(SourceString label) {
- buffer.add(label.toString());
+ buffer.add(label.slowToString());
}
visitBreak(HBreak node) {
@@ -565,7 +566,7 @@ class SsaCodeGenerator implements HVisitor {
}
visitFieldGet(HFieldGet node) {
- String name = JsNames.getValid('${node.element.name}');
+ String name = JsNames.getValid(node.element.name.slowToString());
if (node.receiver !== null) {
beginExpression(JSPrecedence.MEMBER_PRECEDENCE);
use(node.receiver, JSPrecedence.MEMBER_PRECEDENCE);
@@ -587,7 +588,7 @@ class SsaCodeGenerator implements HVisitor {
// variables used in a try/catch.
buffer.add('var ');
}
- String name = JsNames.getValid('${node.element.name}');
+ String name = JsNames.getValid(node.element.name.slowToString());
buffer.add(name);
buffer.add(' = ');
use(node.value, JSPrecedence.ASSIGNMENT_PRECEDENCE);
@@ -1065,7 +1066,7 @@ class SsaOptimizedCodeGenerator extends SsaCodeGenerator {
void beginLoop(HBasicBlock block) {
addIndentation();
for (SourceString label in block.loopInformation.labels) {
- buffer.add("${label.stringValue}:");
+ buffer.add("${label.slowToString()}:");
}
buffer.add('while (true) {\n');
indent++;
« no previous file with comments | « dart/frog/leg/ssa/closure.dart ('k') | dart/frog/leg/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698