Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Side by Side Diff: dart/frog/leg/universe.dart

Issue 9447100: Return null from stringValue and call slowToString() instead of toString(). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: changes Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « dart/frog/leg/typechecker.dart ('k') | dart/frog/leg/warnings.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 class Universe { 5 class Universe {
6 Map<Element, String> generatedCode; 6 Map<Element, String> generatedCode;
7 Map<Element, String> generatedBailoutCode; 7 Map<Element, String> generatedBailoutCode;
8 final Set<ClassElement> instantiatedClasses; 8 final Set<ClassElement> instantiatedClasses;
9 final Set<FunctionElement> staticFunctionsNeedingGetter; 9 final Set<FunctionElement> staticFunctionsNeedingGetter;
10 final Map<SourceString, Set<Selector>> invokedNames; 10 final Map<SourceString, Set<Selector>> invokedNames;
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 namedArguments = names, 135 namedArguments = names,
136 orderedNamedArguments = const <SourceString>[]; 136 orderedNamedArguments = const <SourceString>[];
137 137
138 List<SourceString> getOrderedNamedArguments() { 138 List<SourceString> getOrderedNamedArguments() {
139 if (namedArguments.isEmpty()) return namedArguments; 139 if (namedArguments.isEmpty()) return namedArguments;
140 // We use the empty const List as a sentinel. 140 // We use the empty const List as a sentinel.
141 if (!orderedNamedArguments.isEmpty()) return orderedNamedArguments; 141 if (!orderedNamedArguments.isEmpty()) return orderedNamedArguments;
142 142
143 List<SourceString> list = new List<SourceString>.from(namedArguments); 143 List<SourceString> list = new List<SourceString>.from(namedArguments);
144 list.sort((SourceString first, SourceString second) { 144 list.sort((SourceString first, SourceString second) {
145 return first.stringValue.compareTo(second.stringValue); 145 return first.slowToString().compareTo(second.slowToString());
146 }); 146 });
147 orderedNamedArguments = list; 147 orderedNamedArguments = list;
148 return orderedNamedArguments; 148 return orderedNamedArguments;
149 } 149 }
150 } 150 }
OLDNEW
« no previous file with comments | « dart/frog/leg/typechecker.dart ('k') | dart/frog/leg/warnings.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698