Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2344)

Unified Diff: dart/frog/leg/scanner/listener.dart

Issue 9447100: Return null from stringValue and call slowToString() instead of toString(). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: changes Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/scanner/keyword.dart ('k') | dart/frog/leg/scanner/scanner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/scanner/listener.dart
diff --git a/dart/frog/leg/scanner/listener.dart b/dart/frog/leg/scanner/listener.dart
index 5461ff5023fab04b519502b54d21d59896adb912..fe0070b0340beeb7b027f14377bbd517f34c5cd9 100644
--- a/dart/frog/leg/scanner/listener.dart
+++ b/dart/frog/leg/scanner/listener.dart
@@ -409,46 +409,46 @@ class Listener {
}
Token expected(String string, Token token) {
- error("expected '$string', but got '$token'", token);
+ error("expected '$string', but got '${token.slowToString()}'", token);
return skipToEof(token);
}
void expectedIdentifier(Token token) {
- error("expected identifier, but got '$token'", token);
+ error("expected identifier, but got '${token.slowToString()}'", token);
}
Token expectedType(Token token) {
- error("expected a type, but got '$token'", token);
+ error("expected a type, but got '${token.slowToString()}'", token);
return skipToEof(token);
}
Token expectedExpression(Token token) {
- error("expected an expression, but got '$token'", token);
+ error("expected an expression, but got '${token.slowToString()}'", token);
return skipToEof(token);
}
Token unexpected(Token token) {
- error("unexpected token '$token'", token);
+ error("unexpected token '${token.slowToString()}'", token);
return skipToEof(token);
}
Token expectedBlockToSkip(Token token) {
- error("expected a block, but got '$token'", token);
+ error("expected a block, but got '${token.slowToString()}'", token);
return skipToEof(token);
}
Token expectedFunctionBody(Token token) {
- error("expected a function body, but got '$token'", token);
+ error("expected a function body, but got '${token.slowToString()}'", token);
return skipToEof(token);
}
Token expectedClassBody(Token token) {
- error("expected a class body, but got '$token'", token);
+ error("expected a class body, but got '${token.slowToString()}'", token);
return skipToEof(token);
}
Token expectedClassBodyToSkip(Token token) {
- error("expected a class body, but got '$token'", token);
+ error("expected a class body, but got '${token.slowToString()}'", token);
return skipToEof(token);
}
@@ -672,29 +672,33 @@ class ElementListener extends Listener {
}
Token expected(String string, Token token) {
- listener.cancel("expected '$string', but got '$token'", token: token);
+ listener.cancel("expected '$string', but got '${token.slowToString()}'",
+ token: token);
return skipToEof(token);
}
void expectedIdentifier(Token token) {
- listener.cancel("expected identifier, but got '$token'", token: token);
+ listener.cancel("expected identifier, but got '${token.slowToString()}'",
+ token: token);
pushNode(null);
}
Token expectedType(Token token) {
- listener.cancel("expected a type, but got '$token'", token: token);
+ listener.cancel("expected a type, but got '${token.slowToString()}'",
+ token: token);
pushNode(null);
return skipToEof(token);
}
Token expectedExpression(Token token) {
- listener.cancel("expected an expression, but got '$token'", token: token);
+ listener.cancel("expected an expression, but got '${token.slowToString()}'",
+ token: token);
pushNode(null);
return skipToEof(token);
}
Token unexpected(Token token) {
- listener.cancel("unexpected token '$token'", token: token);
+ listener.cancel("unexpected token '${token.slowToString()}'", token: token);
return skipToEof(token);
}
@@ -707,12 +711,15 @@ class ElementListener extends Listener {
}
Token expectedFunctionBody(Token token) {
- listener.cancel("expected a function body, but got '$token'", token: token);
+ String printString = token.slowToString();
+ listener.cancel("expected a function body, but got '$printString'",
+ token: token);
return skipToEof(token);
}
Token expectedClassBody(Token token) {
- listener.cancel("expected a class body, but got '$token'", token: token);
+ listener.cancel("expected a class body, but got '${token.slowToString()}'",
+ token: token);
return skipToEof(token);
}
@@ -936,7 +943,8 @@ class NodeListener extends ElementListener {
return native.handleNativeFunctionBody(this, token);
} else {
listener.cancel(
- "expected a function body, but got '$token'", token: token);
+ "expected a function body, but got '${token.slowToString()}'",
+ token: token);
return skipToEof(token);
}
}
@@ -945,7 +953,9 @@ class NodeListener extends ElementListener {
if (token.stringValue === 'native') {
return native.handleNativeClassBody(this, token);
} else {
- listener.cancel("expected a class body, but got '$token'", token: token);
+ listener.cancel(
+ "expected a class body, but got '${token.slowToString()}'",
+ token: token);
return skipToEof(token);
}
}
« no previous file with comments | « dart/frog/leg/scanner/keyword.dart ('k') | dart/frog/leg/scanner/scanner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698