Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: dart/frog/leg/warnings.dart

Issue 9447100: Return null from stringValue and call slowToString() instead of toString(). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: changes Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/universe.dart ('k') | dart/frog/tests/leg/src/ResolverTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/warnings.dart
diff --git a/dart/frog/leg/warnings.dart b/dart/frog/leg/warnings.dart
index 8d77a67d4bd862cd4ef88996ba559e705e3e09e0..4db77b47c7388615154e60d08f601e297b130017 100644
--- a/dart/frog/leg/warnings.dart
+++ b/dart/frog/leg/warnings.dart
@@ -142,7 +142,8 @@ class Message {
message = kind.template;
int position = 1;
for (var argument in arguments) {
- message = message.replaceAll('#{${position++}}', argument.toString());
+ String string = slowToString(argument);
+ message = message.replaceAll('#{${position++}}', string);
}
}
return message;
@@ -152,6 +153,14 @@ class Message {
if (other is !Message) return false;
return (kind == other.kind) && (toString() == other.toString());
}
+
+ String slowToString(object) {
+ if (object is SourceString) {
+ return object.slowToString();
+ } else {
+ return object.toString();
+ }
+ }
}
class TypeWarning {
« no previous file with comments | « dart/frog/leg/universe.dart ('k') | dart/frog/tests/leg/src/ResolverTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698