dart/frog/leg/ssa/closure.dart - Issue 9447100: Return null from stringValue and call slowToString() instead of toString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/frog/leg/ssa/closure.dart

Issue 9447100: Return null from stringValue and call slowToString() instead of toString(). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: changes Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/frog/leg/ssa/closure.dart

diff --git a/dart/frog/leg/ssa/closure.dart b/dart/frog/leg/ssa/closure.dart

index 08fca6f28e46907659c1ef73459e2b296004e609..374cfac0179dd0e0675a553ad22342841b454896 100644

--- a/dart/frog/leg/ssa/closure.dart

+++ b/dart/frog/leg/ssa/closure.dart

@@ -241,7 +241,7 @@ class ClosureTranslator extends AbstractVisitor {

currentFunctionElement);

}

// TODO(floitsch): construct better boxed names.

- String elementName = element.name.toString();

+ String elementName = element.name.slowToString();

// We are currently using the name in an HForeign which could replace

// "$X" with something else.

String escaped = elementName.replaceAll("\$", "_");

« no previous file with comments | « dart/frog/leg/ssa/builder.dart ('k') | dart/frog/leg/ssa/codegen.dart » ('j') | no next file with comments »