Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: dart/frog/leg/elements/elements.dart

Issue 9447100: Return null from stringValue and call slowToString() instead of toString(). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: changes Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/frog/leg/emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/elements/elements.dart
diff --git a/dart/frog/leg/elements/elements.dart b/dart/frog/leg/elements/elements.dart
index fa0d59d765247782a7829afc3acfb008d2152997..63014334350d375de46e49d43edef36ed0b90b65 100644
--- a/dart/frog/leg/elements/elements.dart
+++ b/dart/frog/leg/elements/elements.dart
@@ -537,7 +537,8 @@ class ClassElement extends ContainerElement {
Element existing = localMembers[element.name];
if (existing != null) {
if (existing.kind !== ElementKind.ABSTRACT_FIELD) {
- listener.cancel('duplicate definition of $name', element: element);
+ listener.cancel('duplicate definition of ${name.slowToString()}',
+ element: element);
listener.cancel('existing definition', element: existing);
} else {
AbstractFieldElement field = existing;
@@ -705,7 +706,9 @@ class Elements {
static SourceString constructConstructorName(SourceString receiver,
SourceString selector) {
- return new SourceString('$receiver\$$selector');
+ String r = receiver.slowToString();
+ String s = selector.slowToString();
+ return new SourceString('$r\$$s');
}
static SourceString constructOperatorName(SourceString receiver,
@@ -733,6 +736,9 @@ class Elements {
else if (str === '&' || str === '&=') str = 'and';
else if (str === '^' || str === '^=') str = 'xor';
else if (str === '|' || str === '|=') str = 'or';
+ else {
+ throw new Exception('Unhandled selector: ${selector.slowToString()}');
+ }
return new SourceString('$receiver\$$str');
}
}
« no previous file with comments | « no previous file | dart/frog/leg/emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698