Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2750843003: Rename TARGET_OS_* to HOST_OS_*. (Closed)

Created:
3 years, 9 months ago by rmacnak
Modified:
3 years, 9 months ago
Reviewers:
zra, Florian Schneider
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename TARGET_OS_* to HOST_OS_*. Like HOST_ARCH_*, HOST_OS_* describes the OS the VM is running on, which may be different from the OS the VM is generating code for during AOT compilation. Currently we conflate the two when emitting AOT as assembly, and we get away with it because Flutter only uses assembly for targeting iOS and one can only target iOS from a Mac, but we expect to use assembly for Android as well so native tools can unwind Dart frames. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/877284947b72bf719bc0defc5d97a6163b3f59e6

Patch Set 1 #

Patch Set 2 : DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -386 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/address_sanitizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/crypto_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/crypto_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/crypto_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/crypto_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/crypto_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/dartutils.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/directory_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/directory_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/directory_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/directory_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/directory_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/eventhandler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/bin/eventhandler_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/eventhandler_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/eventhandler_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/eventhandler_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/eventhandler_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/extensions_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/extensions_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/extensions_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/extensions_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/extensions_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/fdutils_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/fdutils_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/fdutils_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/fdutils_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/file_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/file_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/file_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/file_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/file_system_watcher_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/file_system_watcher_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/file_system_watcher_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/file_system_watcher_macos.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/bin/file_system_watcher_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/file_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/log_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/log_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/log_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/log_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/log_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/main.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M runtime/bin/platform_android.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/platform_fuchsia.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/platform_linux.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/platform_macos.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/bin/platform_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/process.h View 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/bin/process_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/process_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/process_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/process_macos.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/process_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/root_certificates_unsupported.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/secure_socket.h View 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/bin/secure_socket_boringssl.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M runtime/bin/secure_socket_ios.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/secure_socket_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/socket.h View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/bin/socket_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/socket_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/socket_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/socket_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/socket_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/stdio_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/stdio_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/stdio_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/stdio_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/stdio_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/test_extension_dllmain_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/thread.h View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/bin/thread_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/thread_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/thread_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/thread_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/thread_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/utils_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/utils_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/utils_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/utils_macos.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M runtime/bin/utils_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/double.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/uri.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/platform/floating_point_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/platform/globals.h View 3 chunks +13 lines, -13 lines 0 comments Download
M runtime/platform/math.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/platform/signal_blocker.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/platform/utils.h View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/assembler_x64_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/atomic.h View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/vm/atomic_android.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/atomic_fuchsia.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/atomic_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/atomic_macos.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/atomic_win.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/cpu_arm.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/cpu_arm64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/cpuid.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/cpuid.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/cpuinfo_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/cpuinfo_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/cpuinfo_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/cpuinfo_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/cpuinfo_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flag_list.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/globals.h View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/malloc_hooks.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/malloc_hooks_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/malloc_hooks_unsupported.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/native_arguments.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/native_symbol_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/native_symbol_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/native_symbol_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/native_symbol_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/native_symbol_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/os_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/os_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/os_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/os_macos.cc View 10 chunks +16 lines, -16 lines 0 comments Download
M runtime/vm/os_thread.h View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/vm/os_thread_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/os_thread_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/os_thread_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/os_thread_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/os_thread_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/os_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/proccpuinfo.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/proccpuinfo.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/profiler.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/signal_handler.h View 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/signal_handler_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/signal_handler_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/signal_handler_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/signal_handler_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/signal_handler_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/stack_frame.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/thread.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/thread_interrupter_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/thread_interrupter_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/thread_interrupter_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/thread_interrupter_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/thread_interrupter_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/timeline.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/virtual_memory_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/virtual_memory_fuchsia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/virtual_memory_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/virtual_memory_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/virtual_memory_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
rmacnak
3 years, 9 months ago (2017-03-15 01:02:41 UTC) #5
zra
You'll have to update https://github.com/dart-lang/root_certificates first, and roll it forward in the DEPS file in ...
3 years, 9 months ago (2017-03-15 16:54:44 UTC) #6
rmacnak
On 2017/03/15 16:54:44, zra wrote: > You'll have to update https://github.com/dart-lang/root_certificates first, and > roll ...
3 years, 9 months ago (2017-03-15 19:50:59 UTC) #7
zra
lgtm
3 years, 9 months ago (2017-03-15 19:56:04 UTC) #8
rmacnak
3 years, 9 months ago (2017-03-15 20:11:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
877284947b72bf719bc0defc5d97a6163b3f59e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698