Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 24469004: Amusingly deprecate the generic version of 'ExceptionState::throwDOMException'. (Closed)

Created:
7 years, 3 months ago by Mike West
Modified:
7 years, 2 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, eae+blinkwatch, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, aandrey+blink_chromium.org, do-not-use, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, alecflett, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, Rik, devtools-reviews_chromium.org, kenneth.christiansen, nessy, loislo+blink_chromium.org, lushnikov+blink_chromium.org, kinuko, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, paulirish+reviews_chromium.org, darktears, haraken, kojih, vcarbune.chromium, jsbell, jsbell+bindings_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, f(malita), dgrogan, Stephen Chennney, jeez, ojan
Visibility:
Public.

Description

Amusingly deprecate the generic version of 'ExceptionState::throwDOMException'. In an ideal world, everyone should write exceptionally detailed error messages when throwing exceptions. We'll move a bit closer to that world by requiring a second argument to 'throwDOMException'. This CL brought to you by the magic of `git grep` and `sed` (not `ed`, Jochen's protestations to the contrary): git grep -n -l -e 'throwDOMException\(\w*\)' -- '*.h' '*.cpp' '*.cc' | xargs -L1 sed -i '' -e 's/throwDOMException(\([a-zA-Z]*\))/throwUninformativeAndGenericDOMException(\1)/g' BUG=270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158313

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+669 lines, -666 lines) Patch
M Source/bindings/v8/ExceptionState.h View 3 chunks +6 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSMatrix.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/FontFace.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/FontFaceSet.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/MediaList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 10 chunks +13 lines, -13 lines 0 comments Download
M Source/core/dom/CustomElementException.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DOMTokenList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 29 chunks +36 lines, -36 lines 0 comments Download
M Source/core/dom/Element.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M Source/core/dom/MessagePort.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/MutationObserver.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/NamedNodeMap.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Node.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/Range.cpp View 34 chunks +41 lines, -41 lines 0 comments Download
M Source/core/editing/markup.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/EventTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDialogElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 8 chunks +12 lines, -12 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 14 chunks +14 lines, -14 lines 0 comments Download
M Source/core/html/HTMLMarqueeElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 8 chunks +14 lines, -14 lines 0 comments Download
M Source/core/html/HTMLMeterElement.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLOptionsCollection.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLProgressElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTableSectionElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MediaController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TimeRanges.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasPathMethods.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/CanvasPattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 24 chunks +31 lines, -31 lines 0 comments Download
M Source/core/html/canvas/DataView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/InputType.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/forms/NumberInputType.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/track/TextTrack.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/track/TextTrackCue.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/track/TextTrackRegion.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 14 chunks +26 lines, -26 lines 0 comments Download
M Source/core/platform/chromium/ChromiumDataObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/chromium/ClipboardChromium.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAltGlyphElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAngle.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGColor.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGLength.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGLengthContext.cpp View 9 chunks +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGLocatable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMatrix.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPreserveAspectRatio.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGViewSpec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/properties/SVGListProperty.h View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/properties/SVGTransformListPropertyTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/InternalSettings.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/testing/Internals.cpp View 97 chunks +114 lines, -114 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathEvaluator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathExpression.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xml/XPathParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/xml/XPathResult.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/Crypto.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/filesystem/DOMFileSystemSync.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/imagebitmap/ImageBitmapFactories.cpp View 7 chunks +14 lines, -14 lines 0 comments Download
M Source/modules/indexeddb/IDBCursor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/mediasource/MediaSourceBase.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/mediasource/SourceBuffer.cpp View 15 chunks +16 lines, -16 lines 0 comments Download
M Source/modules/mediasource/WebKitMediaSource.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/mediasource/WebKitSourceBuffer.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/mediastream/MediaConstraintsImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaStream.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/NavigatorMediaStream.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 16 chunks +33 lines, -33 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescription.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/notifications/NotificationCenter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AnalyserNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 10 chunks +11 lines, -11 lines 0 comments Download
M Source/modules/webaudio/AudioNode.cpp View 6 chunks +11 lines, -11 lines 0 comments Download
M Source/modules/webaudio/DefaultAudioDestinationNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/DelayNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/OfflineAudioContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/WaveShaperNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DOMWindowWebDatabase.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseSync.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/SQLResultSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLStatementSync.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/webdatabase/SQLTransaction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackendSync.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/webmidi/MIDIOutput.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/SharedWorkerRepository.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/StorageAreaProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike West
Hey Jochen, mind taking a look at this mechanized CL? The only non-mechanical change is ...
7 years, 3 months ago (2013-09-25 07:40:15 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 2 months ago (2013-09-25 08:08:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/24469004/1
7 years, 2 months ago (2013-09-25 08:10:12 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-09-25 09:32:32 UTC) #4
Message was sent while issue was closed.
Change committed as 158313

Powered by Google App Engine
This is Rietveld 408576698