Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1975)

Unified Diff: Source/core/svg/properties/SVGListProperty.h

Issue 24469004: Amusingly deprecate the generic version of 'ExceptionState::throwDOMException'. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGViewSpec.cpp ('k') | Source/core/svg/properties/SVGTransformListPropertyTearOff.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/properties/SVGListProperty.h
diff --git a/Source/core/svg/properties/SVGListProperty.h b/Source/core/svg/properties/SVGListProperty.h
index 7760b8d1d7167fe73cb6346bbdc9987a5dc05aad..c3267959c2e126de4ee17e3b59e4990c862fe92b 100644
--- a/Source/core/svg/properties/SVGListProperty.h
+++ b/Source/core/svg/properties/SVGListProperty.h
@@ -52,7 +52,7 @@ public:
bool canAlterList(ExceptionState& es) const
{
if (m_role == AnimValRole) {
- es.throwDOMException(NoModificationAllowedError);
+ es.throwUninformativeAndGenericDOMException(NoModificationAllowedError);
return false;
}
@@ -172,7 +172,7 @@ public:
bool canGetItem(unsigned index, ExceptionState& es)
{
if (index >= m_values->size()) {
- es.throwDOMException(IndexSizeError);
+ es.throwUninformativeAndGenericDOMException(IndexSizeError);
return false;
}
@@ -274,7 +274,7 @@ public:
return false;
if (index >= m_values->size()) {
- es.throwDOMException(IndexSizeError);
+ es.throwUninformativeAndGenericDOMException(IndexSizeError);
return false;
}
@@ -295,7 +295,7 @@ public:
if (m_values->isEmpty()) {
// 'newItem' already lived in our list, we removed it, and now we're empty, which means there's nothing to replace.
- es.throwDOMException(IndexSizeError);
+ es.throwUninformativeAndGenericDOMException(IndexSizeError);
return ListItemType();
}
@@ -329,7 +329,7 @@ public:
if (m_values->isEmpty()) {
ASSERT(m_wrappers->isEmpty());
// 'passNewItem' already lived in our list, we removed it, and now we're empty, which means there's nothing to replace.
- es.throwDOMException(IndexSizeError);
+ es.throwUninformativeAndGenericDOMException(IndexSizeError);
return 0;
}
@@ -353,7 +353,7 @@ public:
return false;
if (index >= m_values->size()) {
- es.throwDOMException(IndexSizeError);
+ es.throwUninformativeAndGenericDOMException(IndexSizeError);
return false;
}
« no previous file with comments | « Source/core/svg/SVGViewSpec.cpp ('k') | Source/core/svg/properties/SVGTransformListPropertyTearOff.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698