Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 24469004: Amusingly deprecate the generic version of 'ExceptionState::throwDOMException'. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLTextAreaElement.cpp ('k') | Source/core/html/HTMLVideoElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 206
207 207
208 void HTMLTextFormControlElement::setRangeText(const String& replacement, Excepti onState& es) 208 void HTMLTextFormControlElement::setRangeText(const String& replacement, Excepti onState& es)
209 { 209 {
210 setRangeText(replacement, selectionStart(), selectionEnd(), String(), es); 210 setRangeText(replacement, selectionStart(), selectionEnd(), String(), es);
211 } 211 }
212 212
213 void HTMLTextFormControlElement::setRangeText(const String& replacement, unsigne d start, unsigned end, const String& selectionMode, ExceptionState& es) 213 void HTMLTextFormControlElement::setRangeText(const String& replacement, unsigne d start, unsigned end, const String& selectionMode, ExceptionState& es)
214 { 214 {
215 if (start > end) { 215 if (start > end) {
216 es.throwDOMException(IndexSizeError); 216 es.throwUninformativeAndGenericDOMException(IndexSizeError);
217 return; 217 return;
218 } 218 }
219 219
220 String text = innerTextValue(); 220 String text = innerTextValue();
221 unsigned textLength = text.length(); 221 unsigned textLength = text.length();
222 unsigned replacementLength = replacement.length(); 222 unsigned replacementLength = replacement.length();
223 unsigned newSelectionStart = selectionStart(); 223 unsigned newSelectionStart = selectionStart();
224 unsigned newSelectionEnd = selectionEnd(); 224 unsigned newSelectionEnd = selectionEnd();
225 225
226 start = std::min(start, textLength); 226 start = std::min(start, textLength);
(...skipping 418 matching lines...) Expand 10 before | Expand all | Expand 10 after
645 bool isAuto; 645 bool isAuto;
646 TextDirection textDirection = static_cast<const HTMLElement*>(elemen t)->directionalityIfhasDirAutoAttribute(isAuto); 646 TextDirection textDirection = static_cast<const HTMLElement*>(elemen t)->directionalityIfhasDirAutoAttribute(isAuto);
647 return textDirection == RTL ? "rtl" : "ltr"; 647 return textDirection == RTL ? "rtl" : "ltr";
648 } 648 }
649 } 649 }
650 650
651 return "ltr"; 651 return "ltr";
652 } 652 }
653 653
654 } // namespace Webcore 654 } // namespace Webcore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLTextAreaElement.cpp ('k') | Source/core/html/HTMLVideoElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698