Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1719)

Unified Diff: Source/modules/webdatabase/SQLStatementSync.cpp

Issue 24469004: Amusingly deprecate the generic version of 'ExceptionState::throwDOMException'. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webdatabase/SQLResultSet.cpp ('k') | Source/modules/webdatabase/SQLTransaction.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webdatabase/SQLStatementSync.cpp
diff --git a/Source/modules/webdatabase/SQLStatementSync.cpp b/Source/modules/webdatabase/SQLStatementSync.cpp
index 94494ddb0b6b110a7d5d668c0f8d6675dce73ec7..1a6e0f2fb7004f089a1e8d8c42620c27e7b4756f 100644
--- a/Source/modules/webdatabase/SQLStatementSync.cpp
+++ b/Source/modules/webdatabase/SQLStatementSync.cpp
@@ -61,7 +61,7 @@ PassRefPtr<SQLResultSet> SQLStatementSync::execute(DatabaseSync* db, ExceptionSt
int result = statement.prepare();
if (result != SQLResultOk) {
if (result == SQLResultInterrupt)
- es.throwDOMException(SQLDatabaseError);
+ es.throwUninformativeAndGenericDOMException(SQLDatabaseError);
else
es.throwDOMException(SyntaxError, SQLError::syntaxErrorMessage);
db->setLastErrorMessage("could not prepare statement", result, database->lastErrorMsg());
@@ -70,7 +70,7 @@ PassRefPtr<SQLResultSet> SQLStatementSync::execute(DatabaseSync* db, ExceptionSt
if (statement.bindParameterCount() != m_arguments.size()) {
if (db->isInterrupted())
- es.throwDOMException(SQLDatabaseError);
+ es.throwUninformativeAndGenericDOMException(SQLDatabaseError);
else
es.throwDOMException(SyntaxError, SQLError::syntaxErrorMessage);
db->setLastErrorMessage("number of '?'s in statement string does not match argument count");
@@ -86,7 +86,7 @@ PassRefPtr<SQLResultSet> SQLStatementSync::execute(DatabaseSync* db, ExceptionSt
}
if (result != SQLResultOk) {
- es.throwDOMException(SQLDatabaseError);
+ es.throwUninformativeAndGenericDOMException(SQLDatabaseError);
db->setLastErrorMessage("could not bind value", result, database->lastErrorMsg());
return 0;
}
@@ -111,7 +111,7 @@ PassRefPtr<SQLResultSet> SQLStatementSync::execute(DatabaseSync* db, ExceptionSt
} while (result == SQLResultRow);
if (result != SQLResultDone) {
- es.throwDOMException(SQLDatabaseError);
+ es.throwUninformativeAndGenericDOMException(SQLDatabaseError);
db->setLastErrorMessage("could not iterate results", result, database->lastErrorMsg());
return 0;
}
@@ -129,7 +129,7 @@ PassRefPtr<SQLResultSet> SQLStatementSync::execute(DatabaseSync* db, ExceptionSt
db->setLastErrorMessage("statement failed due to a constraint failure");
return 0;
} else {
- es.throwDOMException(SQLDatabaseError);
+ es.throwUninformativeAndGenericDOMException(SQLDatabaseError);
db->setLastErrorMessage("could not execute statement", result, database->lastErrorMsg());
return 0;
}
« no previous file with comments | « Source/modules/webdatabase/SQLResultSet.cpp ('k') | Source/modules/webdatabase/SQLTransaction.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698