Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: Source/core/html/forms/InputType.cpp

Issue 24469004: Amusingly deprecate the generic version of 'ExceptionState::throwDOMException'. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/canvas/DataView.cpp ('k') | Source/core/html/forms/NumberInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/forms/InputType.cpp
diff --git a/Source/core/html/forms/InputType.cpp b/Source/core/html/forms/InputType.cpp
index dbabab5b7650414c296b95e4609fb4909bdb5aca..8f85933133f599d4c12539f92943e9710ada244c 100644
--- a/Source/core/html/forms/InputType.cpp
+++ b/Source/core/html/forms/InputType.cpp
@@ -207,7 +207,7 @@ double InputType::valueAsDate() const
void InputType::setValueAsDate(double, ExceptionState& es) const
{
- es.throwDOMException(InvalidStateError);
+ es.throwUninformativeAndGenericDOMException(InvalidStateError);
}
double InputType::valueAsDouble() const
@@ -222,7 +222,7 @@ void InputType::setValueAsDouble(double doubleValue, TextFieldEventBehavior even
void InputType::setValueAsDecimal(const Decimal&, TextFieldEventBehavior, ExceptionState& es) const
{
- es.throwDOMException(InvalidStateError);
+ es.throwUninformativeAndGenericDOMException(InvalidStateError);
}
bool InputType::supportsValidation() const
@@ -835,24 +835,24 @@ void InputType::applyStep(int count, AnyStepHandling anyStepHandling, TextFieldE
{
StepRange stepRange(createStepRange(anyStepHandling));
if (!stepRange.hasStep()) {
- es.throwDOMException(InvalidStateError);
+ es.throwUninformativeAndGenericDOMException(InvalidStateError);
return;
}
const Decimal current = parseToNumberOrNaN(element()->value());
if (!current.isFinite()) {
- es.throwDOMException(InvalidStateError);
+ es.throwUninformativeAndGenericDOMException(InvalidStateError);
return;
}
Decimal newValue = current + stepRange.step() * count;
if (!newValue.isFinite()) {
- es.throwDOMException(InvalidStateError);
+ es.throwUninformativeAndGenericDOMException(InvalidStateError);
return;
}
const Decimal acceptableErrorValue = stepRange.acceptableError();
if (newValue - stepRange.minimum() < -acceptableErrorValue) {
- es.throwDOMException(InvalidStateError);
+ es.throwUninformativeAndGenericDOMException(InvalidStateError);
return;
}
if (newValue < stepRange.minimum())
@@ -863,7 +863,7 @@ void InputType::applyStep(int count, AnyStepHandling anyStepHandling, TextFieldE
newValue = stepRange.alignValueForStep(current, newValue);
if (newValue - stepRange.maximum() > acceptableErrorValue) {
- es.throwDOMException(InvalidStateError);
+ es.throwUninformativeAndGenericDOMException(InvalidStateError);
return;
}
if (newValue > stepRange.maximum())
@@ -891,7 +891,7 @@ StepRange InputType::createStepRange(AnyStepHandling) const
void InputType::stepUp(int n, ExceptionState& es)
{
if (!isSteppable()) {
- es.throwDOMException(InvalidStateError);
+ es.throwUninformativeAndGenericDOMException(InvalidStateError);
return;
}
applyStep(n, RejectAny, DispatchNoEvent, es);
« no previous file with comments | « Source/core/html/canvas/DataView.cpp ('k') | Source/core/html/forms/NumberInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698