Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: Source/core/svg/SVGLengthContext.cpp

Issue 24469004: Amusingly deprecate the generic version of 'ExceptionState::throwDOMException'. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGLength.cpp ('k') | Source/core/svg/SVGLocatable.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGLengthContext.cpp
diff --git a/Source/core/svg/SVGLengthContext.cpp b/Source/core/svg/SVGLengthContext.cpp
index 1c8ed6a4bc11fe40ac77bee3ee48d6dd9044a92d..445bf841cdda760af9b9616da7e4936026013f0f 100644
--- a/Source/core/svg/SVGLengthContext.cpp
+++ b/Source/core/svg/SVGLengthContext.cpp
@@ -98,7 +98,7 @@ float SVGLengthContext::convertValueToUserUnits(float value, SVGLengthMode mode,
switch (fromUnit) {
case LengthTypeUnknown:
- es.throwDOMException(NotSupportedError);
+ es.throwUninformativeAndGenericDOMException(NotSupportedError);
return 0;
case LengthTypeNumber:
return value;
@@ -130,7 +130,7 @@ float SVGLengthContext::convertValueFromUserUnits(float value, SVGLengthMode mod
{
switch (toUnit) {
case LengthTypeUnknown:
- es.throwDOMException(NotSupportedError);
+ es.throwUninformativeAndGenericDOMException(NotSupportedError);
return 0;
case LengthTypeNumber:
return value;
@@ -163,7 +163,7 @@ float SVGLengthContext::convertValueFromUserUnitsToPercentage(float value, SVGLe
float width = 0;
float height = 0;
if (!determineViewport(width, height)) {
- es.throwDOMException(NotSupportedError);
+ es.throwUninformativeAndGenericDOMException(NotSupportedError);
return 0;
}
@@ -185,7 +185,7 @@ float SVGLengthContext::convertValueFromPercentageToUserUnits(float value, SVGLe
float width = 0;
float height = 0;
if (!determineViewport(width, height)) {
- es.throwDOMException(NotSupportedError);
+ es.throwUninformativeAndGenericDOMException(NotSupportedError);
return 0;
}
@@ -223,13 +223,13 @@ float SVGLengthContext::convertValueFromUserUnitsToEMS(float value, ExceptionSta
{
RenderStyle* style = renderStyleForLengthResolving(m_context);
if (!style) {
- es.throwDOMException(NotSupportedError);
+ es.throwUninformativeAndGenericDOMException(NotSupportedError);
return 0;
}
float fontSize = style->specifiedFontSize();
if (!fontSize) {
- es.throwDOMException(NotSupportedError);
+ es.throwUninformativeAndGenericDOMException(NotSupportedError);
return 0;
}
@@ -240,7 +240,7 @@ float SVGLengthContext::convertValueFromEMSToUserUnits(float value, ExceptionSta
{
RenderStyle* style = renderStyleForLengthResolving(m_context);
if (!style) {
- es.throwDOMException(NotSupportedError);
+ es.throwUninformativeAndGenericDOMException(NotSupportedError);
return 0;
}
@@ -251,7 +251,7 @@ float SVGLengthContext::convertValueFromUserUnitsToEXS(float value, ExceptionSta
{
RenderStyle* style = renderStyleForLengthResolving(m_context);
if (!style) {
- es.throwDOMException(NotSupportedError);
+ es.throwUninformativeAndGenericDOMException(NotSupportedError);
return 0;
}
@@ -259,7 +259,7 @@ float SVGLengthContext::convertValueFromUserUnitsToEXS(float value, ExceptionSta
// if this causes problems in real world cases maybe it would be best to remove this
float xHeight = ceilf(style->fontMetrics().xHeight());
if (!xHeight) {
- es.throwDOMException(NotSupportedError);
+ es.throwUninformativeAndGenericDOMException(NotSupportedError);
return 0;
}
@@ -270,7 +270,7 @@ float SVGLengthContext::convertValueFromEXSToUserUnits(float value, ExceptionSta
{
RenderStyle* style = renderStyleForLengthResolving(m_context);
if (!style) {
- es.throwDOMException(NotSupportedError);
+ es.throwUninformativeAndGenericDOMException(NotSupportedError);
return 0;
}
« no previous file with comments | « Source/core/svg/SVGLength.cpp ('k') | Source/core/svg/SVGLocatable.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698