mash: Use ash shell window container ids instead of ash::mojom::Container

mash: Use ash shell window container ids instead of ash::mojom::Container

I need to use additional window containers in a subsequent CL. Rather than
continue to maintain a mapping of kShellWindowId_Foo to ash::mojom::Container,
just use the ash container ids natively.

* Add kInitialContainerId_Property to window_manager.mojom, which is where we
set initial bounds and initial display.
* Remove container.mojom and associated utility functions.
* Replace usage of Container::LOGIN_WINDOW with LockScreenContainer, which is
where the windows end up.
* Ditto for Container::OVERLAY.
* Move ash/common/shell_window_ids.h to ash/public/cpp/

BUG=647412
TEST=compiles, chrome --mash --login-manager shows login dialogs correctly
TBR=reveman@chromium.org for exo

Committed: https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6
Cr-Commit-Position: refs/heads/master@{#426161}

[James Cook, 2016-10-18 01:25:53]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 01:26:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-18 01:27:18]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-10-18 01:27:19]

sky, please take a look. Patchset 1 is the conversion from Container to shell
window id and patchset 2 is the file move and cleanup of DEPS and BUILD.gn
files.

I moved shell_window_ids.h to //ash/shared. Do you think that's the right place,
or would //ash/public/cpp be more idiomatic?

[sky, 2016-10-18 02:45:53]

https://codereview.chromium.org/2430593002/diff/20001/ash/shared/BUILD.gn
File ash/shared/BUILD.gn (right):

https://codereview.chromium.org/2430593002/diff/20001/ash/shared/BUILD.gn#new...
ash/shared/BUILD.gn:5: source_set("shared") {
As this is a source_set there isn't any point in the ASH_SHARED_EXPORT. Also, I
think we should keep logically unrelated source files in separate source_sets. I
say this as it's very unlikely that all apps want all the files in this
directory.

[commit-bot: I haz the power, 2016-10-18 02:53:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 02:53:42]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-10-18 04:42:04]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 04:42:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-18 04:43:28]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2016-10-18 04:44:50]

Patchset #3 (id:40001) has been deleted

[James Cook, 2016-10-18 04:45:08]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 04:45:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-18 04:45:45]

sky, please take another look.

https://codereview.chromium.org/2430593002/diff/20001/ash/shared/BUILD.gn
File ash/shared/BUILD.gn (right):

https://codereview.chromium.org/2430593002/diff/20001/ash/shared/BUILD.gn#new...
ash/shared/BUILD.gn:5: source_set("shared") {
On 2016/10/18 02:45:53, sky wrote:
> As this is a source_set there isn't any point in the ASH_SHARED_EXPORT. Also,
I
> think we should keep logically unrelated source files in separate source_sets.
I
> say this as it's very unlikely that all apps want all the files in this
> directory.

Whoops, I uploaded the ash_shared_export.h file by mistake from an earlier
patch. I never actually used the macro it defines.

I split the shell_window_ids files into their own source set. I put
//ash/shared:shell_window_ids into public_deps for targets that include
shell_window_ids.h inside their headers, and in regular deps for those than only
use it in .cc files.

[commit-bot: I haz the power, 2016-10-18 05:54:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 05:54:48]

Dry run: This issue passed the CQ dry run.

[sky, 2016-10-18 16:59:04]

LGTM

[James Cook, 2016-10-18 17:03:18]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-10-18 17:03:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 17:14:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 17:14:35]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[James Cook, 2016-10-18 17:18:12]

jamescook@chromium.org changed reviewers:
+ tsepez@google.com

[James Cook, 2016-10-18 17:18:13]

tsepez, can I get OWNERS for adding an int window property to
services/ui/public/interfaces/window_manager.mojom ?

[James Cook, 2016-10-18 20:08:21]

jamescook@chromium.org changed reviewers:
+ rsesek@chromium.org
- tsepez@google.com

[James Cook, 2016-10-18 20:08:22]

rsesek, tsepez is OOO, can I get security owners for
services/ui/public/interfaces/window_manager.mojom ?

[Robert Sesek, 2016-10-18 20:39:10]

lgtm

[James Cook, 2016-10-18 20:45:15]

Description was changed from

==========
mash: Use ash shell window container ids instead of ash::mojom::Container

I need to use additional window containers in a subsequent CL. Rather than
continue to maintain a mapping of kShellWindowId_Foo to ash::mojom::Container,
just use the ash container ids natively.

* Add kInitialContainerId_Property to window_manager.mojom, which is where we
set initial bounds and initial display.
* Remove container.mojom and associated utility functions.
* Replace usage of Container::LOGIN_WINDOW with LockScreenContainer, which is
where the windows end up.
* Ditto for Container::OVERLAY.
* Move ash/common/shell_window_ids.h to ash/shared/

BUG=647412
TEST=compiles, chrome --mash --login-manager shows login dialogs correctly
==========

to

==========
mash: Use ash shell window container ids instead of ash::mojom::Container

I need to use additional window containers in a subsequent CL. Rather than
continue to maintain a mapping of kShellWindowId_Foo to ash::mojom::Container,
just use the ash container ids natively.

* Add kInitialContainerId_Property to window_manager.mojom, which is where we
set initial bounds and initial display.
* Remove container.mojom and associated utility functions.
* Replace usage of Container::LOGIN_WINDOW with LockScreenContainer, which is
where the windows end up.
* Ditto for Container::OVERLAY.
* Move ash/common/shell_window_ids.h to ash/shared/

BUG=647412
TEST=compiles, chrome --mash --login-manager shows login dialogs correctly
TBR=reveman@chromium.org for exo
==========

[James Cook, 2016-10-18 20:45:47]

jamescook@chromium.org changed reviewers:
+ reveman@chromium.org

[James Cook, 2016-10-18 20:45:48]

TBR reveman for header file move touching exo

[James Cook, 2016-10-18 20:46:03]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-10-18 20:46:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 20:55:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 20:55:46]

Failed to apply patch for ash/public/interfaces/BUILD.gn:
While running git apply --index -3 -p1;
  error: patch failed: ash/public/interfaces/BUILD.gn:7
  Falling back to three-way merge...
  Applied patch to 'ash/public/interfaces/BUILD.gn' with conflicts.
  U ash/public/interfaces/BUILD.gn

Patch:       ash/public/interfaces/BUILD.gn
Index: ash/public/interfaces/BUILD.gn
diff --git a/ash/public/interfaces/BUILD.gn b/ash/public/interfaces/BUILD.gn
index
0570864ba57027a57ed0d518c9ce2f2a87538f14..20b847a173c9af2d594c3db5ce2e91132b06be4a
100644
--- a/ash/public/interfaces/BUILD.gn
+++ b/ash/public/interfaces/BUILD.gn
@@ -7,7 +7,6 @@ import("//mojo/public/tools/bindings/mojom.gni")
 mojom("interfaces") {
   sources = [
     "ash_window_type.mojom",
-    "container.mojom",
     "shelf.mojom",
     "system_tray.mojom",
     "wallpaper.mojom",

[James Cook, 2016-10-18 21:26:38]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-10-18 21:26:38]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2430593002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-18 21:27:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-18 21:48:50]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2016-10-18 22:36:55]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-10-18 22:37:09]

Description was changed from

==========
mash: Use ash shell window container ids instead of ash::mojom::Container

I need to use additional window containers in a subsequent CL. Rather than
continue to maintain a mapping of kShellWindowId_Foo to ash::mojom::Container,
just use the ash container ids natively.

* Add kInitialContainerId_Property to window_manager.mojom, which is where we
set initial bounds and initial display.
* Remove container.mojom and associated utility functions.
* Replace usage of Container::LOGIN_WINDOW with LockScreenContainer, which is
where the windows end up.
* Ditto for Container::OVERLAY.
* Move ash/common/shell_window_ids.h to ash/shared/

BUG=647412
TEST=compiles, chrome --mash --login-manager shows login dialogs correctly
TBR=reveman@chromium.org for exo
==========

to

==========
mash: Use ash shell window container ids instead of ash::mojom::Container

I need to use additional window containers in a subsequent CL. Rather than
continue to maintain a mapping of kShellWindowId_Foo to ash::mojom::Container,
just use the ash container ids natively.

* Add kInitialContainerId_Property to window_manager.mojom, which is where we
set initial bounds and initial display.
* Remove container.mojom and associated utility functions.
* Replace usage of Container::LOGIN_WINDOW with LockScreenContainer, which is
where the windows end up.
* Ditto for Container::OVERLAY.
* Move ash/common/shell_window_ids.h to ash/public/cpp/

BUG=647412
TEST=compiles, chrome --mash --login-manager shows login dialogs correctly
TBR=reveman@chromium.org for exo
==========

[commit-bot: I haz the power, 2016-10-18 22:37:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-18 22:40:14]

Discussed offline with sky - I put shell_window_ids.h into //ash/public/cpp
instead of //ash/shared.

[James Cook, 2016-10-18 23:14:34]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2016-10-18 23:14:46]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-10-18 23:14:47]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2430593002/#ps100001
(title: "ash/public/cpp")

[commit-bot: I haz the power, 2016-10-18 23:15:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 23:55:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 23:55:33]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-10-19 00:04:29]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-10-19 00:04:30]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2430593002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-19 00:05:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 00:16:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 00:16:57]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[James Cook, 2016-10-19 00:23:43]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-10-19 00:24:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 01:35:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 01:35:36]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[James Cook, 2016-10-19 04:30:52]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-10-19 04:33:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 12:46:56]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-10-21 13:07:24]

Description was changed from

==========
mash: Use ash shell window container ids instead of ash::mojom::Container

I need to use additional window containers in a subsequent CL. Rather than
continue to maintain a mapping of kShellWindowId_Foo to ash::mojom::Container,
just use the ash container ids natively.

* Add kInitialContainerId_Property to window_manager.mojom, which is where we
set initial bounds and initial display.
* Remove container.mojom and associated utility functions.
* Replace usage of Container::LOGIN_WINDOW with LockScreenContainer, which is
where the windows end up.
* Ditto for Container::OVERLAY.
* Move ash/common/shell_window_ids.h to ash/public/cpp/

BUG=647412
TEST=compiles, chrome --mash --login-manager shows login dialogs correctly
TBR=reveman@chromium.org for exo
==========

to

==========
mash: Use ash shell window container ids instead of ash::mojom::Container

I need to use additional window containers in a subsequent CL. Rather than
continue to maintain a mapping of kShellWindowId_Foo to ash::mojom::Container,
just use the ash container ids natively.

* Add kInitialContainerId_Property to window_manager.mojom, which is where we
set initial bounds and initial display.
* Remove container.mojom and associated utility functions.
* Replace usage of Container::LOGIN_WINDOW with LockScreenContainer, which is
where the windows end up.
* Ditto for Container::OVERLAY.
* Move ash/common/shell_window_ids.h to ash/public/cpp/

BUG=647412
TEST=compiles, chrome --mash --login-manager shows login dialogs correctly
TBR=reveman@chromium.org for exo

Committed: https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6
Cr-Commit-Position: refs/heads/master@{#426161}
==========

[commit-bot: I haz the power, 2016-10-21 13:07:26]

Patchset 6 (id:??) landed as
https://crrev.com/8800b8237af34e0b519727164c892eb78baee4a6
Cr-Commit-Position: refs/heads/master@{#426161}