Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 23826002: Rename ShaderType enum to ShaderVisibility (Closed)

Created:
5 years, 12 months ago by Chris Dalton
Modified:
5 years, 12 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Rename ShaderType enum to ShaderVisibility Renames ShaderType in GrGLShaderBuilder to ShaderVisibility. It is now used solely as a bitfield. Methods that previously accepted a single ShaderType value are split into separate calls: - getShader -> vsGetShader, gsGetShader, fsGetShader - emiitFunction -> fsEmitFunction - appendTextureLookup -> fsAppendTextureLookup No change in functionality. This is a refactoring to allow us to separate the vertex/geometry and fragment parts of GrGLShaderBuilder. Committed: http://code.google.com/p/skia/source/detail?r=11044

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -364 lines) Patch
M src/core/SkXfermode.cpp View 1 6 chunks +26 lines, -34 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M src/effects/SkBicubicImageFilter.cpp View 3 chunks +11 lines, -14 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 3 chunks +3 lines, -9 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 14 chunks +51 lines, -59 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 6 chunks +32 lines, -32 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M src/gpu/effects/GrTextureDomainEffect.cpp View 4 chunks +4 lines, -13 lines 0 comments Download
M src/gpu/gl/GrGLEffectMatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 8 chunks +35 lines, -41 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 9 chunks +60 lines, -104 lines 0 comments Download
M src/gpu/gl/GrGLUniformManager.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Chris Dalton
PTAL
5 years, 12 months ago (2013-08-30 15:59:07 UTC) #1
bsalomon
lgtm w/ one small request https://codereview.chromium.org/23826002/diff/1/src/core/SkXfermode.cpp File src/core/SkXfermode.cpp (right): https://codereview.chromium.org/23826002/diff/1/src/core/SkXfermode.cpp#newcode1251 src/core/SkXfermode.cpp:1251: "set_luminance", nit, can we ...
5 years, 12 months ago (2013-08-30 17:47:55 UTC) #2
Chris Dalton
I addressed the comment, and had to do a rebase since a connflicting patch snuck ...
5 years, 12 months ago (2013-08-30 18:22:16 UTC) #3
bsalomon
On 2013/08/30 18:22:16, cdalton wrote: > I addressed the comment, and had to do a ...
5 years, 12 months ago (2013-08-30 18:26:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/23826002/6001
5 years, 12 months ago (2013-08-30 18:26:47 UTC) #5
commit-bot: I haz the power
5 years, 12 months ago (2013-08-30 19:44:13 UTC) #6
Message was sent while issue was closed.
Change committed as 11044

Powered by Google App Engine
This is Rietveld 408576698