alpha threshold bitmap shader

alpha threshold bitmap shader

Committed: http://code.google.com/p/skia/source/detail?r=11122

Committed: http://code.google.com/p/skia/source/detail?r=11131

[bsalomon, 2013-09-03 15:21:10]

In no way ready to land.

[bsalomon, 2013-09-04 21:33:43]

Probably ready for a header review and to land as an experimental effect. Needs
CPU implementation, serialization, caching of region mask textures. Also should
it respect bitmap filtering? What about HQ? Are tile modes sensible?

[reed1, 2013-09-05 15:14:54]

https://codereview.chromium.org/23707019/diff/6001/include/effects/SkBitmapAl...
File include/effects/SkBitmapAlphaThresholdShader.h (right):

https://codereview.chromium.org/23707019/diff/6001/include/effects/SkBitmapAl...
include/effects/SkBitmapAlphaThresholdShader.h:25: static SkShader*
Create(SkBitmap bitmap, const SkRegion& region, U8CPU threshold);
nit: const SkBitmap&

https://codereview.chromium.org/23707019/diff/6001/include/effects/SkBitmapAl...
include/effects/SkBitmapAlphaThresholdShader.h:27: virtual void shadeSpan(int x,
int y, SkPMColor[], int count) SK_OVERRIDE {};
Suggestion:

move all of this method stuff into the .cpp, so the public factory just looks
like

class MyFancyShader : public SkShader {
public:
    static SkShader* Create(...);
};

Basically, we just need to scope the Create function, and a class prefix is
convenient/somewhat-self-documenting. See SkBlurMaskFilter.h

[bsalomon, 2013-09-05 18:43:17]

alpha threshold bitmap shader

[bsalomon, 2013-09-05 19:54:50]

https://codereview.chromium.org/23707019/diff/6001/include/effects/SkBitmapAl...
File include/effects/SkBitmapAlphaThresholdShader.h (right):

https://codereview.chromium.org/23707019/diff/6001/include/effects/SkBitmapAl...
include/effects/SkBitmapAlphaThresholdShader.h:25: static SkShader*
Create(SkBitmap bitmap, const SkRegion& region, U8CPU threshold);
On 2013/09/05 15:14:54, reed1 wrote:
> nit: const SkBitmap&

Done.

https://codereview.chromium.org/23707019/diff/6001/include/effects/SkBitmapAl...
include/effects/SkBitmapAlphaThresholdShader.h:27: virtual void shadeSpan(int x,
int y, SkPMColor[], int count) SK_OVERRIDE {};
On 2013/09/05 15:14:54, reed1 wrote:
> Suggestion:
> 
> move all of this method stuff into the .cpp, so the public factory just looks
> like
> 
> class MyFancyShader : public SkShader {
> public:
>     static SkShader* Create(...);
> };
> 
> Basically, we just need to scope the Create function, and a class prefix is
> convenient/somewhat-self-documenting. See SkBlurMaskFilter.h

Done.

[reed1, 2013-09-05 20:23:52]

lgtm

[commit-bot: I haz the power, 2013-09-05 20:29:49]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/23707019/23001

[commit-bot: I haz the power, 2013-09-05 20:47:27]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/23707019/42001

[commit-bot: I haz the power, 2013-09-05 21:54:14]

Change committed as 11122

[commit-bot: I haz the power, 2013-09-06 15:20:04]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/23707019/51001

[commit-bot: I haz the power, 2013-09-06 15:31:34]

Change committed as 11131