Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23581008: Revert r154797: "Move isValid/isCurrentColor from Color to StyleColor" (Closed)

Created:
7 years, 3 months ago by eae
Modified:
7 years, 3 months ago
CC:
blink-reviews, shans, eae+blinkwatch, yurys+blink_chromium.org, blink-layers+watch_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, loislo+blink_chromium.org, aandrey+blink_chromium.org, dino_apple.com, jamesr, caseq+blink_chromium.org, Steve Block, aboxhall, pfeldman+blink_chromium.org, dglazkov+blink, danakj, dstockwell, Timothy Loh, Rik, jchaffraix+rendering, devtools-reviews_chromium.org, pdr., Eric Willigers, kenneth.christiansen, nessy, rjwright, lushnikov+blink_chromium.org, eustas+blink_chromium.org, dmazzoni, darktears, vcarbune.chromium, alancutter (OOO until 2018), alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, Mike Lawther (Google), paulirish+reviews_chromium.org, f(malita), Stephen Chennney, jeez
Visibility:
Public.

Description

Revert r154797: "Move isValid/isCurrentColor from Color to StyleColor" r154797 caused a number of regressions and instead of trying to fix them one at a time the change is reverted for now. BUG=272678, 284357 R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157239

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -628 lines) Patch
M Source/core/accessibility/AccessibilityNodeObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AccessibilityTable.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 14 chunks +17 lines, -34 lines 0 comments Download
M Source/core/css/CSSGradientValue.h View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/css/CSSGradientValue.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSParser-in.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSToStyleMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/SVGCSSComputedStyleDeclaration.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/core/css/StyleColor.h View 2 chunks +2 lines, -5 lines 0 comments Download
D Source/core/css/StyleColor.cpp View 1 chunk +0 lines, -84 lines 0 comments Download
M Source/core/css/resolver/ElementStyleResources.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ElementStyleResources.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/resolver/MatchedPropertiesCache.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 5 chunks +10 lines, -6 lines 0 comments Download
M Source/core/css/resolver/StyleResolverState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TextLinkColors.h View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/dom/TextLinkColors.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/ColorInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ColorInputType.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/InbandTextTrack.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackCueGeneric.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackCueGeneric.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorFrontendHost.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/Frame.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/page/Frame.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/FrameView.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/FrameView.cpp View 6 chunks +14 lines, -14 lines 0 comments Download
M Source/core/page/animation/CSSPropertyAnimation.cpp View 10 chunks +31 lines, -36 lines 0 comments Download
M Source/core/platform/graphics/Color.h View 5 chunks +20 lines, -10 lines 0 comments Download
M Source/core/platform/graphics/Color.cpp View 3 chunks +46 lines, -1 line 0 comments Download
M Source/core/platform/graphics/DrawLooper.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/GraphicsContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/GraphicsLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/ShadowBlur.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/EllipsisBox.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 4 chunks +5 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderMenuList.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 3 chunks +8 lines, -54 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 3 chunks +15 lines, -16 lines 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTheme.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 6 chunks +22 lines, -43 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/style/BorderValue.h View 5 chunks +8 lines, -11 lines 0 comments Download
M Source/core/rendering/style/CachedUAStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/CollapsedBorderValue.h View 4 chunks +5 lines, -8 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 18 chunks +73 lines, -68 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 6 chunks +13 lines, -16 lines 1 comment Download
M Source/core/rendering/style/ShadowData.h View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/style/StyleBackgroundData.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/style/StyleInheritedData.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/style/StyleMultiColData.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/rendering/style/StyleRareInheritedData.h View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/rendering/style/StyleRareInheritedData.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 2 chunks +8 lines, -9 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResource.cpp View 8 chunks +10 lines, -9 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGAnimatedColor.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGColor.h View 4 chunks +3 lines, -10 lines 0 comments Download
M Source/core/svg/SVGColor.cpp View 3 chunks +6 lines, -10 lines 0 comments Download
M Source/core/svg/SVGStopElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ColorChooserPopupUIController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/LinkHighlight.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/mac/WebSubstringUtil.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
eae
7 years, 3 months ago (2013-09-03 23:37:39 UTC) #1
eae
+dglazkov for Source/web approval.
7 years, 3 months ago (2013-09-03 23:43:16 UTC) #2
leviw_travelin_and_unemployed
Looks like a couple weird merge issues, but it's close. https://chromiumcodereview.appspot.com/23581008/diff/1/Source/core/css/resolver/FilterOperationResolver.cpp File Source/core/css/resolver/FilterOperationResolver.cpp (right): https://chromiumcodereview.appspot.com/23581008/diff/1/Source/core/css/resolver/FilterOperationResolver.cpp#newcode490 ...
7 years, 3 months ago (2013-09-04 00:37:10 UTC) #3
eae
Thanks Levi. PTAL https://chromiumcodereview.appspot.com/23581008/diff/1/Source/core/css/resolver/FilterOperationResolver.cpp File Source/core/css/resolver/FilterOperationResolver.cpp (right): https://chromiumcodereview.appspot.com/23581008/diff/1/Source/core/css/resolver/FilterOperationResolver.cpp#newcode490 Source/core/css/resolver/FilterOperationResolver.cpp:490: Color color; Good idea. Done. https://chromiumcodereview.appspot.com/23581008/diff/1/Source/core/rendering/RenderTheme.cpp ...
7 years, 3 months ago (2013-09-04 00:42:13 UTC) #4
leviw_travelin_and_unemployed
LGTM. https://chromiumcodereview.appspot.com/23581008/diff/6001/Source/core/rendering/style/RenderStyle.cpp File Source/core/rendering/style/RenderStyle.cpp (right): https://chromiumcodereview.appspot.com/23581008/diff/6001/Source/core/rendering/style/RenderStyle.cpp#newcode1339 Source/core/rendering/style/RenderStyle.cpp:1339: case CSSPropertyFloodColor: I'm really sad to hear we ...
7 years, 3 months ago (2013-09-04 00:51:43 UTC) #5
eae
7 years, 3 months ago (2013-09-04 15:37:43 UTC) #6
eae
Need Source/web approval. To unsubscribe from this group and stop receiving emails from it, send ...
7 years, 3 months ago (2013-09-04 15:38:19 UTC) #7
dglazkov
lgtm.
7 years, 3 months ago (2013-09-04 18:55:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/23581008/6001
7 years, 3 months ago (2013-09-04 18:59:56 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 19:59:44 UTC) #10
Message was sent while issue was closed. 
Change committed as 157239

Powered by Google App Engine
This is Rietveld 408576698