Source/core/html/track/InbandTextTrack.cpp - Issue 23581008: Revert r154797: "Move isValid/isCurrentColor from Color to StyleColor"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/InbandTextTrack.cpp

Issue 23581008: Revert r154797: "Move isValid/isCurrentColor from Color to StyleColor" (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/InbandTextTrack.cpp

diff --git a/Source/core/html/track/InbandTextTrack.cpp b/Source/core/html/track/InbandTextTrack.cpp

index b1076d4028a9960c6ecef517d38979ab75811f72..95f629d74ef34175a4c26d0ee21b8260b7a0bb3e 100644

--- a/Source/core/html/track/InbandTextTrack.cpp

+++ b/Source/core/html/track/InbandTextTrack.cpp

@@ -156,9 +156,9 @@ void InbandTextTrack::addGenericCue(InbandTextTrackPrivate* trackPrivate, Generi

cue->setLine(lround(cueData->line()), IGNORE_EXCEPTION);

if (cueData->size() > 0)

cue->setSize(lround(cueData->size()), IGNORE_EXCEPTION);

- if (cueData->backgroundColor().alpha())

+ if (cueData->backgroundColor().isValid())

cue->setBackgroundColor(cueData->backgroundColor().rgb());

- if (cueData->foregroundColor().alpha())

+ if (cueData->foregroundColor().isValid())

cue->setForegroundColor(cueData->foregroundColor().rgb());

if (cueData->align() == GenericCueData::Start)