Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: Source/core/rendering/style/BorderValue.h

Issue 23581008: Revert r154797: "Move isValid/isCurrentColor from Color to StyleColor" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com) 6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
11 * version 2 of the License, or (at your option) any later version. 11 * version 2 of the License, or (at your option) any later version.
12 * 12 *
13 * This library is distributed in the hope that it will be useful, 13 * This library is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16 * Library General Public License for more details. 16 * Library General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU Library General Public License 18 * You should have received a copy of the GNU Library General Public License
19 * along with this library; see the file COPYING.LIB. If not, write to 19 * along with this library; see the file COPYING.LIB. If not, write to
20 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 20 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
21 * Boston, MA 02110-1301, USA. 21 * Boston, MA 02110-1301, USA.
22 * 22 *
23 */ 23 */
24 24
25 #ifndef BorderValue_h 25 #ifndef BorderValue_h
26 #define BorderValue_h 26 #define BorderValue_h
27 27
28 #include "core/css/StyleColor.h" 28 #include "core/platform/graphics/Color.h"
29 #include "core/rendering/style/RenderStyleConstants.h" 29 #include "core/rendering/style/RenderStyleConstants.h"
30 30
31 namespace WebCore { 31 namespace WebCore {
32 32
33 class BorderValue { 33 class BorderValue {
34 friend class RenderStyle; 34 friend class RenderStyle;
35 public: 35 public:
36 BorderValue() 36 BorderValue()
37 : m_color(0) 37 : m_color(0)
38 , m_colorIsValid(false) 38 , m_colorIsValid(false)
39 , m_currentColor(false)
40 , m_width(3) 39 , m_width(3)
41 , m_style(BNONE) 40 , m_style(BNONE)
42 , m_isAuto(AUTO_OFF) 41 , m_isAuto(AUTO_OFF)
43 { 42 {
44 } 43 }
45 44
46 bool nonZero(bool checkStyle = true) const 45 bool nonZero(bool checkStyle = true) const
47 { 46 {
48 return width() && (!checkStyle || m_style != BNONE); 47 return width() && (!checkStyle || m_style != BNONE);
49 } 48 }
50 49
51 bool isTransparent() const 50 bool isTransparent() const
52 { 51 {
53 return m_colorIsValid && !m_currentColor && !m_color.alpha(); 52 return m_colorIsValid && !alphaChannel(m_color);
54 } 53 }
55 54
56 bool isVisible(bool checkStyle = true) const 55 bool isVisible(bool checkStyle = true) const
57 { 56 {
58 return nonZero(checkStyle) && !isTransparent() && (!checkStyle || m_styl e != BHIDDEN); 57 return nonZero(checkStyle) && !isTransparent() && (!checkStyle || m_styl e != BHIDDEN);
59 } 58 }
60 59
61 bool operator==(const BorderValue& o) const 60 bool operator==(const BorderValue& o) const
62 { 61 {
63 return m_width == o.m_width && m_style == o.m_style && m_color == o.m_co lor && m_colorIsValid == o.m_colorIsValid && m_currentColor == o.m_currentColor; 62 return m_width == o.m_width && m_style == o.m_style && m_color == o.m_co lor && m_colorIsValid == o.m_colorIsValid;
64 } 63 }
65 64
66 bool operator!=(const BorderValue& o) const 65 bool operator!=(const BorderValue& o) const
67 { 66 {
68 return !(*this == o); 67 return !(*this == o);
69 } 68 }
70 69
71 void setColor(const StyleColor& color) 70 void setColor(const Color& color)
72 { 71 {
73 m_color = color.color(); 72 m_color = color.rgb();
74 m_colorIsValid = color.isValid(); 73 m_colorIsValid = color.isValid();
75 m_currentColor = color.isCurrentColor();
76 } 74 }
77 75
78 StyleColor color() const { return StyleColor(m_color, m_colorIsValid, m_curr entColor); } 76 Color color() const { return Color(m_color, m_colorIsValid); }
79 77
80 unsigned width() const { return m_width; } 78 unsigned width() const { return m_width; }
81 EBorderStyle style() const { return static_cast<EBorderStyle>(m_style); } 79 EBorderStyle style() const { return static_cast<EBorderStyle>(m_style); }
82 80
83 protected: 81 protected:
84 Color m_color; 82 RGBA32 m_color;
85 unsigned m_colorIsValid : 1; 83 unsigned m_colorIsValid : 1;
86 unsigned m_currentColor : 1;
87 84
88 unsigned m_width : 25; 85 unsigned m_width : 26;
89 unsigned m_style : 4; // EBorderStyle 86 unsigned m_style : 4; // EBorderStyle
90 87
91 // This is only used by OutlineValue but moved here to keep the bits packed. 88 // This is only used by OutlineValue but moved here to keep the bits packed.
92 unsigned m_isAuto : 1; // OutlineIsAuto 89 unsigned m_isAuto : 1; // OutlineIsAuto
93 }; 90 };
94 91
95 } // namespace WebCore 92 } // namespace WebCore
96 93
97 #endif // BorderValue_h 94 #endif // BorderValue_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698