Source/core/html/HTMLElement.cpp - Issue 23581008: Revert r154797: "Move isValid/isCurrentColor from Color to StyleColor"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLElement.cpp

Issue 23581008: Revert r154797: "Move isValid/isCurrentColor from Color to StyleColor" (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLElement.cpp

diff --git a/Source/core/html/HTMLElement.cpp b/Source/core/html/HTMLElement.cpp

index 503fe07915439bf4f6c60b8bc49dedc0bc312079..8dfbcfa4a0e6ad8c4fb2db86822329bd2cde9ebd 100644

--- a/Source/core/html/HTMLElement.cpp

+++ b/Source/core/html/HTMLElement.cpp

@@ -1063,9 +1063,9 @@ void HTMLElement::addHTMLColorToStyle(MutableStylePropertySet* style, CSSPropert

return;

// If the string is a named CSS color or a 3/6-digit hex color, use that.

- StyleColor parsedColor(colorString);

+ Color parsedColor(colorString);

if (!parsedColor.isValid())

- parsedColor = parseColorStringWithCrazyLegacyRules(colorString);

+ parsedColor.setRGB(parseColorStringWithCrazyLegacyRules(colorString));

style->setProperty(propertyID, cssValuePool().createColorValue(parsedColor.rgb()));

}