Source/core/css/resolver/FilterOperationResolver.cpp - Issue 23581008: Revert r154797: "Move isValid/isCurrentColor from Color to StyleColor"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/FilterOperationResolver.cpp

Issue 23581008: Revert r154797: "Move isValid/isCurrentColor from Color to StyleColor" (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/css/resolver/ElementStyleResources.cpp ('k') | Source/core/css/resolver/MatchedPropertiesCache.cpp » ('j') | Source/core/rendering/style/RenderStyle.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/resolver/FilterOperationResolver.cpp

diff --git a/Source/core/css/resolver/FilterOperationResolver.cpp b/Source/core/css/resolver/FilterOperationResolver.cpp

index 14f56ee483e1e16572272535e91964afcab4ee89..39d0f95001ba6714fcb0da62395bcda6bbb3e54a 100644

--- a/Source/core/css/resolver/FilterOperationResolver.cpp

+++ b/Source/core/css/resolver/FilterOperationResolver.cpp

@@ -487,11 +487,11 @@ bool FilterOperationResolver::createFilterOperations(CSSValue* inValue, const Re

ShadowValue* item = static_cast<ShadowValue*>(cssValue);

IntPoint location(item->x->computeLength<int>(style, rootStyle, zoomFactor), item->y->computeLength<int>(style, rootStyle, zoomFactor));

int blur = item->blur ? item->blur->computeLength<int>(style, rootStyle, zoomFactor) : 0;

- StyleColor shadowColor;

+ Color shadowColor;

if (item->color)

- shadowColor = state.document().textLinkColors().colorFromPrimitiveValue(item->color.get());

+ shadowColor = state.document().textLinkColors().colorFromPrimitiveValue(item->color.get(), state.style()->visitedDependentColor(CSSPropertyColor));

- operations.operations().append(DropShadowFilterOperation::create(location, blur, shadowColor.isValid() ? shadowColor.color() : Color::transparent, operationType));

+ operations.operations().append(DropShadowFilterOperation::create(location, blur, shadowColor.isValid() ? shadowColor : Color::transparent, operationType));

break;

}

case CSSFilterValue::UnknownFilterOperation: