Source/core/html/track/TextTrackCueGeneric.cpp - Issue 23581008: Revert r154797: "Move isValid/isCurrentColor from Color to StyleColor"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/TextTrackCueGeneric.cpp

Issue 23581008: Revert r154797: "Move isValid/isCurrentColor from Color to StyleColor" (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/TextTrackCueGeneric.cpp

diff --git a/Source/core/html/track/TextTrackCueGeneric.cpp b/Source/core/html/track/TextTrackCueGeneric.cpp

index 5ea1db44c40d895fcd81ef964dec953f48267f0e..b80e67b7d9bf85c432193a43d2e500a6413913a1 100644

--- a/Source/core/html/track/TextTrackCueGeneric.cpp

+++ b/Source/core/html/track/TextTrackCueGeneric.cpp

@@ -73,10 +73,10 @@ void TextTrackCueGenericBoxElement::applyCSSProperties(const IntSize& videoSize)

setInlineStyleProperty(CSSPropertyHeight, size, CSSPrimitiveValue::CSS_PERCENTAGE);

}

- if (cue->foregroundColor().alpha())

+ if (cue->foregroundColor().isValid())

setInlineStyleProperty(CSSPropertyColor, cue->foregroundColor().serialized());

- if (cue->backgroundColor().alpha())

+ if (cue->backgroundColor().isValid())

cue->element()->setInlineStyleProperty(CSSPropertyBackgroundColor, cue->backgroundColor().serialized());

if (cue->getWritingDirection() == TextTrackCue::Horizontal)