Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 23190034: Remove code related to title directionality, we never used it (Closed)

Created:
7 years, 4 months ago by esprehn
Modified:
7 years, 4 months ago
Reviewers:
eseidel, ojan
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, f(malita), adamk+blink_chromium.org, pdr, Stephen Chennney, Nate Chapin, jeez, gavinp+loader_chromium.org, Evan Martin, Avi (use Gerrit), jeremy
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove code related to title directionality, we never used it The project to support text direction in the page title (and history items) was never completed and doesn't appear to work once we lazy attach in the parser. It's not clear why the style doesn't inherit properly down through the <head>, but once we lazy attach the style never gets there. Some day if Chromium decides to support text directions in titles we can resurrect this code and figure out how to make it work in a lazy attach world. BUG=27094 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -319 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/dom/title-directionality.html View 1 chunk +0 lines, -52 lines 0 comments Download
D LayoutTests/fast/dom/title-directionality-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/dom/title-directionality-removeChild.html View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/fast/dom/title-directionality-removeChild-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.h View 4 chunks +5 lines, -9 lines 0 comments Download
M Source/core/dom/Document.cpp View 6 chunks +22 lines, -25 lines 0 comments Download
M Source/core/html/HTMLTitleElement.h View 2 chunks +0 lines, -13 lines 0 comments Download
M Source/core/html/HTMLTitleElement.cpp View 3 chunks +2 lines, -52 lines 0 comments Download
M Source/core/loader/DocumentLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/loader/HistoryController.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/loader/HistoryController.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
D Source/core/platform/text/StringWithDirection.h View 1 chunk +0 lines, -79 lines 0 comments Download
M Source/core/svg/SVGTitleElement.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/testing/runner/TestRunner.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/testing/runner/TestRunner.cpp View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/testing/runner/WebTestProxy.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
esprehn
7 years, 4 months ago (2013-08-22 23:03:29 UTC) #1
eseidel
Odd. This was Evan's project (maybe avi's?) back when we did the Bidi sprint a ...
7 years, 4 months ago (2013-08-22 23:10:16 UTC) #2
esprehn
On 2013/08/22 23:10:16, eseidel wrote: > Odd. This was Evan's project (maybe avi's?) back when ...
7 years, 4 months ago (2013-08-22 23:11:46 UTC) #3
eseidel
lgtm OK.
7 years, 4 months ago (2013-08-22 23:13:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/23190034/1
7 years, 4 months ago (2013-08-22 23:13:35 UTC) #5
esprehn
On 2013/08/22 23:11:46, esprehn wrote: > On 2013/08/22 23:10:16, eseidel wrote: > > Odd. This ...
7 years, 4 months ago (2013-08-22 23:14:21 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-23 01:17:33 UTC) #7
Message was sent while issue was closed.
Change committed as 156607

Powered by Google App Engine
This is Rietveld 408576698