Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: Source/core/loader/HistoryController.cpp

Issue 23190034: Remove code related to title directionality, we never used it (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/HistoryController.h ('k') | Source/core/platform/text/StringWithDirection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/HistoryController.cpp
diff --git a/Source/core/loader/HistoryController.cpp b/Source/core/loader/HistoryController.cpp
index 2a93d71cf7bcf3717b2d4c632688cb9d0359a068..d07a446a178f4a9986dd7aac0adbcb5936779124 100644
--- a/Source/core/loader/HistoryController.cpp
+++ b/Source/core/loader/HistoryController.cpp
@@ -436,11 +436,10 @@ void HistoryController::setCurrentItem(HistoryItem* item)
m_currentItem = item;
}
-void HistoryController::setCurrentItemTitle(const StringWithDirection& title)
+void HistoryController::setCurrentItemTitle(const String& title)
{
if (m_currentItem)
- // FIXME: make use of title.direction() as well.
- m_currentItem->setTitle(title.string());
+ m_currentItem->setTitle(title);
}
bool HistoryController::currentItemShouldBeReplaced() const
« no previous file with comments | « Source/core/loader/HistoryController.h ('k') | Source/core/platform/text/StringWithDirection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698