Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: Source/testing/runner/WebTestProxy.cpp

Issue 23190034: Remove code related to title directionality, we never used it (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/testing/runner/TestRunner.cpp ('k') | Source/web/FrameLoaderClientImpl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1201 matching lines...) Expand 10 before | Expand all | Expand 10 after
1212 { 1212 {
1213 WebCString title8 = title.utf8(); 1213 WebCString title8 = title.utf8();
1214 1214
1215 if (m_testInterfaces->testRunner()->shouldDumpFrameLoadCallbacks()) { 1215 if (m_testInterfaces->testRunner()->shouldDumpFrameLoadCallbacks()) {
1216 printFrameDescription(m_delegate, frame); 1216 printFrameDescription(m_delegate, frame);
1217 m_delegate->printMessage(string(" - didReceiveTitle: ") + title8.data() + "\n"); 1217 m_delegate->printMessage(string(" - didReceiveTitle: ") + title8.data() + "\n");
1218 } 1218 }
1219 1219
1220 if (m_testInterfaces->testRunner()->shouldDumpTitleChanges()) 1220 if (m_testInterfaces->testRunner()->shouldDumpTitleChanges())
1221 m_delegate->printMessage(string("TITLE CHANGED: '") + title8.data() + "' \n"); 1221 m_delegate->printMessage(string("TITLE CHANGED: '") + title8.data() + "' \n");
1222
1223 m_testInterfaces->testRunner()->setTitleTextDirection(direction);
1224 } 1222 }
1225 1223
1226 void WebTestProxyBase::didChangeIcon(WebFrame* frame, WebIconURL::Type) 1224 void WebTestProxyBase::didChangeIcon(WebFrame* frame, WebIconURL::Type)
1227 { 1225 {
1228 if (m_testInterfaces->testRunner()->shouldDumpIconChanges()) { 1226 if (m_testInterfaces->testRunner()->shouldDumpIconChanges()) {
1229 printFrameDescription(m_delegate, frame); 1227 printFrameDescription(m_delegate, frame);
1230 m_delegate->printMessage(string(" - didChangeIcons\n")); 1228 m_delegate->printMessage(string(" - didChangeIcons\n"));
1231 } 1229 }
1232 } 1230 }
1233 1231
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
1487 1485
1488 void WebTestProxyBase::resetInputMethod() 1486 void WebTestProxyBase::resetInputMethod()
1489 { 1487 {
1490 // If a composition text exists, then we need to let the browser process 1488 // If a composition text exists, then we need to let the browser process
1491 // to cancel the input method's ongoing composition session. 1489 // to cancel the input method's ongoing composition session.
1492 if (m_webWidget) 1490 if (m_webWidget)
1493 m_webWidget->confirmComposition(); 1491 m_webWidget->confirmComposition();
1494 } 1492 }
1495 1493
1496 } 1494 }
OLDNEW
« no previous file with comments | « Source/testing/runner/TestRunner.cpp ('k') | Source/web/FrameLoaderClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698