Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: Source/core/svg/SVGTitleElement.cpp

Issue 23190034: Remove code related to title directionality, we never used it (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/platform/text/StringWithDirection.h ('k') | Source/testing/runner/TestRunner.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 26 matching lines...) Expand all
37 { 37 {
38 return adoptRef(new SVGTitleElement(tagName, document)); 38 return adoptRef(new SVGTitleElement(tagName, document));
39 } 39 }
40 40
41 Node::InsertionNotificationRequest SVGTitleElement::insertedInto(ContainerNode* rootParent) 41 Node::InsertionNotificationRequest SVGTitleElement::insertedInto(ContainerNode* rootParent)
42 { 42 {
43 SVGElement::insertedInto(rootParent); 43 SVGElement::insertedInto(rootParent);
44 if (!rootParent->inDocument()) 44 if (!rootParent->inDocument())
45 return InsertionDone; 45 return InsertionDone;
46 if (firstChild()) 46 if (firstChild())
47 // FIXME: does SVG have a title text direction? 47 document()->setTitleElement(textContent(), this);
48 document()->setTitleElement(StringWithDirection(textContent(), LTR), thi s);
49 return InsertionDone; 48 return InsertionDone;
50 } 49 }
51 50
52 void SVGTitleElement::removedFrom(ContainerNode* rootParent) 51 void SVGTitleElement::removedFrom(ContainerNode* rootParent)
53 { 52 {
54 SVGElement::removedFrom(rootParent); 53 SVGElement::removedFrom(rootParent);
55 if (rootParent->inDocument()) 54 if (rootParent->inDocument())
56 document()->removeTitle(this); 55 document()->removeTitle(this);
57 } 56 }
58 57
59 void SVGTitleElement::childrenChanged(bool changedByParser, Node* beforeChange, Node* afterChange, int childCountDelta) 58 void SVGTitleElement::childrenChanged(bool changedByParser, Node* beforeChange, Node* afterChange, int childCountDelta)
60 { 59 {
61 SVGElement::childrenChanged(changedByParser, beforeChange, afterChange, chil dCountDelta); 60 SVGElement::childrenChanged(changedByParser, beforeChange, afterChange, chil dCountDelta);
62 if (inDocument()) 61 if (inDocument())
63 // FIXME: does SVG have title text direction? 62 document()->setTitleElement(textContent(), this);
64 document()->setTitleElement(StringWithDirection(textContent(), LTR), thi s);
65 } 63 }
66 64
67 } 65 }
OLDNEW
« no previous file with comments | « Source/core/platform/text/StringWithDirection.h ('k') | Source/testing/runner/TestRunner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698