Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Unified Diff: Source/core/svg/SVGTitleElement.cpp

Issue 23190034: Remove code related to title directionality, we never used it (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/platform/text/StringWithDirection.h ('k') | Source/testing/runner/TestRunner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGTitleElement.cpp
diff --git a/Source/core/svg/SVGTitleElement.cpp b/Source/core/svg/SVGTitleElement.cpp
index e9e8232bf97288ab71fb8550d5cf9df375eb2c80..6f8c58589190605cf2ccd1295f19cfa186f12b2c 100644
--- a/Source/core/svg/SVGTitleElement.cpp
+++ b/Source/core/svg/SVGTitleElement.cpp
@@ -44,8 +44,7 @@ Node::InsertionNotificationRequest SVGTitleElement::insertedInto(ContainerNode*
if (!rootParent->inDocument())
return InsertionDone;
if (firstChild())
- // FIXME: does SVG have a title text direction?
- document()->setTitleElement(StringWithDirection(textContent(), LTR), this);
+ document()->setTitleElement(textContent(), this);
return InsertionDone;
}
@@ -60,8 +59,7 @@ void SVGTitleElement::childrenChanged(bool changedByParser, Node* beforeChange,
{
SVGElement::childrenChanged(changedByParser, beforeChange, afterChange, childCountDelta);
if (inDocument())
- // FIXME: does SVG have title text direction?
- document()->setTitleElement(StringWithDirection(textContent(), LTR), this);
+ document()->setTitleElement(textContent(), this);
}
}
« no previous file with comments | « Source/core/platform/text/StringWithDirection.h ('k') | Source/testing/runner/TestRunner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698