Remove code related to title directionality, we never used it

Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 1220 matching lines @@
     return Range::create(this, rangeCompliantPosition, rangeCompliantPosition);
 }
 
 /*
  * Performs three operations:
  *  1. Convert control characters to spaces
  *  2. Trim leading and trailing spaces
  *  3. Collapse internal whitespace.
  */
 template <typename CharacterType>
-static inline StringWithDirection canonicalizedTitle(Document* document, const StringWithDirection& titleWithDirection)
+static inline String canonicalizedTitle(Document* document, const String& title)
 {
-    const String& title = titleWithDirection.string();
     const CharacterType* characters = title.getCharacters<CharacterType>();
     unsigned length = title.length();
     unsigned i;
 
     StringBuffer<CharacterType> buffer(length);
     unsigned builderIndex = 0;
 
     // Skip leading spaces and leading characters that would convert to spaces
     for (i = 0; i < length; ++i) {
         CharacterType c = characters[i];
         if (!(c <= 0x20 || c == 0x7F))
             break;
     }
 
     if (i == length)
-        return StringWithDirection();
+        return String();
 
     // Replace control characters with spaces, and backslashes with currency symbols, and collapse whitespace.
     bool previousCharWasWS = false;
     for (; i < length; ++i) {
         CharacterType c = characters[i];
         if (c <= 0x20 || c == 0x7F || (WTF::Unicode::category(c) & (WTF::Unicode::Separator_Line | WTF::Unicode::Separator_Paragraph))) {
             if (previousCharWasWS)
                 continue;
             buffer[builderIndex++] = ' ';
             previousCharWasWS = true;
         } else {
             buffer[builderIndex++] = c;
             previousCharWasWS = false;
         }
     }
 
     // Strip trailing spaces
     while (builderIndex > 0) {
         --builderIndex;
         if (buffer[builderIndex] != ' ')
             break;
     }
 
     if (!builderIndex && buffer[builderIndex] == ' ')
-        return StringWithDirection();
+        return String();
 
     buffer.shrink(builderIndex + 1);
 
     // Replace the backslashes with currency symbols if the encoding requires it.
     document->displayBufferModifiedByEncoding(buffer.characters(), buffer.length());
 
-    return StringWithDirection(String::adopt(buffer), titleWithDirection.direction());
+    return String::adopt(buffer);
 }
 
-void Document::updateTitle(const StringWithDirection& title)
+void Document::updateTitle(const String& title)
 {
     if (m_rawTitle == title)
         return;
 
     m_rawTitle = title;
 
-    StringWithDirection oldTitle = m_title;
-    if (m_rawTitle.string().isEmpty())
-        m_title = StringWithDirection();
-    else {
-        if (m_rawTitle.string().is8Bit())
-            m_title = canonicalizedTitle<LChar>(this, m_rawTitle);
-        else
-            m_title = canonicalizedTitle<UChar>(this, m_rawTitle);
-    }
+    String oldTitle = m_title;
+    if (m_rawTitle.isEmpty())
+        m_title = String();
+    else if (m_rawTitle.is8Bit())
+        m_title = canonicalizedTitle<LChar>(this, m_rawTitle);
+    else
+        m_title = canonicalizedTitle<UChar>(this, m_rawTitle);
 
     if (!m_frame || oldTitle == m_title)
         return;
     m_frame->loader()->history()->setCurrentItemTitle(m_title);
     m_frame->loader()->client()->dispatchDidReceiveTitle(m_title);
 }
 
 void Document::setTitle(const String& title)
 {
     // Title set by JavaScript -- overrides any title elements.
     m_titleSetExplicitly = true;
     if (!isHTMLDocument() && !isXHTMLDocument())
         m_titleElement = 0;
     else if (!m_titleElement) {
         if (HTMLElement* headElement = head()) {
             m_titleElement = createElement(titleTag, false);
             headElement->appendChild(m_titleElement);
         }
     }
 
-    // The DOM API has no method of specifying direction, so assume LTR.
-    updateTitle(StringWithDirection(title, LTR));
+    updateTitle(title);
 
     if (m_titleElement) {
         ASSERT(isHTMLTitleElement(m_titleElement.get()));
         if (isHTMLTitleElement(m_titleElement.get()))
             toHTMLTitleElement(m_titleElement.get())->setText(title);
     }
 }
 
-void Document::setTitleElement(const StringWithDirection& title, Element* titleElement)
+void Document::setTitleElement(const String& title, Element* titleElement)
 {
     if (titleElement != m_titleElement) {
         if (m_titleElement || m_titleSetExplicitly)
             // Only allow the first title element to change the title -- others have no effect.
             return;
         m_titleElement = titleElement;
     }
 
     updateTitle(title);
 }
 
 void Document::removeTitle(Element* titleElement)
 {
     if (m_titleElement != titleElement)
         return;
 
     m_titleElement = 0;
     m_titleSetExplicitly = false;
 
+    // FIXME: This is broken for SVG.
     // Update title based on first title element in the head, if one exists.
     if (HTMLElement* headElement = head()) {
-        for (Node* e = headElement->firstChild(); e; e = e->nextSibling()) {
-            if (isHTMLTitleElement(e)) {
-                HTMLTitleElement* titleElement = toHTMLTitleElement(e);
-                setTitleElement(titleElement->textWithDirection(), titleElement);
-                break;
-            }
+        for (Element* element = headElement->firstElementChild(); element; element = element->nextElementSibling()) {
+            if (!isHTMLTitleElement(element))
+                continue;
+            HTMLTitleElement* title = toHTMLTitleElement(element);
+            setTitleElement(title->text(), title);
+            break;
         }
     }
 
     if (!m_titleElement)
-        updateTitle(StringWithDirection());
+        updateTitle(String());
 }
 
 PageVisibilityState Document::visibilityState() const
 {
     // The visibility of the document is inherited from the visibility of the
     // page. If there is no page associated with the document, we will assume
     // that the page is hidden, as specified by the spec:
     // http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html#dom-document-hidden
     if (!m_frame || !m_frame->page())
         return PageVisibilityStateHidden;
@@ skipping 3859 matching lines @@
 {
     return DocumentLifecycleNotifier::create(this);
 }
 
 DocumentLifecycleNotifier* Document::lifecycleNotifier()
 {
     return static_cast<DocumentLifecycleNotifier*>(ScriptExecutionContext::lifecycleNotifier());
 }
 
 } // namespace WebCore