Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: Source/core/dom/Document.h

Issue 23190034: Remove code related to title directionality, we never used it (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.h
diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h
index f0145ded2326ec50528165feb74a7bf259f0d867..a64d351294f47abb69d70340dbaef8a03d272bb9 100644
--- a/Source/core/dom/Document.h
+++ b/Source/core/dom/Document.h
@@ -48,7 +48,6 @@
#include "core/page/PageVisibilityState.h"
#include "weborigin/ReferrerPolicy.h"
#include "core/platform/Timer.h"
-#include "core/platform/text/StringWithDirection.h"
#include "core/rendering/HitTestRequest.h"
#include "wtf/Deque.h"
#include "wtf/HashSet.h"
@@ -762,14 +761,11 @@ public:
HTMLIFrameElement* seamlessParentIFrame() const;
bool shouldDisplaySeamlesslyWithParent() const;
- // Used by DOM bindings; no direction known.
- String title() const { return m_title.string(); }
+ String title() const { return m_title; }
void setTitle(const String&);
- const StringWithDirection& titleWithDirection() const { return m_title; }
-
Element* titleElement() const { return m_titleElement.get(); }
- void setTitleElement(const StringWithDirection&, Element* titleElement);
+ void setTitleElement(const String& title, Element* titleElement);
void removeTitle(Element* titleElement);
String cookie(ExceptionState&) const;
@@ -1109,7 +1105,7 @@ private:
virtual double timerAlignmentInterval() const;
- void updateTitle(const StringWithDirection&);
+ void updateTitle(const String&);
void updateFocusAppearanceTimerFired(Timer<Document>*);
void updateBaseURL();
@@ -1249,8 +1245,8 @@ private:
// http://www.whatwg.org/specs/web-apps/current-work/#ignore-destructive-writes-counter
unsigned m_ignoreDestructiveWriteCount;
- StringWithDirection m_title;
- StringWithDirection m_rawTitle;
+ String m_title;
+ String m_rawTitle;
bool m_titleSetExplicitly;
RefPtr<Element> m_titleElement;
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698