Revert CompressibleString (and its UMA)

Revert CompressibleString (and its UMA)

This CL is basically revert of crrev/1583263002. Though
CompressibleString is promissing to reduce much memory usage, we are not
ready to use this yet for a while. The current implementation of
CompressibleString is mock and does virtually nothing, but makes the
code complicated unnecessarily. We remove it once and we'll land
CompressibleString again when the time comes.

BUG=574317
TEST=wtf_unittests

Committed: https://crrev.com/62f9bf90d67be3a8b3c89e15a21504b767c3357d
Cr-Commit-Position: refs/heads/master@{#411029}

[hajimehoshi, 2016-08-09 07:33:50]

hajimehoshi@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, isherman@chromium.org

[hajimehoshi, 2016-08-09 07:33:51]

PTAL

[haraken, 2016-08-09 07:36:15]

Yeah, we don't have any immediate plan to use CompressibleString (for a couple
of complicated reasons), it would make sense to revert the CL for now. Thanks
for understanding!

LGTM.

[hajimehoshi, 2016-08-09 07:40:12]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 07:40:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 12:54:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 12:54:30]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-08-09 19:15:19]

https://codereview.chromium.org/2227933002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2227933002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:23616: -   
enum="CompressibleStringCountType">
Please mark this histogram as <obsolete> rather than removing it.

[esprehn, 2016-08-10 04:06:21]

lgtm w/ the histogram fixed per isherman

[hajimehoshi, 2016-08-10 06:08:50]

Description was changed from

==========
Revert CompressibleString (and its UMA)

This CL is basically revert of crrev/1583263002. Though
CompressibleString is promissing to reduce much memory usage, we are not
ready to use this yet for a while. The current implementation of
CompressibleString is mock and does virtually nothing, but makes the
code complicated unnecessarily. We remove it once and we'll land
CompressibleString again when the time comes.

BUG=n/a
TEST=wtf_unittests
==========

to

==========
Revert CompressibleString (and its UMA)

This CL is basically revert of crrev/1583263002. Though
CompressibleString is promissing to reduce much memory usage, we are not
ready to use this yet for a while. The current implementation of
CompressibleString is mock and does virtually nothing, but makes the
code complicated unnecessarily. We remove it once and we'll land
CompressibleString again when the time comes.

BUG=574317
TEST=wtf_unittests
==========

[hajimehoshi, 2016-08-10 06:17:34]

Thank you!

https://codereview.chromium.org/2227933002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2227933002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:23616: -   
enum="CompressibleStringCountType">
On 2016/08/09 19:15:19, Ilya Sherman wrote:
> Please mark this histogram as <obsolete> rather than removing it.

Done.

[hajimehoshi, 2016-08-10 06:18:22]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 06:19:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2016-08-10 06:19:49]

histograms.xml lgtm, thanks.

[hajimehoshi, 2016-08-10 06:48:21]

The CQ bit was unchecked by hajimehoshi@chromium.org

[hajimehoshi, 2016-08-10 06:48:23]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2016-08-10 06:48:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2227933002/#ps20001
(title: "Address on Ilya's review")

[commit-bot: I haz the power, 2016-08-10 06:48:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 10:11:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 10:11:04]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hajimehoshi, 2016-08-10 10:16:44]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2016-08-10 10:16:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 12:53:59]

Description was changed from

==========
Revert CompressibleString (and its UMA)

This CL is basically revert of crrev/1583263002. Though
CompressibleString is promissing to reduce much memory usage, we are not
ready to use this yet for a while. The current implementation of
CompressibleString is mock and does virtually nothing, but makes the
code complicated unnecessarily. We remove it once and we'll land
CompressibleString again when the time comes.

BUG=574317
TEST=wtf_unittests
==========

to

==========
Revert CompressibleString (and its UMA)

This CL is basically revert of crrev/1583263002. Though
CompressibleString is promissing to reduce much memory usage, we are not
ready to use this yet for a while. The current implementation of
CompressibleString is mock and does virtually nothing, but makes the
code complicated unnecessarily. We remove it once and we'll land
CompressibleString again when the time comes.

BUG=574317
TEST=wtf_unittests
==========

[commit-bot: I haz the power, 2016-08-10 12:54:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-10 12:55:30]

Description was changed from

==========
Revert CompressibleString (and its UMA)

This CL is basically revert of crrev/1583263002. Though
CompressibleString is promissing to reduce much memory usage, we are not
ready to use this yet for a while. The current implementation of
CompressibleString is mock and does virtually nothing, but makes the
code complicated unnecessarily. We remove it once and we'll land
CompressibleString again when the time comes.

BUG=574317
TEST=wtf_unittests
==========

to

==========
Revert CompressibleString (and its UMA)

This CL is basically revert of crrev/1583263002. Though
CompressibleString is promissing to reduce much memory usage, we are not
ready to use this yet for a while. The current implementation of
CompressibleString is mock and does virtually nothing, but makes the
code complicated unnecessarily. We remove it once and we'll land
CompressibleString again when the time comes.

BUG=574317
TEST=wtf_unittests

Committed: https://crrev.com/62f9bf90d67be3a8b3c89e15a21504b767c3357d
Cr-Commit-Position: refs/heads/master@{#411029}
==========

[commit-bot: I haz the power, 2016-08-10 12:55:32]

Patchset 2 (id:??) landed as
https://crrev.com/62f9bf90d67be3a8b3c89e15a21504b767c3357d
Cr-Commit-Position: refs/heads/master@{#411029}