third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.h - Issue 2227933002: Revert CompressibleString (and its UMA)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.h

Issue 2227933002: Revert CompressibleString (and its UMA) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address on Ilya's review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.h b/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.h

index e2c8914e93ef6c8f401e9f2e4343a013228a663f..1c6d97a0035a194513be3d270de72c9a391b0ac6 100644

--- a/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.h

+++ b/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.h

@@ -36,7 +36,6 @@

#include "bindings/core/v8/V8Binding.h"

#include "bindings/core/v8/V8CacheOptions.h"

#include "core/CoreExport.h"

-#include "platform/text/CompressibleString.h"

#include "wtf/Allocator.h"

#include "wtf/ThreadingPrimitives.h"

#include "wtf/text/TextPosition.h"

@@ -97,7 +96,7 @@ private:

class ExecutionState;

// Evaluate a script file in the current execution environment.

- ScriptValue evaluate(const CompressibleString& script, const String& fileName, const TextPosition& scriptStartPosition, CachedMetadataHandler*, V8CacheOptions);

+ ScriptValue evaluate(const String& script, const String& fileName, const TextPosition& scriptStartPosition, CachedMetadataHandler*, V8CacheOptions);

void disposeContextIfNeeded();

Member<WorkerOrWorkletGlobalScope> m_globalScope;