Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2227933002: Revert CompressibleString (and its UMA) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address on Ilya's review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/page/Page.h ('k') | third_party/WebKit/Source/platform/blink_platform.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/Page.cpp
diff --git a/third_party/WebKit/Source/core/page/Page.cpp b/third_party/WebKit/Source/core/page/Page.cpp
index 4e2a89a2e20ff22690e5f00de814170cd6d4b0ce..8198308fd1f45232f1f79a37841497abd27e5c05 100644
--- a/third_party/WebKit/Source/core/page/Page.cpp
+++ b/third_party/WebKit/Source/core/page/Page.cpp
@@ -52,7 +52,6 @@
#include "core/paint/PaintLayer.h"
#include "platform/graphics/GraphicsLayer.h"
#include "platform/plugins/PluginData.h"
-#include "platform/text/CompressibleString.h"
#include "public/platform/Platform.h"
namespace blink {
@@ -133,7 +132,6 @@ Page::Page(PageClients& pageClients)
, m_isPainting(false)
#endif
, m_frameHost(FrameHost::create(*this))
- , m_timerForCompressStrings(this, &Page::compressStrings)
{
ASSERT(m_editorClient);
@@ -320,8 +318,6 @@ void Page::visitedStateChanged(LinkHash linkHash)
void Page::setVisibilityState(PageVisibilityState visibilityState, bool isInitialState)
{
- static const double waitingTimeBeforeCompressingString = 10;
-
if (m_visibilityState == visibilityState)
return;
m_visibilityState = visibilityState;
@@ -331,15 +327,6 @@ void Page::setVisibilityState(PageVisibilityState visibilityState, bool isInitia
if (!isInitialState && m_mainFrame)
m_mainFrame->didChangeVisibilityState();
-
- // Compress CompressibleStrings when 10 seconds have passed since the page
- // went to background.
- if (m_visibilityState == PageVisibilityStateHidden) {
- if (!m_timerForCompressStrings.isActive())
- m_timerForCompressStrings.startOneShot(waitingTimeBeforeCompressingString, BLINK_FROM_HERE);
- } else if (m_timerForCompressStrings.isActive()) {
- m_timerForCompressStrings.stop();
- }
}
PageVisibilityState Page::visibilityState() const
@@ -536,13 +523,6 @@ void Page::willBeDestroyed()
PageVisibilityNotifier::notifyContextDestroyed();
}
-void Page::compressStrings(TimerBase* timer)
-{
- ASSERT_UNUSED(timer, timer == &m_timerForCompressStrings);
- if (m_visibilityState == PageVisibilityStateHidden)
- CompressibleStringImpl::compressAll();
-}
-
Page::PageClients::PageClients()
: chromeClient(nullptr)
, contextMenuClient(nullptr)
« no previous file with comments | « third_party/WebKit/Source/core/page/Page.h ('k') | third_party/WebKit/Source/platform/blink_platform.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698