third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h - Issue 2227933002: Revert CompressibleString (and its UMA)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

Issue 2227933002: Revert CompressibleString (and its UMA) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address on Ilya's review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8Binding.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

index d984a14b4a8cb8a71beae6376e42f5e3f7408af8..7e3b532277e8fb3c9bbeac5a85eed156015d9bc2 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

@@ -32,7 +32,6 @@

#include "bindings/core/v8/V8CacheOptions.h"

#include "core/CoreExport.h"

#include "core/fetch/AccessControlStatus.h"

-#include "platform/text/CompressibleString.h"

#include "wtf/Allocator.h"

#include "wtf/text/TextPosition.h"

#include "wtf/text/WTFString.h"

@@ -53,7 +52,7 @@ public:

// For the following methods, the caller sites have to hold

// a HandleScope and a ContextScope.

static v8::MaybeLocal<v8::Script> compileScript(const ScriptSourceCode&, v8::Isolate*, AccessControlStatus = SharableCrossOrigin, V8CacheOptions = V8CacheOptionsDefault);

- static v8::MaybeLocal<v8::Script> compileScript(const CompressibleString&, const String& fileName, const String& sourceMapUrl, const TextPosition&, v8::Isolate*, CachedMetadataHandler* = nullptr, AccessControlStatus = SharableCrossOrigin, V8CacheOptions = V8CacheOptionsDefault);

+ static v8::MaybeLocal<v8::Script> compileScript(const String&, const String& fileName, const String& sourceMapUrl, const TextPosition&, v8::Isolate*, CachedMetadataHandler* = nullptr, AccessControlStatus = SharableCrossOrigin, V8CacheOptions = V8CacheOptionsDefault);

// CachedMetadataHandler is set when metadata caching is supported. For

// normal scripe resources, CachedMetadataHandler is from ScriptResource.

// For worker script, ScriptResource is null but CachedMetadataHandler may be