Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp

Issue 2227933002: Revert CompressibleString (and its UMA) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address on Ilya's review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp
index be6b8d825c2b2202cdd7e538920470c9d0eebc88..f7eb12a3ba883e46a245fbd9b28179bee327ab21 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp
@@ -12,11 +12,6 @@ ScriptSourceCode::ScriptSourceCode()
}
ScriptSourceCode::ScriptSourceCode(const String& source, const KURL& url, const TextPosition& startPosition)
- : ScriptSourceCode(CompressibleString(source.impl()), url, startPosition)
-{
-}
-
-ScriptSourceCode::ScriptSourceCode(const CompressibleString& source, const KURL& url, const TextPosition& startPosition)
: m_source(source)
, m_url(url)
, m_startPosition(startPosition)
@@ -86,7 +81,7 @@ void ScriptSourceCode::treatNullSourceAsEmpty()
// the empty script. Consequently, we need to disambiguate between such null string occurrences.
// Do that by converting the latter case's null strings into empty ones.
if (m_source.isNull())
- m_source = CompressibleString();
+ m_source = "";
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698