Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h

Issue 2227933002: Revert CompressibleString (and its UMA) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address on Ilya's review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h b/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h
index 0347d2eba9e1f34b955fd54776be73f3daa3961e..8cc69e08af02de93016cb9fa374352c1e7af602b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h
@@ -49,7 +49,6 @@ public:
// Not sure if that matters.
explicit ScriptSourceCode(ScriptResource*);
ScriptSourceCode(const String&, const KURL& = KURL(), const TextPosition& startPosition = TextPosition::minimumPosition());
- ScriptSourceCode(const CompressibleString&, const KURL& = KURL(), const TextPosition& startPosition = TextPosition::minimumPosition());
ScriptSourceCode(ScriptStreamer*, ScriptResource*);
~ScriptSourceCode();
@@ -61,7 +60,7 @@ public:
// constructor, and differs from the empty script.
bool isNull() const { return m_source.isNull(); }
- const CompressibleString& source() const { return m_source; }
+ const String& source() const { return m_source; }
ScriptResource* resource() const { return m_resource.get(); }
const KURL& url() const;
int startLine() const { return m_startPosition.m_line.oneBasedInt(); }
@@ -73,7 +72,7 @@ public:
private:
void treatNullSourceAsEmpty();
- CompressibleString m_source;
+ String m_source;
Member<ScriptResource> m_resource;
Member<ScriptStreamer> m_streamer;
mutable KURL m_url;
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698