third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp - Issue 2227933002: Revert CompressibleString (and its UMA)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp

Issue 2227933002: Revert CompressibleString (and its UMA) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address on Ilya's review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp b/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp

index b58829e5008996f897f9ae9aebba9a7fd4abb1c3..d386b09772fd3a37dede8b2a6a2ab7cb38240e48 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp

@@ -435,7 +435,7 @@ void HTMLScriptRunner::runScript(Element* script, const TextPosition& scriptStar

} else {

ASSERT(m_scriptNestingLevel > 1);

m_parserBlockingScript->releaseElementAndClear();

- ScriptSourceCode sourceCode(CompressibleString(script->textContent().impl()), documentURLForScriptExecution(m_document), scriptStartPosition);

+ ScriptSourceCode sourceCode(script->textContent(), documentURLForScriptExecution(m_document), scriptStartPosition);

doExecuteScript(script, sourceCode, scriptStartPosition);

}

} else {