Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 13106002: [NaCl SDK] A bunch of spelling fixes. (Closed)

Created:
7 years, 9 months ago by binji
Modified:
7 years, 9 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] A bunch of spelling fixes. Also, removed set_nacl_env.py from sdk_tools directory. It is unused. BUG=none R=sbc@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190994

Patch Set 1 #

Patch Set 2 : fix presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -565 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/generate_make.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/library.mk View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/make_simple.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/manifest_util.py View 2 chunks +2 lines, -2 lines 0 comments Download
D native_client_sdk/src/build_tools/sdk_tools/set_nacl_env.py View 1 chunk +0 lines, -492 lines 0 comments Download
M native_client_sdk/src/build_tools/template.mk View 3 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/examples/debugging/string_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/dlopen/dlopen.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/file_histogram/file_histogram.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/file_io/file_io.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/fullscreen_tumbler/cube.h View 1 chunk +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/examples/fullscreen_tumbler/cube.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/fullscreen_tumbler/opengl_context.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/fullscreen_tumbler/opengl_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/fullscreen_tumbler/transforms.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/fullscreen_tumbler/tumbler.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/geturl/geturl_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/examples/hello_nacl_io/queue.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/hello_world_gles/hello_world.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/hello_world_gles/matrix.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/hello_world_instance3d/matrix.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/hello_world_interactive/hello_world.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/mouselock/index.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/examples/mouselock/mouselock.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/pi_generator/pi_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/pong/pong_model.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/gtest_ppapi/gtest_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/gtest_ppapi/thread_condition.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_object.h View 3 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_object.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_mem.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/path.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/path.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/kernel_object_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_main/ppapi_event.h View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_main/ppapi_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_main/ppapi_instance3d.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_main/ppapi_queue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_main/ppapi_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/utils/macros.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tools/decode_dump.py View 1 3 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/tools/getos.py View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/tools/oshelpers.py View 3 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/tools/tests/create_nmf_test.py View 3 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/tools/tests/getos_test.py View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
binji
7 years, 9 months ago (2013-03-26 23:48:10 UTC) #1
Sam Clegg
lgtm
7 years, 9 months ago (2013-03-27 00:32:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/13106002/1
7 years, 9 months ago (2013-03-27 00:55:38 UTC) #3
commit-bot: I haz the power
Presubmit check for 13106002-1 failed and returned exit status 1. INFO:root:Found 46 file(s). INFO:PRESUBMIT:Running pylint ...
7 years, 9 months ago (2013-03-27 00:56:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/13106002/5001
7 years, 9 months ago (2013-03-27 18:59:23 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-27 19:02:13 UTC) #6
Message was sent while issue was closed.
Change committed as 190994

Powered by Google App Engine
This is Rietveld 408576698