Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11392004: Remove TabContents from AddBlankTabAt, kill AddBlankTab. (Closed)

Created:
8 years, 1 month ago by Avi (use Gerrit)
Modified:
8 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, tfarina, kkania, marja+watch_chromium.org, robertshield, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Remove TabContents from AddBlankTabAt, kill AddBlankTab. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166631

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -55 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui_default.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_focus_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_tab_strip_model_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/browser_tab_strip_model_delegate.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser_tabstrip.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_tabstrip.cc View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/tabs/test_tab_strip_model_delegate.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/tabs/test_tab_strip_model_delegate.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/ui/views/frame/app_non_client_frame_view_ash_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
8 years, 1 month ago (2012-11-07 23:04:13 UTC) #1
sky
LGTM
8 years, 1 month ago (2012-11-08 01:02:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11392004/1
8 years, 1 month ago (2012-11-08 03:51:36 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-08 07:30:12 UTC) #4 
Change committed as 166631

Powered by Google App Engine
This is Rietveld 408576698