Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5043)

Unified Diff: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Issue 11392004: Remove TabContents from AddBlankTabAt, kill AddBlankTab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm ('k') | chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
diff --git a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
index 23c9fbd54a94798e65305f222f13cf984aeb98fe..8aba20b078d7bc9d5a2a54c95c8debd0d1687617 100644
--- a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
+++ b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
@@ -1141,7 +1141,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, PreferPreviousSearch) {
// For some reason we can't use AddSelectedTabWithURL here on ChromeOS. It
// could be some delicate assumption about the tab starting off unselected or
// something relating to user gesture.
- chrome::AddBlankTab(browser(), true);
+ chrome::AddBlankTabAt(browser(), -1, true);
ui_test_utils::NavigateToURL(browser(), url);
WebContents* web_contents_2 = chrome::GetActiveWebContents(browser());
EXPECT_NE(web_contents_1, web_contents_2);
@@ -1264,7 +1264,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, PrepopulatePreserveLast) {
FindBarController::kKeepResultsInFindBox);
// Now create a second tab and load the same page.
- chrome::AddBlankTab(browser(), true);
+ chrome::AddBlankTabAt(browser(), -1, true);
ui_test_utils::NavigateToURL(browser(), url);
WebContents* web_contents_2 = chrome::GetActiveWebContents(browser());
EXPECT_NE(web_contents_1, web_contents_2);
« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm ('k') | chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698