Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3153)

Unified Diff: chrome/browser/ui/browser_tabstrip.cc

Issue 11392004: Remove TabContents from AddBlankTabAt, kill AddBlankTab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_tabstrip.h ('k') | chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_tabstrip.cc
diff --git a/chrome/browser/ui/browser_tabstrip.cc b/chrome/browser/ui/browser_tabstrip.cc
index e8200509bd007d3cf2af0c3717c1e02f9d4ae042..d060db9f9d88bb6acc6a5b133bbbeb90619f6c67 100644
--- a/chrome/browser/ui/browser_tabstrip.cc
+++ b/chrome/browser/ui/browser_tabstrip.cc
@@ -55,11 +55,7 @@ void ActivateTabAt(Browser* browser, int index, bool user_gesture) {
browser->tab_strip_model()->ActivateTabAt(index, user_gesture);
}
-TabContents* AddBlankTab(Browser* browser, bool foreground) {
- return AddBlankTabAt(browser, -1, foreground);
-}
-
-TabContents* AddBlankTabAt(Browser* browser, int index, bool foreground) {
+void AddBlankTabAt(Browser* browser, int index, bool foreground) {
// Time new tab page creation time. We keep track of the timing data in
// WebContents, but we want to include the time it takes to create the
// WebContents object too.
@@ -71,7 +67,6 @@ TabContents* AddBlankTabAt(Browser* browser, int index, bool foreground) {
chrome::Navigate(&params);
params.target_contents->web_contents()->SetNewTabStartTime(
new_tab_start_time);
- return params.target_contents;
}
bool IsTabStripEditable(Browser* browser) {
« no previous file with comments | « chrome/browser/ui/browser_tabstrip.h ('k') | chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698