Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 11392004: Remove TabContents from AddBlankTabAt, kill AddBlankTab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/browser_focus_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index e46af6e9f5367e2465c934645958a85f6c59be3b..d5f3744129222c0f90b6ebd6e6f183ab6a438ca8 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -308,7 +308,7 @@ void NewEmptyWindow(Profile* profile) {
Browser* OpenEmptyWindow(Profile* profile, HostDesktopType desktop_type) {
Browser* browser = new Browser(
Browser::CreateParams(Browser::TYPE_TABBED, profile, desktop_type));
- AddBlankTab(browser, true);
+ AddBlankTabAt(browser, -1, true);
browser->window()->Show();
return browser;
}
@@ -473,15 +473,15 @@ void NewTab(Browser* browser) {
TabStripModel::NEW_TAB_ENUM_COUNT);
if (browser->is_type_tabbed()) {
- AddBlankTab(browser, true);
+ AddBlankTabAt(browser, -1, true);
GetActiveWebContents(browser)->GetView()->RestoreFocus();
} else {
Browser* b =
browser::FindOrCreateTabbedBrowser(browser->profile(),
browser->host_desktop_type());
- AddBlankTab(b, true);
+ AddBlankTabAt(b, -1, true);
b->window()->Show();
- // The call to AddBlankTab above did not set the focus to the tab as its
+ // The call to AddBlankTabAt above did not set the focus to the tab as its
// window was not active, so we have to do it explicitly.
// See http://crbug.com/6380.
GetActiveWebContents(b)->GetView()->RestoreFocus();
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/browser_focus_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698