Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: chrome/browser/ui/browser_tab_strip_model_delegate.cc

Issue 11392004: Remove TabContents from AddBlankTabAt, kill AddBlankTab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_tab_strip_model_delegate.h" 5 #include "chrome/browser/ui/browser_tab_strip_model_delegate.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/sessions/tab_restore_service.h" 10 #include "chrome/browser/sessions/tab_restore_service.h"
(...skipping 22 matching lines...) Expand all
33 : browser_(browser), 33 : browser_(browser),
34 ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) { 34 ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) {
35 } 35 }
36 36
37 BrowserTabStripModelDelegate::~BrowserTabStripModelDelegate() { 37 BrowserTabStripModelDelegate::~BrowserTabStripModelDelegate() {
38 } 38 }
39 39
40 //////////////////////////////////////////////////////////////////////////////// 40 ////////////////////////////////////////////////////////////////////////////////
41 // BrowserTabStripModelDelegate, TabStripModelDelegate implementation: 41 // BrowserTabStripModelDelegate, TabStripModelDelegate implementation:
42 42
43 TabContents* BrowserTabStripModelDelegate::AddBlankTab(bool foreground) { 43 void BrowserTabStripModelDelegate::AddBlankTabAt(int index, bool foreground) {
44 return chrome::AddBlankTab(browser_, foreground); 44 chrome::AddBlankTabAt(browser_, index, foreground);
45 }
46
47 TabContents* BrowserTabStripModelDelegate::AddBlankTabAt(int index,
48 bool foreground) {
49 return chrome::AddBlankTabAt(browser_, index, foreground);
50 } 45 }
51 46
52 Browser* BrowserTabStripModelDelegate::CreateNewStripWithContents( 47 Browser* BrowserTabStripModelDelegate::CreateNewStripWithContents(
53 const std::vector<NewStripContents>& contentses, 48 const std::vector<NewStripContents>& contentses,
54 const gfx::Rect& window_bounds, 49 const gfx::Rect& window_bounds,
55 const DockInfo& dock_info, 50 const DockInfo& dock_info,
56 bool maximize) { 51 bool maximize) {
57 DCHECK(browser_->CanSupportWindowFeature(Browser::FEATURE_TABSTRIP)); 52 DCHECK(browser_->CanSupportWindowFeature(Browser::FEATURE_TABSTRIP));
58 53
59 gfx::Rect new_window_bounds = window_bounds; 54 gfx::Rect new_window_bounds = window_bounds;
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 } 166 }
172 167
173 //////////////////////////////////////////////////////////////////////////////// 168 ////////////////////////////////////////////////////////////////////////////////
174 // BrowserTabStripModelDelegate, private: 169 // BrowserTabStripModelDelegate, private:
175 170
176 void BrowserTabStripModelDelegate::CloseFrame() { 171 void BrowserTabStripModelDelegate::CloseFrame() {
177 browser_->window()->Close(); 172 browser_->window()->Close();
178 } 173 }
179 174
180 } // namespace chrome 175 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_tab_strip_model_delegate.h ('k') | chrome/browser/ui/browser_tabstrip.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698