Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: chrome/browser/ui/browser_tabstrip.h

Issue 11392004: Remove TabContents from AddBlankTabAt, kill AddBlankTab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_TABSTRIP_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_TABSTRIP_H_
6 #define CHROME_BROWSER_UI_BROWSER_TABSTRIP_H_ 6 #define CHROME_BROWSER_UI_BROWSER_TABSTRIP_H_
7 7
8 #include "content/public/common/page_transition_types.h" 8 #include "content/public/common/page_transition_types.h"
9 #include "content/public/browser/navigation_controller.h" 9 #include "content/public/browser/navigation_controller.h"
10 #include "webkit/glue/window_open_disposition.h" 10 #include "webkit/glue/window_open_disposition.h"
(...skipping 17 matching lines...) Expand all
28 int GetIndexOfTab(const Browser* browser, const content::WebContents* contents); 28 int GetIndexOfTab(const Browser* browser, const content::WebContents* contents);
29 29
30 TabContents* GetActiveTabContents(const Browser* browser); 30 TabContents* GetActiveTabContents(const Browser* browser);
31 content::WebContents* GetActiveWebContents(const Browser* browser); 31 content::WebContents* GetActiveWebContents(const Browser* browser);
32 32
33 TabContents* GetTabContentsAt(const Browser* browser, int index); 33 TabContents* GetTabContentsAt(const Browser* browser, int index);
34 content::WebContents* GetWebContentsAt(const Browser* browser, int index); 34 content::WebContents* GetWebContentsAt(const Browser* browser, int index);
35 35
36 void ActivateTabAt(Browser* browser, int index, bool user_gesture); 36 void ActivateTabAt(Browser* browser, int index, bool user_gesture);
37 37
38 TabContents* AddBlankTab(Browser* browser, bool foreground); 38 // Adds a blank tab to the tab strip of the specified browser; an |index| of -1
39 TabContents* AddBlankTabAt(Browser* browser, int index, bool foreground); 39 // means to append it to the end of the tab strip.
40 void AddBlankTabAt(Browser* browser, int index, bool foreground);
40 41
41 // Used by extensions. 42 // Used by extensions.
42 bool IsTabStripEditable(Browser* browser); 43 bool IsTabStripEditable(Browser* browser);
43 44
44 // Adds a selected tab with the specified URL and transition, returns the 45 // Adds a selected tab with the specified URL and transition, returns the
45 // created TabContents. 46 // created TabContents.
46 TabContents* AddSelectedTabWithURL(Browser* browser, 47 TabContents* AddSelectedTabWithURL(Browser* browser,
47 const GURL& url, 48 const GURL& url,
48 content::PageTransition transition); 49 content::PageTransition transition);
49 50
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 TabContents* TabContentsWithSessionStorageFactory( 88 TabContents* TabContentsWithSessionStorageFactory(
88 Profile* profile, 89 Profile* profile,
89 content::SiteInstance* site_instance, 90 content::SiteInstance* site_instance,
90 int routing_id, 91 int routing_id,
91 const content::WebContents* base_web_contents, 92 const content::WebContents* base_web_contents,
92 const content::SessionStorageNamespaceMap& session_storage_namespace_map); 93 const content::SessionStorageNamespaceMap& session_storage_namespace_map);
93 94
94 } // namespace chrome 95 } // namespace chrome
95 96
96 #endif // CHROME_BROWSER_UI_BROWSER_TABSTRIP_H_ 97 #endif // CHROME_BROWSER_UI_BROWSER_TABSTRIP_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_tab_strip_model_delegate.cc ('k') | chrome/browser/ui/browser_tabstrip.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698