Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10868089: add PRESUBMIT for native_client_sdk. (Closed)

Created:
8 years, 4 months ago by Sam Clegg
Modified:
8 years, 3 months ago
Reviewers:
noelallen1, binji
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

add PRESUBMIT for native_client_sdk. Currently just does pylint. Fix many obvious lint errors (but not all by any means). BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154856

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -115 lines) Patch
A native_client_sdk/PRESUBMIT.py View 1 chunk +46 lines, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 3 chunks +10 lines, -11 lines 0 comments Download
M native_client_sdk/src/build_tools/build_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/make_rules.py View 5 chunks +7 lines, -3 lines 0 comments Download
M native_client_sdk/src/build_tools/manifest_util.py View 2 chunks +5 lines, -5 lines 0 comments Download
M native_client_sdk/src/build_tools/nacl-mono-buildbot.py View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_tools/sdk_update.py View 2 chunks +6 lines, -7 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_tools/sdk_update_common.py View 5 chunks +6 lines, -4 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py View 7 chunks +13 lines, -12 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_tools/set_nacl_env.py View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/sdk_tools/update_manifest.py View 4 chunks +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/build_tools/update_nacl_manifest.py View 5 chunks +6 lines, -6 lines 0 comments Download
M native_client_sdk/src/examples/httpd.py View 5 chunks +29 lines, -27 lines 0 comments Download
M native_client_sdk/src/tools/create_nmf.py View 5 chunks +8 lines, -8 lines 0 comments Download
M native_client_sdk/src/tools/getos.py View 3 chunks +8 lines, -8 lines 0 comments Download
M native_client_sdk/src/tools/oshelpers.py View 1 6 chunks +13 lines, -12 lines 0 comments Download
M native_client_sdk/src/tools/zip_test.py View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
binji
lgtm
8 years, 4 months ago (2012-08-24 23:28:29 UTC) #1
Sam Clegg
On 2012/08/24 23:28:29, binji wrote: > lgtm Continued from http://codereview.chromium.org/10868085/
8 years, 3 months ago (2012-09-04 17:54:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/10868089/12001
8 years, 3 months ago (2012-09-04 19:28:04 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-04 23:54:15 UTC) #4 
Change committed as 154856

Powered by Google App Engine
This is Rietveld 408576698