Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: native_client_sdk/src/build_tools/make_rules.py

Issue 10868089: add PRESUBMIT for native_client_sdk. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/build_tools/make_rules.py
diff --git a/native_client_sdk/src/build_tools/make_rules.py b/native_client_sdk/src/build_tools/make_rules.py
index b5c8823ecb68d8771cb3036f4639ed35a4b7a6c0..cbc3577425969e68b2e3761e02e03eeb3b64bed3 100755
--- a/native_client_sdk/src/build_tools/make_rules.py
+++ b/native_client_sdk/src/build_tools/make_rules.py
@@ -5,6 +5,8 @@
import os
+# pylint: disable=C0301
+# This file contains lines longer than 80
#
# Default macros for various platforms.
@@ -294,6 +296,10 @@ class MakeRules(object):
def __init__(self, tc, cfg=None, arch=None):
self.tc = tc
+ self.project = ''
+ self.cfg = ''
+ self.arch = ''
+ self.ptype = ''
self.defines = []
self.includes = []
self.libraries = []
@@ -332,7 +338,7 @@ class MakeRules(object):
self.vars['<EXT>'] = EXT
out = '<tc>/<config>/%s_<ARCH>.o : %s $(THIS_MAKE) | <tc>/<config>\n' % (
os.path.splitext(src)[0], src)
- out+= BUILD_RULES[self.tc][EXT][self.cfg] + '\n\n'
+ out += BUILD_RULES[self.tc][EXT][self.cfg] + '\n\n'
return self.Replace(out)
def BuildLinkRule(self):
@@ -396,7 +402,6 @@ class MakeRules(object):
self.SetLibraries(libs)
def SetSource(self, src):
- self.source = source
self.vars['<src>'] = src
def SetToolchain(self, tc):
@@ -421,7 +426,6 @@ class MakeRules(object):
# Add other passed in replacements
for key in kwargs:
self.vars['<%s>' % key] = kwargs[key]
- self.var_set = kwargs
def Replace(self, text):
return Replace(text, self.vars)
« no previous file with comments | « native_client_sdk/src/build_tools/build_utils.py ('k') | native_client_sdk/src/build_tools/manifest_util.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698