Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: native_client_sdk/src/build_tools/sdk_tools/update_manifest.py

Issue 10868089: add PRESUBMIT for native_client_sdk. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/build_tools/sdk_tools/update_manifest.py
diff --git a/native_client_sdk/src/build_tools/sdk_tools/update_manifest.py b/native_client_sdk/src/build_tools/sdk_tools/update_manifest.py
index 9b7e7c6f569cfd9c0b7ddf3e17f33cc2406d095a..f0af47d63792eec62971f3fa445851627530d581 100755
--- a/native_client_sdk/src/build_tools/sdk_tools/update_manifest.py
+++ b/native_client_sdk/src/build_tools/sdk_tools/update_manifest.py
@@ -25,7 +25,7 @@ sys.path.append(os.path.join(NACL_DIR, 'build'))
import sdk_update
-HELP='''"Usage: %prog [-b bundle] [options]"
+HELP = '''"Usage: %prog [-b bundle] [options]"
Actions for particular bundles:
sdk_tools: Upload the most recently built nacl_sdk.zip and sdk_tools.tgz
@@ -84,7 +84,7 @@ def UpdateBundle(bundle, options):
option_val = getattr(options, option_key, None)
if option_val is not None:
bundle[attribute_key] = option_val
- delattr(options, option_key);
+ delattr(options, option_key)
# Validate what we have so far; we may just avoid going through a lengthy
# download, just to realize that some other trivial stuff is missing.
bundle.Validate()
@@ -93,7 +93,7 @@ def UpdateBundle(bundle, options):
platform_url = getattr(options, option_key, None)
if platform_url is not None:
bundle.UpdateArchive(host_os, platform_url)
- delattr(options, option_key);
+ delattr(options, option_key)
class UpdateSDKManifest(sdk_update.SDKManifest):
@@ -154,7 +154,7 @@ class UpdateSDKManifest(sdk_update.SDKManifest):
raise Error('Unused option "%s" for bundle "%s"' % (key, bundle_name))
else:
raise Error('No bundle name specified')
- return True;
+ return True
def UpdateManifest(self, options):
''' Update the manifest object with values from the command-line options
« no previous file with comments | « native_client_sdk/src/build_tools/sdk_tools/set_nacl_env.py ('k') | native_client_sdk/src/build_tools/update_nacl_manifest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698